> Le 19 déc. 2017 à 10:50, Esteban Lorenzano a écrit :
>
> but this is because we still need to stabilise the CI: what happens now is
> that we know some tests are failing randomly then we do not trust the CI to
> tell us everything is ok.
> Then we accept PRs in red state.
> Of course, this
ahhh ok so this is then really nothing. Just blurs any further tests.
So in case case we should do two PR on without iceberg and one for
iceberg + change the test after...
Seems to me a bit over kill.
On Tue, Dec 19, 2017 at 6:37 PM, Cyril Ferlicot
wrote:
>
> On mar. 19 déc. 2017 at 18:27
On mar. 19 déc. 2017 at 18:27, Stephane Ducasse
wrote:
> Yes sorry I did not think that it could crash.
> I do not really understand why the tooltip can break only for one tool.
>
Hi,
With the tooltips I added a test to ensure all tools have an explanation.
Currently there is one missing for Ic
Yes sorry I did not think that it could crash.
I do not really understand why the tooltip can break only for one tool.
On Mon, Dec 18, 2017 at 9:12 AM, Pavel Krivanek
wrote:
> it was a bad idea to integrate PR 606 [1] about the world menu tooltips
> before it was green. Now we have failing tests
but this is because we still need to stabilise the CI: what happens now is that
we know some tests are failing randomly then we do not trust the CI to tell us
everything is ok.
Then we accept PRs in red state.
Of course, this will fail eventually, and that’s what we are seeing.
Most important
The same for https://github.com/pharo-project/pharo/pull/514
:-(
2017-12-18 9:12 GMT+01:00 Pavel Krivanek :
> it was a bad idea to integrate PR 606 [1] about the world menu tooltips
> before it was green. Now we have failing tests in the development branch
> and validations of new pull requests
it was a bad idea to integrate PR 606 [1] about the world menu tooltips
before it was green. Now we have failing tests in the development branch
and validations of new pull requests will fail immediately.
Btw. I do not think this test should be in the ReleaseTest because these
tests should be vali
