Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-28 Thread stepharo
Hi dale Le 8/8/16 à 15:00, Dale Henrichs a écrit : Max, Thanks for looking into this. Do you think that this bug will be fixed in Pharo5.0? When I'm debugging the tests with this fatal pattern, my only recourse is to start and stop images between test runs ... Definitively. We do

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-28 Thread stepharo
Thank you all for taking care and feeling like Pharo is your baby :). Stef Le 8/8/16 à 09:11, Max Leske a écrit : Thanks Nicolai. I’ve opened an issue on phogbugz: https://pharo.fogbugz.com/f/cases/18885/Ensure-blocks-in-test-tear-down-not-always-executed. On 8 Aug 2016, at 09:03,

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Max Leske
> On 9 Aug 2016, at 00:03, Nicolai Hess wrote: > > > > 2016-08-08 17:35 GMT+02:00 Max Leske >: > >> On 8 Aug 2016, at 17:15, Nicolai Hess > > wrote: >> >> >> >>

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Nicolai Hess
2016-08-08 17:35 GMT+02:00 Max Leske : > > On 8 Aug 2016, at 17:15, Nicolai Hess wrote: > > > > 2016-08-08 15:26 GMT+02:00 Max Leske : > >> >> On 8 Aug 2016, at 15:00, Dale Henrichs >> wrote: >> >>

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Max Leske
> On 8 Aug 2016, at 17:15, Nicolai Hess wrote: > > > > 2016-08-08 15:26 GMT+02:00 Max Leske >: > >> On 8 Aug 2016, at 15:00, Dale Henrichs > >

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Nicolai Hess
2016-08-08 15:26 GMT+02:00 Max Leske : > > On 8 Aug 2016, at 15:00, Dale Henrichs > wrote: > > Max, > > Thanks for looking into this. > > Do you think that this bug will be fixed in Pharo5.0? When I'm debugging > the tests with this fatal

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Max Leske
> On 8 Aug 2016, at 15:00, Dale Henrichs > wrote: > > Max, > > Thanks for looking into this. > > Do you think that this bug will be fixed in Pharo5.0? When I'm debugging the > tests with this fatal pattern, my only recourse is to start and stop images >

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Dale Henrichs
Max, Thanks for looking into this. Do you think that this bug will be fixed in Pharo5.0? When I'm debugging the tests with this fatal pattern, my only recourse is to start and stop images between test runs ... The side effect of not running ensure blocks in tests is that a SharedQueue gets

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Max Leske
Thanks Nicolai. I’ve opened an issue on phogbugz: https://pharo.fogbugz.com/f/cases/18885/Ensure-blocks-in-test-tear-down-not-always-executed . > On 8 Aug 2016, at 09:03, Nicolai Hess

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Nicolai Hess
2016-08-08 8:52 GMT+02:00 Max Leske : > Wow, that’s pretty bad. The process termination logic should be taking > care of the ensure blocks. Unfortunately I can’t run any Pharo images at > the moment but if there’s something wrong with process termination then > it’s likely

Re: [Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-08 Thread Max Leske
Wow, that’s pretty bad. The process termination logic should be taking care of the ensure blocks. Unfortunately I can’t run any Pharo images at the moment but if there’s something wrong with process termination then it’s likely that me or Ben made some mistake. Could someone please rerun Dale’s

[Pharo-dev] ensure blocks in TestCase>>tearDown are not run if an error occurs inside ensured block when test itself was halted ...

2016-08-07 Thread Dale Henrichs
While attempting to characterize the "Empty Debugger" problem that I've recently reported[1], I found that ensure blocks in TestCase>>teardown methods are not run if an Error is signaled while executing the code protected by the ensure block ... when the test itself brings up a debugger ---