Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-26 Thread Eliot Miranda
On Wed, Nov 24, 2010 at 6:10 PM, Igor Stasenko wrote: > On 25 November 2010 03:45, Juan Vuletich wrote: > > Igor Stasenko wrote: > >> > >> IMO SimpleMorphic, minus 'color' ivar in Morph class is a way to go. > >> (i mean get rid that 'color' thing in base class) :) > >> > >> > > > > Yep. I full

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-25 Thread Stéphane Ducasse
Now I will see who will port/rewrite what we have on top of a cleaned SimpleMorphic. > Stéphane Ducasse wrote: >> Indeed. I mean >> I can't help, but feel free to go ahead >> >> Stef >> >> > Great! Thanks for the clarification. > > Cheers, > Juan Vuletich >

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-25 Thread Stéphane Ducasse
this is just for state. You have traits for methods. For me the way to go is first clean the classbuilder, have first class instance variables, what you want is just hashSubclass: instead of variableSubclass: Stef > > IMO SimpleMorphic, minus 'color' ivar in Mor

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-24 Thread Juan Vuletich
Igor Stasenko wrote: I think, for things like Morphic, where there are dozens of various properties expected to be in basic morph class, we should use dictionaries, backed up by clever VM semantics. I cannot stop thinking about extending object format to allow a dynamic number of slots per object

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-24 Thread Igor Stasenko
On 25 November 2010 03:45, Juan Vuletich wrote: > Igor Stasenko wrote: >> >> IMO SimpleMorphic, minus 'color' ivar in Morph class is a way to go. >> (i mean get rid that 'color' thing in base class)  :) >> >> > > Yep. I fully agree. > I think, for things like Morphic, where there are dozens of var

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-24 Thread Juan Vuletich
Igor Stasenko wrote: IMO SimpleMorphic, minus 'color' ivar in Morph class is a way to go. (i mean get rid that 'color' thing in base class) :) Yep. I fully agree. Cheers, Juan Vuletich

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-24 Thread Juan Vuletich
Stéphane Ducasse wrote: Indeed. I mean I can't help, but feel free to go ahead Stef Great! Thanks for the clarification. Cheers, Juan Vuletich

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-24 Thread Igor Stasenko
IMO SimpleMorphic, minus 'color' ivar in Morph class is a way to go. (i mean get rid that 'color' thing in base class) :) On 24 November 2010 16:49, Stéphane Ducasse wrote: > Indeed. I mean >        I can't help, but feel free to go ahead > > Stef > > >> "I do not think that we can build so

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-24 Thread Stéphane Ducasse
Indeed. I mean I can't help, but feel free to go ahead Stef > "I do not think that we can build something on simpleMorphic, what we can do > is look at the kernel and see how the changes can be applied to Morphic", > > it really means that it should better not be done. It means "I

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-22 Thread Juan Vuletich
Hi Stef, Stéphane Ducasse wrote: - clean again all the MVC dependencies FillInTheBlank? PopUpMenu? Those might be not pretty, and I agree they can be replaced by something better, but they are not MVC dependencies. Well, that doesn't stop Mariano from fighting

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-22 Thread Stéphane Ducasse
> ...k that we can build something on simpleMorphic, >>> Why? That would be a huge disappointment. >>> >> >> so it means that we should - throw/redo polymorph extensions (because even >> if some code of polymorph sucks because gary did it to turn around >>morphic

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-22 Thread Juan Vuletich
Hi Stef, Stéphane Ducasse wrote: ... k that we can build something on simpleMorphic, Why? That would be a huge disappointment. so it means that we should - throw/redo polymorph extensions (because even if some code of polymorph sucks because gary did it to turn around morphi

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-22 Thread Stéphane Ducasse
>>> >>>We should get in the sophie events hierarchy. no ? >>> It depends of the amount of work it would requires... >>> what about working on SimpleMorphic for that ? >>> >> >> I do not think that we can build something on simpleMorphic, > > Why? That would be a huge disappoi

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-21 Thread Juan Vuletich
Hi Stef, Stéphane Ducasse wrote: On Nov 20, 2010, at 2:21 PM, Alain Plantec wrote: Le 20/11/2010 10:21, Stéphane Ducasse a écrit : We should get in the sophie events hierarchy. no ? It depends of the amount of work it would requires... what about working on SimpleMorphic for t

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-20 Thread Stéphane Ducasse
On Nov 20, 2010, at 2:21 PM, Alain Plantec wrote: > Le 20/11/2010 10:21, Stéphane Ducasse a écrit : >> We should get in the sophie events hierarchy. no ? > It depends of the amount of work it would requires... > what about working on SimpleMorphic for that ? I do not think that we can build some

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-20 Thread Alain Plantec
Le 20/11/2010 10:21, Stéphane Ducasse a écrit : We should get in the sophie events hierarchy. no ? It depends of the amount of work it would requires... what about working on SimpleMorphic for that ? Alain Stef Cheers Alain

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-20 Thread Stéphane Ducasse
On Nov 19, 2010, at 1:07 PM, Alain Plantec wrote: > Le 19/11/2010 08:21, Fernando Olivero a écrit : >> Hi Alain, i took a better look at the changes and have to say...once >> again..excellent! > Thanks Fernando! >> I think the next step is to improve the keybindings hardcoding in >> TextEditor>>

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-19 Thread Alain Plantec
What I would like is to be able to control all alt-ctrl-cmd-shift etc possible combinations for any morph. It implies to review the way events are handled by Morph/HandMorph and to remove the ugly "control and alt key" setting (Full matching, partial matching, Swapped). For example, it is c

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-19 Thread Alain Plantec
Le 19/11/2010 08:21, Fernando Olivero a écrit : Hi Alain, i took a better look at the changes and have to say...once again..excellent! Thanks Fernando! I think the next step is to improve the keybindings hardcoding in TextEditor>>initialize self initializeCmdKeyShortcuts. self

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-19 Thread Stéphane Ducasse
Yes! we were discussing with alain about that. Please sync with alain. Fernando here is also what I would like to have :) A classVar Binding and an instance var binding. **All** the methods only access binding binding get initialized with the default table defined in Binding => we can have table b

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-18 Thread Tudor Girba
I agree :). Doru On 19 Nov 2010, at 08:21, Fernando Olivero wrote: > Hi Alain, i took a better look at the changes and have to say...once > again..excellent! > > I think the next step is to improve the keybindings hardcoding in > TextEditor>>initialize > self initializeCmdKeyShortcuts. >

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-18 Thread Fernando Olivero
Hi Alain, i took a better look at the changes and have to say...once again..excellent! I think the next step is to improve the keybindings hardcoding in TextEditor>>initialize self initializeCmdKeyShortcuts. self initializeShiftCmdKeyShortcuts. I have a keybindings/command model i

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-18 Thread Alain Plantec
Due to a change in PragmaMenuBuilder, the world menu is not well updated anymore. Simply evaluating World resetWorldMenu fixes that. So it should be done before the next release is published. Cheers Alain

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-17 Thread Stéphane Ducasse
oh yes! Thanks a lot alain. Stef > Wow this looks great, thanks!

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-17 Thread Francisco Ortiz Peñaloza
Wow this looks great, thanks! On Wed, Nov 17, 2010 at 6:09 PM, Alain Plantec wrote: > Le 17/11/2010 21:29, Fernando Olivero a écrit : > > Hi Fernando > > Hi Alain, this is great work! Improving text editor is must. >> I'm looking forward to see your changes. >> >> Just one remark, please use eng

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-17 Thread Fernando Olivero
Hi Alain, this is great work! Improving text editor is must. I'm looking forward to see your changes. Just one remark, please use english next time! Fernando 2010/11/17 ph...@googlecode.com : > Status: Accepted > Owner: stephane.ducasse > CC: aplantec > Labels: Milestone-1.2 > > New issue 3266 by

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-17 Thread pharo
Updates: Status: Closed Comment #2 on issue 3266 by stephane.ducasse: Clean TextEditor http://code.google.com/p/pharo/issues/detail?id=3266 integrated in 12243

Re: [Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-17 Thread pharo
Comment #1 on issue 3266 by stephane.ducasse: Clean TextEditor http://code.google.com/p/pharo/issues/detail?id=3266 Did you make the changes parametrized?

[Pharo-project] Issue 3266 in pharo: Clean TextEditor

2010-11-17 Thread pharo
Status: Accepted Owner: stephane.ducasse CC: aplantec Labels: Milestone-1.2 New issue 3266 by stephane.ducasse: Clean TextEditor http://code.google.com/p/pharo/issues/detail?id=3266 voila ce que j'ai fait: * nettoyage de TextEditor (plus que 2 variables d'instances, plus de variables de classe