[Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-15 Thread pharo
Status: Accepted Owner: marcus.d...@gmail.com Labels: Milestone-1.2-DevImage New issue 3707 by marcus.d...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 ... especially using BOLD for variables (both global and local), but arguments use differ

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-16 Thread pharo
Updates: Cc: Benjamin.VanRyseghem Comment #1 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I will integrate first the fixes of ben for 3583

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-16 Thread pharo
Comment #2 on issue 3707 by benjamin...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 You can change that in your settings. I can maybe propose a fix to change default value :)

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-16 Thread pharo
Comment #3 on issue 3707 by tudor.gi...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 In the latest version of GLMUITheme (from squeaksource.com/Glamour), you get a setPreferredShoutColors which pretty much reproduces the old highlightin

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-16 Thread pharo
Comment #4 on issue 3707 by benjamin...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I just committed a new version of Shout with no more bold. But I'm not familiar with the old styling, so maybe one of you, "old" Smalltalker could have

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-25 Thread pharo
Comment #5 on issue 3707 by marcus.d...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 Why don't we just change it back to how it used to be? We are *frozen* and want to release 1.2 ASAP (that is, 2 month ago). Yet, someone changed compel

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-25 Thread pharo
Comment #6 on issue 3707 by tudor.gi...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I agree. Do you know where these changes are?

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #7 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I do not know how this is changed but probably there is a default table somewhere and we can take the same as in 1.3 or 1.1

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #8 on issue 3707 by benjamin...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I know where it is, I will take a look tomorrow, tonight it's party ^^

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #9 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 SHTextStylerST80>>defaultStyleTable I'm currently checking 1.0 and 1.2

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #10 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 marcus from which image did you do your screen shot? Because I tried with 1.0, 1.1 and pasted it in 1.2 but I do not get the same results. and even in

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #11 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 BTW the bold for the instance var is nice because you can see immediately if the class is doing an instance variable access. Finally I do not see why th

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Updates: Status: Fixed Comment #12 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 So I would close this issue. I tried to reproduce the attached png and I cannot really see self. so cyan is not really ad

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #13 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 here is the one of 1.1 defaultStyleTable "color can be a valid argument to Color class>>colorFrom: , or nil to use the editor text color.

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-26 Thread pharo
Comment #14 on issue 3707 by tudor.gi...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 Bold and italic do not work well with the DejaVu font. This is because in this font the italic / bold characters have a different width than the norma

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Updates: Status: FixProposed Comment #15 on issue 3707 by marcus.d...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 (No comment was entered for this change.)

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #16 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 Ok I will remove the bold and we can integrate it.

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #17 on issue 3707 by marcus.d...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 Not only the bold. Just revert to the 1.1 style. Let's then experiment in 1.3

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #18 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 but I'm not experimenting. Reverting to the one of 1.1 does not remove the bold!

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #19 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 so from which image do you have something ok so that I copy it? Because else this is boring try and error.

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #20 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 Ok I found it. SHTextStylerST80 initialize should be done after reverting the style.

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #21 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I published a new version in shout. Now I'm looking at the configuration. to see if it should be updated. So we can close this issue.

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Updates: Status: Closed Comment #22 on issue 3707 by stephane...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I fixed the configurationOfShout and configurationOfPharo. Now I will try to load that.

Re: [Pharo-project] Issue 3707 in pharo: Syntax highlighting looks strange

2011-02-27 Thread pharo
Comment #23 on issue 3707 by tudor.gi...@gmail.com: Syntax highlighting looks strange http://code.google.com/p/pharo/issues/detail?id=3707 I copied the latest Glamour-Morphic-Theme in PharoInbox. In there you have the method: GLMUITheme class>>setPreferredShoutColors that has the set of col