Re: [Pharo-project] Small improvement for WriteStream nextPutAll:

2012-01-09 Thread Henrik Sperre Johansen
On 09.01.2012 00:18, Eliot Miranda wrote: On Sun, Jan 8, 2012 at 5:46 AM, Mariano Martinez Peck marianop...@gmail.com mailto:marianop...@gmail.com wrote: Hi guys. Some time ago Henry spot to us a small improvement for WriteStream nextPutAll: that we are using in Fuel, but I think

Re: [Pharo-project] Small improvement for WriteStream nextPutAll:

2012-01-09 Thread Nicolas Cellier
2012/1/9 Henrik Sperre Johansen henrik.s.johan...@veloxit.no: On 09.01.2012 00:18, Eliot Miranda wrote: On Sun, Jan 8, 2012 at 5:46 AM, Mariano Martinez Peck marianop...@gmail.com mailto:marianop...@gmail.com wrote:    Hi guys. Some time ago Henry spot to us a small improvement for    

[Pharo-project] Small improvement for WriteStream nextPutAll:

2012-01-08 Thread Mariano Martinez Peck
Hi guys. Some time ago Henry spot to us a small improvement for WriteStream nextPutAll: that we are using in Fuel, but I think it can be general. Henry comment was exactly: *Also: For variableBytes classes, if you rewrite: WriteStream nextPutAll: aCollection | newEnd | collection

Re: [Pharo-project] Small improvement for WriteStream nextPutAll:

2012-01-08 Thread Nicolas Cellier
Yes it makes big differences when you mix ByteString/ByteArray for example... Or shouldn't we just let #replaceFrom:to:with:startingAt: do the job ? That's what I did in my own image in #next:putAll:startingAt:, I completely removed the test and it seems to work well. I then let #nextPutAll:

Re: [Pharo-project] Small improvement for WriteStream nextPutAll:

2012-01-08 Thread Eliot Miranda
On Sun, Jan 8, 2012 at 5:46 AM, Mariano Martinez Peck marianop...@gmail.com wrote: Hi guys. Some time ago Henry spot to us a small improvement for WriteStream nextPutAll: that we are using in Fuel, but I think it can be general. Henry comment was exactly: *Also: For variableBytes classes,