Re: [Pharo-project] TestCase#assert:equals: optimization

2012-04-27 Thread Mariano Martinez Peck
Fix in inbox http://code.google.com/p/pharo/issues/detail?id=5562 On Thu, Mar 15, 2012 at 8:58 PM, Stefan Marr smallt...@stefan-marr.dewrote: Hi: While stepping through bytecodes, I noticed a slightly annoying inefficiency in the SUnit implementation. The description string in

Re: [Pharo-project] TestCase#assert:equals: optimization

2012-04-27 Thread Stefan Marr
Hi Mariano: On 27 Apr 2012, at 10:24, Mariano Martinez Peck wrote: Fix in inbox http://code.google.com/p/pharo/issues/detail?id=5562 What happened to the issue I created, and which included a patch? http://code.google.com/p/pharo/issues/detail?id=5487 Best regards Stefan -- Stefan Marr

Re: [Pharo-project] TestCase#assert:equals: optimization

2012-04-27 Thread Mariano Martinez Peck
On Fri, Apr 27, 2012 at 11:20 AM, Stefan Marr smallt...@stefan-marr.dewrote: Hi Mariano: On 27 Apr 2012, at 10:24, Mariano Martinez Peck wrote: Fix in inbox http://code.google.com/p/pharo/issues/detail?id=5562 What happened to the issue I created, and which included a patch?

Re: [Pharo-project] TestCase#assert:equals: optimization

2012-04-27 Thread Stefan Marr
Hi Mariano: On 27 Apr 2012, at 13:11, Mariano Martinez Peck wrote: http://code.google.com/p/pharo/issues/detail?id=5562 What happened to the issue I created, and which included a patch? http://code.google.com/p/pharo/issues/detail?id=5487 I didn't integrate 5487. I did integrate what

Re: [Pharo-project] TestCase#assert:equals: optimization

2012-03-16 Thread Pavel Krivanek
On Fri, Mar 16, 2012 at 8:28 AM, Marcus Denker marcus.den...@inria.fr wrote: On Mar 15, 2012, at 11:20 PM, Nicolas Cellier wrote: Being able to automate is very good, however... rant I am 100% with you... my perfect system looks *completely* different to what we have... Can you, please,

[Pharo-project] TestCase#assert:equals: optimization

2012-03-15 Thread Stefan Marr
Hi: While stepping through bytecodes, I noticed a slightly annoying inefficiency in the SUnit implementation. The description string in #assert:equals: is always computed, even if it is not necessary. While that might not be a performance problem, I find it rather distracting when I have to

[Pharo-project] TestCase#assert:equals: optimization

2012-03-15 Thread Stefan Marr
Hi: While stepping through bytecodes, I noticed a bit annoying inefficiency in the SUnit implementation. The description string in #assert:equals: is always computed, even if it is not necessary. While that might not be a performance problem, I find it rather distracting when I have to debug

Re: [Pharo-project] TestCase#assert:equals: optimization

2012-03-15 Thread Stéphane Ducasse
thanks stefan Can you open a bug tracker and publish your code with a slice or a cs so that our crawler can handle it automatically? Yes we are getting professional thanks for camillo and ben :) Stef On Mar 15, 2012, at 8:58 PM, Stefan Marr wrote: Hi: While stepping through bytecodes, I

Re: [Pharo-project] TestCase#assert:equals: optimization

2012-03-15 Thread Nicolas Cellier
Being able to automate is very good, however... rant I find a great deal of issues report are unhelpful, not to say totally useless. Take for example http://code.google.com/p/pharo/issues/detail?id=5482 it just tells, hey look at the fix in this slice, and you'll understand Then some bits of