Hi,
In the latest Morphic version, the default styler of the PluggableTextMorph is
given by:
useDefaultStyler
"This should be changed to a proper registry but as long as there is
only shout this will do"
Smalltalk globals
at: #SHTextStylerST80
if
Why not delegate it in the used Editor ? SmalltalkEditor should use shout
while the other editors should use the NullTextStyler. Maybe something like
this:
PluggableTextMorph>>useDefaultStyler
self styler: textMorph editor styler
Or better:
PluggableTextMorph>>useDefaultStyler
self sty
Ufa,...
Editor>>styler
^NullTextStyler new
SmalltalkEditor>>styler
^...
Guille
On Sat, Jan 22, 2011 at 10:54 PM, Guillermo Polito <
guillermopol...@gmail.com> wrote:
> Why not delegate it in the used Editor ? SmalltalkEditor should use shout
> while the other editors should use the NullTe
Anyways, I'm looking that
PluggableTextMorph>>textMorphClass
"Answer the class used to create the receiver's textMorph"
^TextMorphForEditView
and
TextMorphForEditView>>editorClass
^ SmalltalkEditor
So it's what I suggested needs a lot of work more...
On Sat, Jan 22, 2011 at 10:58
This seems ok for me.
When others reply open a ticket + changes and we will integrate that.
On Jan 22, 2011, at 4:25 PM, Tudor Girba wrote:
> Hi,
>
> In the latest Morphic version, the default styler of the PluggableTextMorph
> is given by:
> useDefaultStyler
>"This should be changed t
Hi,
We need the imperfect, intermediate solution that is good enough for people to
live with
in 1.2.
On Jan 22, 2011, at 4:25 PM, Tudor Girba wrote:
> Hi,
>
> In the latest Morphic version, the default styler of the PluggableTextMorph
> is given by:
> useDefaultStyler
>"This should be
I think Tudor is right. We cannot have shout everywhere by default. Take an
example. Today morning, I opened the latest PharoDev and I couldn't
understand why my nice welcome workspace was converted to an ugly red text
workspace, like if it was code, which was not, of course. Now I read this
email
But that imperfect solution won't be a good solution either, since we are
not going to have shout styler anywhere :).
On Sun, Jan 23, 2011 at 4:47 AM, Marcus Denker wrote:
> Hi,
>
> We need the imperfect, intermediate solution that is good enough for people
> to live with
> in 1.2.
>
> On Jan 22,
On Jan 24, 2011, at 2:19 AM, Guillermo Polito wrote:
> But that imperfect solution won't be a good solution either, since we are not
> going to have shout styler anywhere :).
>
So how is that solved in1.1? We need, for 1.2, just a *usable* compromise.
Then we can iterate in 1.3
Marc
Hi,
I opened a ticket. We should move the discussion there:
http://code.google.com/p/pharo/issues/detail?id=3583
Cheers,
Doru
On 24 Jan 2011, at 08:31, Marcus Denker wrote:
>
> On Jan 24, 2011, at 2:19 AM, Guillermo Polito wrote:
>
>> But that imperfect solution won't be a good solution eithe
Just as an additional comment (don't know if this is related or not):
For OB I had to subclass Editor and duplicate all SmalltalkEditor
functionality, because the same Morph instance is used different
contexts. Previously it was very easy to enable and disable syntax
highlighting and other Smallta
I've posted a change this morning when activating styling is just a message
(beStyled) to send to a PluggableTextMorph
Ben
On Jan 24, 2011, at 4:46 PM, Lukas Renggli wrote:
> Just as an additional comment (don't know if this is related or not):
>
> For OB I had to subclass Editor and duplica
Hi Lukas,
When you say "previously" do you mean with
ParagraphEditor or with previous version of
Editor/TextEditor/SmalltalkEditor ?
Cheers
Alain
Le 24/01/2011 16:46, Lukas Renggli a écrit :
Just as an additional comment (don't know if this is related or not):
For OB I had to subclass Editor
I mean with the old ParagraphEditor. I am not saying that the old
ParagraphEditor was better (it had lots of other problems), but the
separation between Editor and SmalltalkEditor makes the OB code much
more complicated.
Also having to send #beStyled is kind of tricky. The previous pull
mechanism
ok we will have to iterate once more time... :)
Tx for the report lukas.
Stef
On Jan 24, 2011, at 5:37 PM, Lukas Renggli wrote:
> I mean with the old ParagraphEditor. I am not saying that the old
> ParagraphEditor was better (it had lots of other problems), but the
> separation between Editor and
15 matches
Mail list logo