Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Here is the new PR: https://github.com/pharo-project/pharo/pull/1731 > On 31 Aug 2018, at 11:17, Marcus Denker wrote: > > Hi, > > I had a look: this works nicely! > > I even found a way to automatically fall back to the method creation, so > > nil doSomething > > on create will cre

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi, I had a look: this works nicely! I even found a way to automatically fall back to the method creation, so nil doSomething on create will create a method. I have merged your code and will do a PR with the improvement later. Marcus > On 30 Aug 2018, at 09:57, Marcus Denker wrote

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Thanks! I will have a look at the sprint tomorrow. > On 30 Aug 2018, at 07:11, Tim Mackinnon wrote: > > I’ve submitted a PR for what I did, so at least it improves the situation > (but potentially could get even more refined as you suggest) > > Tim > >> On 23 Aug 2018, at 11:26, Marcus Denk

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

I’ve submitted a PR for what I did, so at least it improves the situation (but potentially could get even more refined as you suggest) Tim > On 23 Aug 2018, at 11:26, Marcus Denker wrote: > > > >> On 23 Aug 2018, at 15:56, Tim Mackinnon wrote: >> >> Hi Marcus - that’s actually what I do -

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 23 Aug 2018, at 15:56, Tim Mackinnon wrote: > > Hi Marcus - that’s actually what I do - and “create” in this case, creates a > class and then restarts like the method case does. > Yes, that I saw. But I mean a different case: Imagine you do have code like nil doSomething or

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi Marcus - that’s actually what I do - and “create” in this case, creates a class and then restarts like the method case does. I guess I was wondering if we can do it more cleanly and also improve the debugger message. If I’ve understood you guys correctly- you try to remove the ambiguity aro

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 22 Aug 2018, at 16:24, Tim Mackinnon wrote: > > Hi - but I guess my question is (and excuse my basic knowledge in this area) > - when a class isn’t found - can we do better than return nil so that the > debugger can give a better msg and presumably the code I’ve written could > live on

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi - but I guess my question is (and excuse my basic knowledge in this area) - when a class isn’t found - can we do better than return nil so that the debugger can give a better msg and presumably the code I’ve written could live on that undefined object? Or am thinking about this wrong? I wil

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi, I played with it, nice! I guess the case when you really get a DNU on nil (and want to create method there) does not really happen… extending nil is for special cases. Marcus > On 22 Aug 2018, at 13:39, Tim Mackinnon wrote: > > Sorry Marcus - you needed to follow the exercism i

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Sorry Marcus - you needed to follow the exercism instructions and right click on the exercism package to get an exercism menu to fetch a new exercise (e.g. hello-world). The is then using the TonalReader to pull in code - and then you get a test class that can reference a class that isn’t there

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 17 Aug 2018, at 14:20, Tim Mackinnon wrote: > > The direct link to instructions is here: > https://exercism.io/tracks/pharo/installation (not sure if you have to be > signed up to see it otherwise its in the repo here: > https://github.com/exercism/pharo/blob/master/docs/INSTALLATION.m

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

The direct link to instructions is here: https://exercism.io/tracks/pharo/installation (not sure if you have to be signed up to see it otherwise its in the repo here: https://github.com/exercism/pharo/blob/master/docs/INSTALLATION.md

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 17 Aug 2018, at 13:00, Tim Mackinnon wrote: > > > Hi Marcus - I can put an image somewhere if that helps (do you just need the > .image and .changes)? > > Or you can repro from a fresh 6.1 if you follow the exercism Pharo > instructions (https://exercism.io/tracks/pharo >

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi Marcus - I can put an image somewhere if that helps (do you just need the .image and .changes)? Or you can repro from a fresh 6.1 if you follow the exercism Pharo instructions (https://exercism.io/tracks/pharo) to load the first hello world-world example and run the tests. This has my code

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 10 Aug 2018, at 23:16, Tim Mackinnon wrote: > > Actually I think I figured that bit out - a bit clumsily - (pointers > appreciated) > > createMissingClassActionFor: aMessage in: aContext > |errorNode senderContext newClass variableNode | > senderContext := aContext sender. >

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

I guess for a bit of historical record - I fixed the Pharo 6.1 image in exercism to properly handle the creation of a missing class. Not a lot of code (but you do need the right code - and it is slightly confusing how the debugger window is so tightly tied to the model which also has the stack a

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Actually I think I figured that bit out - a bit clumsily - (pointers appreciated) createMissingClassActionFor: aMessage in: aContext |errorNode senderContext newClass variableNode | senderContext := aContext sender. errorNode := senderContext method sourceNodeExecutedForPC

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hey Marcus (or those knowledgable about stacks and contexts) - to self #1 - where the create button generates a class instead of a method, I’m a bit out of my depth. I can see there is a DoesNotUnderstandDebugAction (which the create button calls). So to determine if the failure was due to a m

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Marcus, I love this idea, not showing the menu at all would be more aligned to live coding. As you said in a later e-mail it must be fixed at runtime, while running the tests. Thanks! On Thu, Aug 9, 2018 at 5:07 AM Marcus Denker wrote: > > > > > >> 2) when coding - if you want reference a mis

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

On 7 August 2018 at 20:01, Tim Mackinnon wrote: > Hi guys - I’ve been hammering on the exercism project to get pharo shining > over there… its been a good side distraction (there is lots of energy in > that community to) and its made me really push my use of Iceberg & git as > well as learn some

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Guys - you’re awesome! It really shows why our environment is so powerful and why more people need to think this way! For back porting - you don’t need to, as for exercism we are loading a script anyway, so I can load in some code until we’re ready for 7.0 I do agree that infinite debuggers is

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 9 Aug 2018, at 10:59, Guillermo Polito wrote: > > Hi Marcus, > > Is it wise to backport things that may break things like this? maybe not, but it just took 5 minutes as it is very simple > I'd prefer to put the energy on backporting the workaround to avoid the > infinite debuggers... >

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi Marcus, Is it wise to backport things that may break things like this? I'd prefer to put the energy on backporting the workaround to avoid the infinite debuggers... On Thu, Aug 9, 2018 at 10:50 AM Marcus Denker wrote: > > 2) when coding - if you want reference a missing class, why don’t we l

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> >> 2) when coding - if you want reference a missing class, why don’t we let >> you? TonelReader seems to do it, why can’t the editor? (This probably >> applies to variables as well - show them broken, let me fix it when I >> choose. The iVar case is a little rarer - although I hate the way we

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 9 Aug 2018, at 10:06, Marcus Denker wrote: > >> >> >>> 2) when coding - if you want reference a missing class, why don’t we let >>> you? TonelReader seems to do it, why can’t the editor? (This probably >>> applies to variables as well - show them broken, let me fix it when I >>> choo

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> > >> 2) when coding - if you want reference a missing class, why don’t we let >> you? TonelReader seems to do it, why can’t the editor? (This probably >> applies to variables as well - show them broken, let me fix it when I >> choose. The iVar case is a little rarer - although I hate the way

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi Tim, I can only tell you that I agree with you ^^. Last year we worked with Stef and Luc on the idea of undefined classes ( https://hal.archives-ouvertes.fr/hal-01585305/document). The code is available in smalltalkhub if I remember well (check the links in the paper). We did not integrate it

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

> On 9 Aug 2018, at 08:20, Tim Mackinnon wrote: > > Feenk re-imagining aside (which I will pursue with them), it seems like our > current tools can support this better right? > > I see two issues: > > 1) if we encounter a not present class can we fix the debugger to offer > something like w

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Feenk re-imagining aside (which I will pursue with them), it seems like our current tools can support this better right? I see two issues: 1) if we encounter a not present class can we fix the debugger to offer something like we do for a missing method so it’s less obtuse? 2) when coding - if

Re: [Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

+1 On Tue, 7 Aug 2018 at 09:02 Tim Mackinnon wrote: > Hi guys - I’ve been hammering on the exercism project to get pharo shining > over there… its been a good side distraction (there is lots of energy in > that community to) and its made me really push my use of Iceberg & git as > well as learn

[Pharo-users] Making TDD in pharo work properly (aka - walkback on a missing class is nasty)

Hi guys - I’ve been hammering on the exercism project to get pharo shining over there… its been a good side distraction (there is lots of energy in that community to) and its made me really push my use of Iceberg & git as well as learn some fo the newish file reference stuff (still getting good