Re: [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings

2024-04-05 Thread Conor Dooley
On Fri, Apr 05, 2024 at 05:24:11PM +0100, Conor Dooley wrote: > On Fri, Apr 05, 2024 at 11:25:50AM +0100, Dave Stevenson wrote: > > Hi Conor > > > > On Wed, 3 Apr 2024 at 17:14, Conor Dooley wrote: > > > > > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, g...@luigi311.com wrote: > > > > From: Dave

Re: [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings

2024-04-05 Thread Conor Dooley
On Fri, Apr 05, 2024 at 11:25:50AM +0100, Dave Stevenson wrote: > Hi Conor > > On Wed, 3 Apr 2024 at 17:14, Conor Dooley wrote: > > > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, g...@luigi311.com wrote: > > > From: Dave Stevenson > > > > > > There are a number of variants of the imx258 modules

Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros

2024-04-05 Thread Tommaso Merciai
Hi Luis, On Fri, Apr 05, 2024 at 04:33:38AM -0600, Luis Garcia wrote: > On 4/4/24 00:46, Sakari Ailus wrote: > > On Wed, Apr 03, 2024 at 01:17:26PM -0600, Luigi311 wrote: > >> On 4/3/24 10:23, Sakari Ailus wrote: > >>> Hi Luis, > >>> > >>> On Wed, Apr 03, 2024 at 09:03:50AM -0600,

Re: [PATCH v3 19/25] media: i2c: imx258: Change register settings for variants of the sensor

2024-04-05 Thread Dave Stevenson
Hi Sakari On Fri, 5 Apr 2024 at 11:59, Sakari Ailus wrote: > > Hi Luis, Dave, > > On Thu, Apr 04, 2024 at 04:44:05PM -0600, Luigi311 wrote: > > On 4/3/24 10:18, Sakari Ailus wrote: > > > Hi Luis, Dave, > > > > > > On Wed, Apr 03, 2024 at 09:03:48AM -0600, g...@luigi311.com wrote: > > >> From:

Re: [PATCH v3 19/25] media: i2c: imx258: Change register settings for variants of the sensor

2024-04-05 Thread Sakari Ailus
Hi Luis, Dave, On Thu, Apr 04, 2024 at 04:44:05PM -0600, Luigi311 wrote: > On 4/3/24 10:18, Sakari Ailus wrote: > > Hi Luis, Dave, > > > > On Wed, Apr 03, 2024 at 09:03:48AM -0600, g...@luigi311.com wrote: > >> From: Dave Stevenson > >> > >> Sony have advised that there are variants of the

Re: [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings

2024-04-05 Thread Dave Stevenson
Hi Conor On Wed, 3 Apr 2024 at 17:14, Conor Dooley wrote: > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, g...@luigi311.com wrote: > > From: Dave Stevenson > > > > There are a number of variants of the imx258 modules that can not > > be differentiated at runtime, so add compatible strings for the

Re: [PATCH v3 12/25] media: i2c: imx258: Allow configuration of clock lane behaviour

2024-04-05 Thread Pavel Machek
On Thu 2024-04-04 16:29:11, Luigi311 wrote: > On 4/3/24 12:48, Pavel Machek wrote: > > Hi! > > > >> The sensor supports the clock lane either remaining in HS mode > >> during frame blanking, or dropping to LP11. > >> > >> Add configuration of the mode via V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK. > >