ID: 31261
User updated by: dev at jkt dot wz dot cz
Reported By: dev at jkt dot wz dot cz
Status: Bogus
Bug Type: MySQL related
Operating System: all
PHP Version: 4.3.10
New Comment:
I know that your code works, but there is other solution which is more
readable, more elegant, faster and more C-like IMHO.
Of course you can write your code, say, without indentation, and it
*will* compile and work (the compilation time could be even a bit
faster due to reduced preprocessor overhead), but most of people simply
don't do it as it is considered "bad programming style".
Previous Comments:
------------------------------------------------------------------------
[2004-12-23 19:06:04] [EMAIL PROTECTED]
This is a non issue, the code avoids touching the mask if there is
nothing to change in it.
------------------------------------------------------------------------
[2004-12-22 23:41:33] dev at jkt dot wz dot cz
Description:
------------
Hi, sorry for creating another useless bugreport, but I haven't ability
to comment bugs in CLOSED state.
[Considering bug reports #23779 and #28632 and mainly lines 601-604 in
ext/mysql/php_mysql.c]
/* disable local infile option for open_basedir */
if (PG(open_basedir) && strlen(PG(open_basedir)) && (client_flags &
CLIENT_LOCAL_FILES)) {
client_flags ^= CLIENT_LOCAL_FILES;
}
Are you, PHP developers, sure that the approach "So, let's check bit 7.
Oh, it is set, uhm, so, let's read it, make a negation and the write it
back" the best way? Shouldn't be better (and also more elegant,
faster,...) to write something like:
if (PG(open_basedir) && strlen(open_basedir)) {
client_flags &= ~CLIENT_LOCAL_FILES;
}
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=31261&edit=1
