[PHP-CVS] cvs: php4 /sapi/cgi .cvsignore

2002-12-22 Thread Edin Kadribasic
edink Sun Dec 22 22:35:39 2002 EDT Modified files: /php4/sapi/cgi .cvsignore Log: MFB: Ignore the new name of the binary built. Allows cvsclean to work again in sapi/cgi. Index: php4/sapi/cgi/.cvsignore diff -u php4/sapi/cgi/.cvsignore:1.8 php4/sap

[PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi .cvsignore

2002-12-22 Thread Edin Kadribasic
edink Sun Dec 22 22:34:24 2002 EDT Modified files: (Branch: PHP_4_3) /php4/sapi/cgi .cvsignore Log: Ignore the new name of the binary built. Allows cvsclean to work again in sapi/cgi. Index: php4/sapi/cgi/.cvsignore diff -u php4/sapi/cgi/.cvsignore:1.

[PHP-CVS] cvs: php4 /main streams.c

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 21:56:46 2002 EDT Modified files: /php4/main streams.c Log: MFB: fpos_t -> off_t Index: php4/main/streams.c diff -u php4/main/streams.c:1.137 php4/main/streams.c:1.138 --- php4/main/streams.c:1.137 Sun Dec 22 13:05:36 2002 +++ php4/main

[PHP-CVS] cvs: php4(PHP_4_3) /main streams.c

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 21:55:29 2002 EDT Modified files: (Branch: PHP_4_3) /php4/main streams.c Log: fpos_t should have been off_t. Noticed by Philip Olson. Index: php4/main/streams.c diff -u php4/main/streams.c:1.125.2.22 php4/main/streams.c:1.125.2.23 --- php

Re: [PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
Derick Rethans <[EMAIL PROTECTED]> wrote: > On Sun, 22 Dec 2002, Moriyoshi Koizumi wrote: > > > moriyoshi Sun Dec 22 14:51:49 2002 EDT > > > > Modified files: > > /php4/ext/ncurses ncurses_functions.c > > Log: > > Removed "%s" from format strings > > And

Re: [PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-22 Thread Derick Rethans
On Sun, 22 Dec 2002, Moriyoshi Koizumi wrote: > moriyoshi Sun Dec 22 14:51:49 2002 EDT > > Modified files: > /php4/ext/ncurses ncurses_functions.c > Log: > Removed "%s" from format strings And this is exactly why no patches should be done so far in the releas

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Derick Rethans
On Mon, 23 Dec 2002, Moriyoshi Koizumi wrote: > Andrei Zmievski <[EMAIL PROTECTED]> wrote: > > > Yes. Moriyoshi, please, revert your patches. Ilia is working on a more > > general one, which I will take a look at soon. > > Ilia's already committed :) > BTW it appears rather difficult to avoid su

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Ilia Alshanetsky
iliaa Sun Dec 22 15:58:27 2002 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ncurses ncurses_functions.c Log: MFH Index: php4/ext/ncurses/ncurses_functions.c diff -u php4/ext/ncurses/ncurses_functions.c:1.26.2.3 php4/ext/ncurses/ncurses_functions.c:1.26

Re: [PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-22 Thread Andrei Zmievski
Looks safe to me. On Sun, 22 Dec 2002, Ilia Alshanetsky wrote: > iliaa Sun Dec 22 15:16:37 2002 EDT > > Modified files: > /php4/ext/ncurses ncurses_functions.c > Log: > Fixed various memory leaks. > > # Should this be MFHed? > > > Index: php4/ext/ncurse

[PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-22 Thread Ilia Alshanetsky
iliaa Sun Dec 22 15:16:37 2002 EDT Modified files: /php4/ext/ncurses ncurses_functions.c Log: Fixed various memory leaks. # Should this be MFHed? Index: php4/ext/ncurses/ncurses_functions.c diff -u php4/ext/ncurses/ncurses_functions.c:1.31 php4/ext/

[PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:51:49 2002 EDT Modified files: /php4/ext/ncurses ncurses_functions.c Log: Removed "%s" from format strings Index: php4/ext/ncurses/ncurses_functions.c diff -u php4/ext/ncurses/ncurses_functions.c:1.30 php4/ext/ncurses/ncurs

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
Andrei Zmievski <[EMAIL PROTECTED]> wrote: > Yes. Moriyoshi, please, revert your patches. Ilia is working on a more > general one, which I will take a look at soon. Ilia's already committed :) BTW it appears rather difficult to avoid such conflicts, like working on the same patch. Moriyoshi >

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h

2002-12-22 Thread Ilia Alshanetsky
iliaa Sun Dec 22 14:45:21 2002 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h Log: MFH (fix for bug #21146). # Approved by Andrei Index: php4/ext/ncurses/ncurses.c diff -u php4/ext/ncurses/ncurses.c

[PHP-CVS] cvs: php4 /ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h

2002-12-22 Thread Ilia Alshanetsky
iliaa Sun Dec 22 14:44:02 2002 EDT Modified files: /php4/ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h Log: Fixed bug #21146. Index: php4/ext/ncurses/ncurses.c diff -u php4/ext/ncurses/ncurses.c:1.21 php4/ext/ncurses/ncurses.c:1.22 --- php4/ext/

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Wez Furlong
I defer to Andrei :) --Wez. On Sun, 22 Dec 2002, Andrei Zmievski wrote: > Yes. Moriyoshi, please, revert your patches. Ilia is working on a more > general one, which I will take a look at soon. > > On Sun, 22 Dec 2002, Wez Furlong wrote: > > But only critical bug fixes should be made to the bran

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Wez Furlong
Nope; ilia's patch already takes it into account - let's save him some work, because ncurses has soo many functions :) --Wez. On Mon, 23 Dec 2002, Moriyoshi Koizumi wrote: > Wez Furlong <[EMAIL PROTECTED]> wrote: > > > But only critical bug fixes should be made to the branch this late in > > the

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Andrei Zmievski
Yes. Moriyoshi, please, revert your patches. Ilia is working on a more general one, which I will take a look at soon. On Sun, 22 Dec 2002, Wez Furlong wrote: > But only critical bug fixes should be made to the branch this late in > the release process. > > We already bashed Marcus about this earl

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
Wez Furlong <[EMAIL PROTECTED]> wrote: > But only critical bug fixes should be made to the branch this late in > the release process. > > We already bashed Marcus about this earlier in the process. Then should I revert it for safety? Moriyoshi > --Wez. > > On Mon, 23 Dec 2002, Moriyoshi Koizu

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Wez Furlong
But only critical bug fixes should be made to the branch this late in the release process. We already bashed Marcus about this earlier in the process. --Wez. On Mon, 23 Dec 2002, Moriyoshi Koizumi wrote: > Derick Rethans <[EMAIL PROTECTED]> wrote: > > > On Sun, 22 Dec 2002, Moriyoshi Koizumi wr

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
Derick Rethans <[EMAIL PROTECTED]> wrote: > On Sun, 22 Dec 2002, Moriyoshi Koizumi wrote: > > > moriyoshi Sun Dec 22 14:16:42 2002 EDT > > > > Modified files: (Branch: PHP_4_3) > > /php4/ext/ncurses ncurses_functions.c > > Log: > > MFH: php_error => php_er

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Derick Rethans
On Sun, 22 Dec 2002, Moriyoshi Koizumi wrote: > moriyoshi Sun Dec 22 14:16:42 2002 EDT > > Modified files: (Branch: PHP_4_3) > /php4/ext/ncurses ncurses_functions.c > Log: > MFH: php_error => php_error_docref This is not critical; you should commit to the bran

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:16:42 2002 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ncurses ncurses_functions.c Log: MFH: php_error => php_error_docref Index: php4/ext/ncurses/ncurses_functions.c diff -u php4/ext/ncurses/ncurses_functions.c:1.26.2.1 ph

[PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:16:09 2002 EDT Modified files: /php4/ext/ncurses ncurses_functions.c Log: php_error => php_error_docref Index: php4/ext/ncurses/ncurses_functions.c diff -u php4/ext/ncurses/ncurses_functions.c:1.28 php4/ext/ncurses/ncurses_fun

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses.c

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:06:30 2002 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ncurses ncurses.c Log: MFH: WS fix Index: php4/ext/ncurses/ncurses.c diff -u php4/ext/ncurses/ncurses.c:1.18.2.1 php4/ext/ncurses/ncurses.c:1.18.2.2 --- php4/ext/ncurses

[PHP-CVS] cvs: php4 /ext/ncurses ncurses.c

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:05:07 2002 EDT Modified files: /php4/ext/ncurses ncurses.c Log: WS fix Index: php4/ext/ncurses/ncurses.c diff -u php4/ext/ncurses/ncurses.c:1.20 php4/ext/ncurses/ncurses.c:1.21 --- php4/ext/ncurses/ncurses.c:1.20 Sun Dec 22

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:03:15 2002 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h Log: MFH Index: php4/ext/ncurses/ncurses.c diff -u php4/ext/ncurses/ncurses.c:1.18 php4/ext/ncurses/ncurses.c:1.18.2.

[PHP-CVS] cvs: php4 /ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h

2002-12-22 Thread Moriyoshi Koizumi
moriyoshi Sun Dec 22 14:01:44 2002 EDT Modified files: /php4/ext/ncurses ncurses.c ncurses_functions.c php_ncurses.h Log: Fixed bug #21144 Index: php4/ext/ncurses/ncurses.c diff -u php4/ext/ncurses/ncurses.c:1.19 php4/ext/ncurses/ncurses.c:1.20 --- ph

[PHP-CVS] cvs: php4(PHP_4_3) /ext/standard/tests/file bug21131.phpt userstreams.phpt /main streams.c

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 13:21:55 2002 EDT Added files: (Branch: PHP_4_3) /php4/ext/standard/tests/file bug21131.phpt Modified files: /php4/ext/standard/tests/file userstreams.phpt /php4/main streams.c Log: MFH fix for Bug #21131

[PHP-CVS] cvs: php4 /ext/standard/tests/file bug21131.phpt

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 13:06:29 2002 EDT Added files: /php4/ext/standard/tests/file bug21131.phpt Log: Forgot to include this in my previous commit for #21131 fix. Index: php4/ext/standard/tests/file/bug21131.phpt +++ php4/ext/standard/tests/file/bug211

[PHP-CVS] cvs: php4 /ext/standard/tests/file userstreams.phpt /main streams.c

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 13:05:36 2002 EDT Modified files: /php4/ext/standard/tests/file userstreams.phpt /php4/main streams.c Log: Fix for Bug #21131: fopen($file, 'a+') would incorrectly assume that the stream position was at offset 0. This corrects tha

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2002-12-22 Thread Andrey Hristov
Will be short comment above the loop helpful ? Andrey - Original Message - From: "Sascha Schumann" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, December 22, 2002 6:34 PM Subject: [PHP-CVS] cvs: php4 /ext/exif exif.c > sas Sun Dec 22 11:34:13 2002 EDT > > Modified files:

[PHP-CVS] cvs: php4 /ext/exif exif.c

2002-12-22 Thread Sascha Schumann
sas Sun Dec 22 11:34:13 2002 EDT Modified files: /php4/ext/exif exif.c Log: (char *) vptr += expr; is refused by the IRIX compiler, so we use vptr = (char *) vptr + expr; instead. Index: php4/ext/exif/exif.c diff -u php4/ext/exif/exif.c:1.135 php4/

[PHP-CVS] cvs: php4 /ext/exif exif.c

2002-12-22 Thread Sascha Schumann
sas Sun Dec 22 11:03:28 2002 EDT Modified files: /php4/ext/exif exif.c Log: 'index' is a function name in the C library, do not use it as variable name. also, cast the 'void *' correctly to a 'char *' for manipulation instead of an 'int'. Inde

[PHP-CVS] cvs: php4(PHP_4_3) /main network.c

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 08:58:41 2002 EDT Modified files: (Branch: PHP_4_3) /php4/main network.c Log: MFH: A Simple fix for Bug #12360 (fsockopen timeout doesn't work). Analysis: On systems with HAVE_GETADDRINFO and IPV6 support, php_hostconnect would atte

[PHP-CVS] cvs: php4 /main network.c

2002-12-22 Thread Wez Furlong
wez Sun Dec 22 08:55:46 2002 EDT Modified files: /php4/main network.c Log: A Simple fix for Bug #12360 (fsockopen timeout doesn't work). Analysis: On systems with HAVE_GETADDRINFO and IPV6 support, php_hostconnect would attempt to connect to each poss

[PHP-CVS] cvs: php4 / run-tests.php

2002-12-22 Thread Melvyn Sopacua
msopacuaSun Dec 22 07:48:49 2002 EDT Modified files: /php4 run-tests.php Log: Delete some security related env variables Index: php4/run-tests.php diff -u php4/run-tests.php:1.135 php4/run-tests.php:1.136 --- php4/run-tests.php:1.135Thu Dec