On Sun, 14 Aug 2005, Andrei Zmievski wrote:
> Why not use what ICU gives us?
A reason might be that we might have implemented more modifiers, or some
slightly different. I think it's a good idea to use our own too.
Derick
> On Aug 14, 2005, at 10:14 AM, Marcus Boerger wrote:
>
> > helly
If we decide to break things, then I would completely remove it. I
was thinking about BC for non-Unicode mode.
-Andrei
On Aug 14, 2005, at 4:58 AM, Antony Dovgal wrote:
Andrei Zmievski wrote:
Does this take into account the fact that default_charset is
considered deprecated when unicode
When unicode_semantics=on, all identifiers are Unicode. You can rely
on that and test for it with UG(unicode) flag.
-Andrei
On Aug 14, 2005, at 12:00 PM, Antony Dovgal wrote:
This is what I get after your patch:
object(test)#1 (3) {
@["private_prop:u"[EMAIL PROTECTED]@":private"]=>
strin
On Aug 14, 2005, at 8:08 AM, Marcus Boerger wrote:
hellySun Aug 14 11:08:39 2005 EDT
Modified files:
/php-src/ext/standardvar.c
Log:
- Show classname very needed
- No 3rd " which doesn't help parsing
# Does the class name need to be printed as u"" ?
How would you sug
Why not use what ICU gives us?
http://icu.sourceforge.net/apiref/icu4c/ustdio_8h.html#a36
-Andrei
On Aug 14, 2005, at 10:14 AM, Marcus Boerger wrote:
hellySun Aug 14 13:14:43 2005 EDT
Modified files:
/php-src/ext/standardphp_smart_str.h
/php-src/mainspprintf.c sppr
On Aug 14, 2005, at 6:09 AM, Johannes Schlüter wrote:
+if (UG(unicode)) {
+int32_t tmp_len, len;
+UErrorCode status = U_ZERO_ERROR;
+
+len = u_strlen((UChar *)retval);
+zend_convert_from_unicode(ZEND_U_CONVERTER(UG
(output_encoding_conv)),
helly Sun Aug 14 17:26:02 2005 EDT
Modified files:
/php-src/ext/standard var.c
Log:
- Simplify and make work in all modes
http://cvs.php.net/diff.php/php-src/ext/standard/var.c?r1=1.207&r2=1.208&ty=u
Index: php-src/ext/standard/var.c
diff -u php-src/ext/
helly Sun Aug 14 17:04:55 2005 EDT
Modified files:
/php-src/main spprintf.c
Log:
- Need to terminate [v]uspprintf() with two \0
http://cvs.php.net/diff.php/php-src/main/spprintf.c?r1=1.29&r2=1.30&ty=u
Index: php-src/main/spprintf.c
diff -u php-src/main/s
iliaa Sun Aug 14 16:24:35 2005 EDT
Modified files:
/php-src/ext/wddx wddx.c
Log:
Fixed build.
http://cvs.php.net/diff.php/php-src/ext/wddx/wddx.c?r1=1.121&r2=1.122&ty=u
Index: php-src/ext/wddx/wddx.c
diff -u php-src/ext/wddx/wddx.c:1.121 php-src/ext/wddx/
helly Sun Aug 14 16:12:52 2005 EDT
Modified files:
/php-src/main spprintf.c
Log:
- Where did my backslash vanish?
http://cvs.php.net/diff.php/php-src/main/spprintf.c?r1=1.28&r2=1.29&ty=u
Index: php-src/main/spprintf.c
diff -u php-src/main/spprintf.c:1.28
helly Sun Aug 14 16:11:09 2005 EDT
Modified files:
/php-src/main spprintf.c
Log:
- Handle different cases of the actual strings correctly
http://cvs.php.net/diff.php/php-src/main/spprintf.c?r1=1.27&r2=1.28&ty=u
Index: php-src/main/spprintf.c
diff -u php-
This is what I get after your patch:
object(test)#1 (3) {
@["private_prop:u"[EMAIL PROTECTED]@":private"]=>
string(7) "private"
@["public_prop"]=>
string(6) "public"
@["protected_prop:protected"]=>
string(9) "protected"
}
The garbage instead of the classname is shown because we can't deter
helly Sun Aug 14 13:14:43 2005 EDT
Modified files:
/php-src/ext/standard php_smart_str.h
/php-src/main spprintf.c spprintf.h
Log:
- Initial support of easy way to generate unicode strings: [v]uspprinf()
# Same semantics as [v]spprintf, only it
Hello Andrei,
shouldn't we just drop that u"..." here and simply use %r internally?
Sunday, August 14, 2005, 5:18:46 PM, you wrote:
> helly Sun Aug 14 11:18:46 2005 EDT
> Modified files:
> /php-src/ext/standard var.c
> Log:
> - If prop_name is printed
helly Sun Aug 14 11:18:46 2005 EDT
Modified files:
/php-src/ext/standard var.c
Log:
- If prop_name is printed as unicode then class_name needs to be treated
in the exact same manner
http://cvs.php.net/diff.php/php-src/ext/standard/var.c?r1=1.206&
helly Sun Aug 14 11:08:39 2005 EDT
Modified files:
/php-src/ext/standard var.c
Log:
- Show classname very needed
- No 3rd " which doesn't help parsing
# Does the class name need to be printed as u"" ?
http://cvs.php.net/diff.php/php-src/ext/standa
wez Sun Aug 14 09:48:30 2005 EDT
Modified files:
/php-src/main/streams streams.c
Log:
tidy up implicit_mode handling; spotted by Nuno
There's probably a much more efficient way to do this than the current strchr
stuff.
http://cvs.php.net/diff.
johannesSun Aug 14 09:09:37 2005 EDT
Modified files:
/php-src/sapi/cli php_cli_readline.c
Log:
- Fix tab-completion in unicode mode and for constants.
http://cvs.php.net/diff.php/php-src/sapi/cli/php_cli_readline.c?r1=1.3&r2=1.4&ty=u
Index: php-src/
johannesSun Aug 14 09:07:15 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/sapi/cli php_cli_readline.c
Log:
- Fix tab-completion for constants.
http://cvs.php.net/diff.php/php-src/sapi/cli/php_cli_readline.c?r1=1.3&r2=1.3.2.1&ty=u
Index: php-src
Andrei Zmievski wrote:
Does this take into account the fact that default_charset is
considered deprecated when unicode_semantics=on?
Deprecated or completely removed?
If it becomes useless with Unicode support, then I'd remove it at all
instead of marking it as deprecated.
--
Wbr,
Antony Do
20 matches
Mail list logo
