On Wed, 17 Aug 2005, Dmitry Stogov wrote:
> May be nice to have, however ASCII to unicode conversion is not usual case.
> Usualy we have non ASCII but some encoding (UG(runrime_encoding)).
But we can have a macro for that too, isn't it? :)
Derick
--
Derick Rethans
http://derickrethans.nl | http
May be it should return IS_BINARY only in unicode mode, and IS_STRING in
non-unicode (as before)?
Dmitry.
> -Original Message-
> From: Andrei Zmievski [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, August 16, 2005 11:45 PM
> To: php-cvs@lists.php.net
> Subject: [PHP-CVS] cvs: php-src /ext/st
Oh, I didn't realize this was literally meant to be ASCII. In such case,
there probably aren't going to be many places
At 09:36 AM 8/17/2005 +0400, Dmitry Stogov wrote:
May be nice to have, however ASCII to unicode conversion is not usual case.
Usualy we have non ASCII but some encoding (UG(ru
May be nice to have, however ASCII to unicode conversion is not usual case.
Usualy we have non ASCII but some encoding (UG(runrime_encoding)).
Dmitry.
> -Original Message-
> From: Andi Gutmans [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, August 17, 2005 4:54 AM
> To: Dmitry Stogov; php-c
Shouldn't we have a macro that does this?
I see lots of places that require the same code.
- RETVAL_STRING(md5str, 1);
+ if (UG(unicode)) {
+ UChar *u_temp = zend_ascii_to_unicode(md5str, 33
ZEND_FILE_LINE_CC);
+ RETVAL_UNIC
helly Tue Aug 16 16:22:38 2005 EDT
Modified files:
/php-src/ext/standard string.c
Log:
- TSRM Fix
http://cvs.php.net/diff.php/php-src/ext/standard/string.c?r1=1.456&r2=1.457&ty=u
Index: php-src/ext/standard/string.c
diff -u php-src/ext/standard/string.c:
helly Tue Aug 16 16:15:22 2005 EDT
Modified files:
/php-src/ext/soap php_encoding.c
Log:
- TSRM Fix
http://cvs.php.net/diff.php/php-src/ext/soap/php_encoding.c?r1=1.103&r2=1.104&ty=u
Index: php-src/ext/soap/php_encoding.c
diff -u php-src/ext/soap/php_encodin
andrei Tue Aug 16 15:45:01 2005 EDT
Modified files:
/php-src/ext/standard md5.c
Log:
md5() and md5_file() should return binary strings when raw_output is
set.
http://cvs.php.net/diff.php/php-src/ext/standard/md5.c?r1=1.40&r2=1.41&ty=u
Index: php-src/
andrei Tue Aug 16 15:43:24 2005 EDT
Modified files:
/php-src/ext/pdopdo_stmt.c
Log:
And here
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_stmt.c?r1=1.121&r2=1.122&ty=u
Index: php-src/ext/pdo/pdo_stmt.c
diff -u php-src/ext/pdo/pdo_stmt.c:1.121 php-src/
never mind. i thought you were changing a PHP function :)
At 06:05 AM 8/16/2005 +, Rolland Santimano wrote:
rolland Tue Aug 16 02:05:00 2005 EDT
Modified files:
/php-src/ext/simplexml simplexml.c
/php-src/ext/standard http_fopen_wrapper.c
Log:
Updated calls
In-Reply-To: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
why do we need this?
shouldn't the return type be the same as the string...?
At 06:02 AM 8/16/2005 +, Rolland Santimano wrote:
>rolland Tue Aug 16 02:02:57 2005 EDT
>
> Mod
andrei Tue Aug 16 14:22:22 2005 EDT
Modified files:
/php-src/ext/pdopdo_dbh.c
Log:
And here.
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_dbh.c?r1=1.86&r2=1.87&ty=u
Index: php-src/ext/pdo/pdo_dbh.c
diff -u php-src/ext/pdo/pdo_dbh.c:1.86 php-src/ext/pd
helly Tue Aug 16 14:11:35 2005 EDT
Modified files: (Branch: PHP_5_0)
/php-src/main main.c
Log:
- MFH: Prevent E_STRICT from ending up as exception
http://cvs.php.net/diff.php/php-src/main/main.c?r1=1.604.2.21&r2=1.604.2.22&ty=u
Index: php-src/main/main.c
helly Tue Aug 16 14:10:35 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/main main.c
Log:
- Prevent E_STRICT from ending up as exception
http://cvs.php.net/diff.php/php-src/main/main.c?r1=1.640&r2=1.640.2.1&ty=u
Index: php-src/main/main.c
diff -u php
helly Tue Aug 16 14:09:28 2005 EDT
Modified files:
/php-src/main main.c
Log:
- Prevent E_STRICT from ending up as exception
http://cvs.php.net/diff.php/php-src/main/main.c?r1=1.643&r2=1.644&ty=u
Index: php-src/main/main.c
diff -u php-src/main/main.c:1.64
derick Tue Aug 16 14:02:41 2005 EDT
Modified files:
/php-src/ext/standard php_smart_str.h
/php-src/main spprintf.c
Log:
- Fixed a couple of bugs in the new smart_str macros, and allow them to
allocate two extra bytes (so that we can pad them w
On Aug 16, 2005, at 5:04 AM, Rolland Santimano wrote:
+ if (Z_TYPE_P(delim) != IS_UNICODE && Z_TYPE_P(delim) != IS_BINARY) {
+ convert_to_string_ex(&delim);
+ }
+ Z_TYPE_P(retval) = return_type = Z_TYPE_P(delim); /* ... to start
off */
This is not correct. If the de
tony2001Tue Aug 16 12:58:00 2005 EDT
Modified files:
/php-src/ext/standard string.c
Log:
nuke unused vars
http://cvs.php.net/diff.php/php-src/ext/standard/string.c?r1=1.455&r2=1.456&ty=u
Index: php-src/ext/standard/string.c
diff -u php-src/ext/s
dmitry Tue Aug 16 12:29:16 2005 EDT
Modified files:
/php-src/ext/pdopdo_dbh.c pdo_stmt.c
/php-src/ext/pdo/tests pdo_016.phpt
Log:
Unicode support
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_dbh.c?r1=1.85&r2=1.86&ty=u
Index: php-src/ext/pdo/
dmitry Tue Aug 16 11:09:53 2005 EDT
Modified files:
/php-src/ext/dom/tests bug28817.phpt
/php-src/ext/simplexml simplexml.c
/php-src/ext/simplexml/tests008.phpt 009.phpt 015.phpt 022.phpt
/php-src/ext/splspl_sxe.c
/php-src/ext/
iliaa Tue Aug 16 10:20:42 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/ext/standard url.c
/php-src/ext/standard/tests/strings url_t.phpt
Log:
MFH: Fixed bug #34148 (+,- and . not supported as parts of scheme).
http://cvs.php.net/diff.php/php-s
iliaa Tue Aug 16 10:15:44 2005 EDT
Modified files: (Branch: PHP_5_0)
/php-src/ext/standard url.c
/php-src/ext/standard/tests/strings url_t.phpt
Log:
MFH: Fixed bug #34148 (+,- and . not supported as parts of scheme).
http://cvs.php.net/diff.php/ph
iliaa Tue Aug 16 10:12:15 2005 EDT
Modified files: (Branch: PHP_4_4)
/php-src/ext/standard url.c
/php-src/ext/standard/tests/strings url_t.phpt
/php-srcNEWS
Log:
MFH: Fixed bug #34148 (+,- and . not supported as parts of scheme).
http://c
iliaa Tue Aug 16 10:10:15 2005 EDT
Modified files:
/php-src/ext/standard url.c
/php-src/ext/standard/tests/strings url_t.phpt
/php-srcNEWS
Log:
Fixed bug #34148 (+,- and . not supported as parts of scheme).
http://cvs.php.net/diff.php/ph
rolland Tue Aug 16 08:04:14 2005 EDT
Modified files:
/php-src/ext/standard string.c
Log:
Unicode capable impl of implode()
http://cvs.php.net/diff.php/php-src/ext/standard/string.c?r1=1.454&r2=1.455&ty=u
Index: php-src/ext/standard/string.c
diff -u php-
zeevTue Aug 16 08:01:42 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-srcNEWS configure.in
/php-src/main php_version.h
Log:
Go back to dev
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.2027.2.16&r2=1.2027.2.17&ty=u
Index: php-src/NEWS
diff
edink Tue Aug 16 07:35:48 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/pear go-pear-list.php
Log:
Rebundle XML_RPC in the correct version for the Windows distro.
http://cvs.php.net/diff.php/php-src/pear/go-pear-list.php?r1=1.15.2.1&r2=1.15.2.2&ty=u
zeevTue Aug 16 06:59:57 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-srcNEWS configure.in
/php-src/main php_version.h
Log:
Roll RC1
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.2027.2.15&r2=1.2027.2.16&ty=u
Index: php-src/NEWS
diff -u ph
dmitry Tue Aug 16 06:18:43 2005 EDT
Modified files:
/php-src/ext/standard md5.c
/php-src/ext/standard/tests/strings explode.phpt strcspn.phpt
strspn.phpt strstr.phpt
Log:
Unicode support
http://cvs.php.net/
edink Tue Aug 16 05:55:48 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/ext/pgsql pgsql.c
Log:
Use free() instead of PQfreemem() to maintain compabitibility with older
PostgreSQL client libraries (bug #33813).
http://cvs.php.net/diff.php/php-src/ext
dmitry Tue Aug 16 05:25:05 2005 EDT
Modified files:
/php-src/ext/standard var.c
/php-src/ext/standard/tests/array bug25708.phpt bug26458.phpt
Log:
Unicode support
http://cvs.php.net/diff.php/php-src/ext/standard/var.c?r1=1.208&r2=1.209&ty=u
Inde
dmitry Tue Aug 16 05:11:00 2005 EDT
Modified files:
/php-src/ext/standard image.c
/php-src/ext/standard/tests/image bug13213.phpt getimagesize.phpt
getimagesize_246x247.phpt
a) Why not call it 'return_type' ??
b) Why don't you put it as last parameter like we have used to do?
c) Read CODING_STANDARDS before you commit anything else..
(we don't use extra spaces everywhere)
--Jani
On Tue, 16 Aug 2005, Rolland Santimano wrote:
rolland
On Tue, 16 Aug 2005, Dmitry Stogov wrote:
> We discussed this with Andrei long time ago.
> I cannot remember did we it internally or in unicode list.
It was not on the unicode list. It's nice to talk to the authors of a
specific set of code first before pushing large changes into it. (that's
wh
34 matches
Mail list logo
