Re: [PHP-CVS] svn: /php/php-src/trunk/ Zend/zend.c Zend/zend_compile.c Zend/zend_globals.h Zend/zend_language_scanner.c Zend/zend_language_scanner.h Zend/zend_language_scanner.l Zend/zend_language_sca

ext/exif doesn't compile after this patch because of this: ext/exif/exif.o: In function `OnUpdateEncode': /local/qa/HEAD_non-ZTS/ext/exif/exif.c:169: undefined reference to `zend_multibyte_check_encoding_list' ext/exif/exif.o: In function `OnUpdateDecode':

Re: [PHP-CVS] svn: /php/php-src/trunk/ Zend/zend.c Zend/zend_compile.c Zend/zend_globals.h Zend/zend_language_scanner.c Zend/zend_language_scanner.h Zend/zend_language_scanner.l Zend/zend_language_sca

To reproduce, use the following configure line: ./configure --enable-exif On 12/21/2010 12:34 PM, Antony Dovgal wrote: ext/exif doesn't compile after this patch because of this: ext/exif/exif.o: In function `OnUpdateEncode': /local/qa/HEAD_non-ZTS/ext/exif/exif.c:169: undefined reference to

Re: [PHP-CVS] svn: /php/php-src/trunk/ Zend/zend.c Zend/zend_compile.c Zend/zend_globals.h Zend/zend_language_scanner.c Zend/zend_language_scanner.h Zend/zend_language_scanner.l Zend/zend_language_sca

confirmed on windows too: http://rmtools.php.net/snaps/trunk-ts-windows-vc9-x86/logs/r306535/compile.txt Cheers, On Tue, Dec 21, 2010 at 2:39 PM, Antony Dovgal t...@daylessday.org wrote: To reproduce, use the following configure line: ./configure --enable-exif On 12/21/2010 12:34 PM, Antony

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

cataphract Tue, 21 Dec 2010 17:29:14 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306542 Log: - Fixed bug #53588 (SplMinHeap bad sorting with custom compare function). Bug: http://bugs.php.net/53588 (Assigned) SplMinHeap bad insert sort

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definition and so the bug was bogus. Chris On 12/21/2010 09:29 AM, Gustavo André dos Santos Lopes wrote: cataphract

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

On 12/21/2010 10:47 AM, Gustavo Lopes wrote: On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones christopher.jo...@oracle.com wrote: Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones christopher.jo...@oracle.com wrote: Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definition and so the bug

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

On Tue, 21 Dec 2010 18:52:07 -, Christopher Jones christopher.jo...@oracle.com wrote: On 12/21/2010 10:47 AM, Gustavo Lopes wrote: On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones christopher.jo...@oracle.com wrote: Hi Gustavo, Can you review the definition of

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/gmp/ gmp.c

iliaaTue, 21 Dec 2010 22:05:15 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306561 Log: removed unused var Changed paths: U php/php-src/branches/PHP_5_3/ext/gmp/gmp.c Modified: php/php-src/branches/PHP_5_3/ext/gmp/gmp.c