pajoye Tue, 15 Feb 2011 14:02:26 +
Revision: http://svn.php.net/viewvc?view=revision&revision=308362
Log:
- fix the fix (Dmitry) and ensure that it builds everywhere, can someone test
on solaris&co pls?
Changed paths:
U php/php-src/branches/PHP_5_3/ex
and btw, as I said earlier, I would prefer to use the largest possible
value, which is likely to be 64K and not maxint. If only one could
point us to the specs for this exact value...
On Tue, Feb 15, 2011 at 2:27 PM, Pierre Joye wrote:
> why don't you fix it the way you want instead of arguing en
why don't you fix it the way you want instead of arguing endlessly? I
gave all info to explain the reasoning behind that code, if it is
wrong, and that's totally possible, then fix it and let move on :)
Cheers,
On Tue, Feb 15, 2011 at 2:21 PM, Dmitry Stogov wrote:
> On 02/15/2011 03:31 PM, Pierr
On 02/15/2011 03:31 PM, Pierre Joye wrote:
On Tue, Feb 15, 2011 at 12:54 PM, Dmitry Stogov wrote:
I don't know all the logic but it looks very strange
2147483648 == 0x8000 != 0x7fff == 2147483647
so byte_count_signed may be 0x8000 == -1
negative value are checked before. Btw, b
On Tue, Feb 15, 2011 at 12:54 PM, Dmitry Stogov wrote:
> I don't know all the logic but it looks very strange
>
> 2147483648 == 0x8000 != 0x7fff == 2147483647
>
> so byte_count_signed may be 0x8000 == -1
negative value are checked before. Btw, byte_count_signed is a 64bit
signed int
On 02/15/2011 12:31 PM, Pierre Joye wrote:
On Tue, Feb 15, 2011 at 10:17 AM, Dmitry Stogov wrote:
Hi Pierre,
The check for (byte_count_signed> 2147483648) looks ugly and it's even
wrong.
It is not ugly nor wrong. See my post in when I proposed the patch. It
should actually be something much
On Tue, Feb 15, 2011 at 10:17 AM, Dmitry Stogov wrote:
> Hi Pierre,
>
> The check for (byte_count_signed > 2147483648) looks ugly and it's even
> wrong.
It is not ugly nor wrong. See my post in when I proposed the patch. It
should actually be something much lower but I did not find a reliable
ref
Hi Pierre,
The check for (byte_count_signed > 2147483648) looks ugly and it's even
wrong.
It should be changed to something like (byte_count_signed > INT32_MAX)
where INT32_MAX = 0x7fff (or 2147483647).
Thanks. Dmitry.
On 02/14/2011 12:08 PM, Pierre Joye wrote:
(byte_count_signed> 21
pajoye Tue, 15 Feb 2011 09:07:34 +
Revision: http://svn.php.net/viewvc?view=revision&revision=308354
Log:
- unused var
Changed paths:
U php/php-src/branches/PHP_5_3/ext/intl/resourcebundle/resourcebundle.c
U php/php-src/trunk/ext/intl/resourcebun
pajoye Tue, 15 Feb 2011 08:48:24 +
Revision: http://svn.php.net/viewvc?view=revision&revision=308353
Log:
- fix intl build with ICU < 4.2, windows part
Changed paths:
U php/php-src/trunk/ext/intl/config.w32
Modified: php/php-src/trunk/ext/intl/config.
pajoye Tue, 15 Feb 2011 08:28:22 +
Revision: http://svn.php.net/viewvc?view=revision&revision=308352
Log:
- fix build with ICU < 4.2, add ICU_VERSION for m4 checks
Changed paths:
U php/php-src/branches/PHP_5_3/acinclude.m4
Modified: php/php-src/branch
pajoye Tue, 15 Feb 2011 08:28:03 +
Revision: http://svn.php.net/viewvc?view=revision&revision=308351
Log:
- fix build with ICU < 4.2, add ICU_VERSION for m4 checks
Changed paths:
U php/php-src/trunk/acinclude.m4
U php/php-src/trunk/ext/intl/confi
12 matches
Mail list logo
