On Tue, Feb 28, 2012 at 10:38 AM, Xinchen Hui wrote:
> On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote:
>> I initially looked at the final fix when I discovered the issue.
>> Follow me out on this. This is the current code as-implemented in
>> r323563:
>>
>> 265 zval *o
On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote:
> I initially looked at the final fix when I discovered the issue.
> Follow me out on this. This is the current code as-implemented in
> r323563:
>
> 265 zval *obj;
> 266 MAKE_STD_ZVAL(obj);
> 267
johannes Mon, 27 Feb 2012 18:41:22 +
Revision: http://svn.php.net/viewvc?view=revision&revision=323600
Log:
Add karma for web/php-distributions.git
Changed paths:
U SVNROOT/global_avail
Modified: SVNROOT/global_avail
I initially looked at the final fix when I discovered the issue.
Follow me out on this. This is the current code as-implemented in
r323563:
265 zval *obj;
266 MAKE_STD_ZVAL(obj);
267 if (Z_OBJ_HANDLER_P(*arg, cast_object)(*arg, obj, type
Sent from my iPad
在 2012-2-28，0:10，Anthony Ferrara 写道：
> Out of curiosity, why are you changing it to copy the object for the
> result of the cast operation? cast_object should init the result
> zval, so why go through the step of copying the starting object to
plz look at the final fix： r32356
Out of curiosity, why are you changing it to copy the object for the
result of the cast operation? cast_object should init the result
zval, so why go through the step of copying the starting object to it?
Wouldn't it be easier just to do:
if (Z_OBJ_HANDLER_PP(arg, cast_object)) {
On Mon, February 27, 2012 2:31 am, Laruence wrote:
> On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov
> wrote:
>> Hi Laruence,
>>
>> The attached patch looks wired. The patch on top of it (r323563)
>> makes it
>> better. However, in my opinion it fixes a common problem just in a
>> single
>> place.
On Mon, Feb 27, 2012 at 3:08 PM, Hannes Magnusson <
hannes.magnus...@gmail.com> wrote:
> On Mon, Feb 27, 2012 at 15:02, Ferenc Kovacs wrote:
> >
> >
> > On Mon, Feb 27, 2012 at 2:47 PM, Hannes Magnusson
> > wrote:
> >>
> >> On Sun, Feb 26, 2012 at 17:54, Pierre Joye wrote:
> >> > pajoye
no idea but did not find a git entry for peclweb but this one.
I will try again later, we continue to use the other master in the meantime.
On Mon, Feb 27, 2012 at 3:08 PM, Hannes Magnusson
wrote:
> On Mon, Feb 27, 2012 at 15:02, Ferenc Kovacs wrote:
>>
>>
>> On Mon, Feb 27, 2012 at 2:47 PM, Ha
On Mon, Feb 27, 2012 at 15:02, Ferenc Kovacs wrote:
>
>
> On Mon, Feb 27, 2012 at 2:47 PM, Hannes Magnusson
> wrote:
>>
>> On Sun, Feb 26, 2012 at 17:54, Pierre Joye wrote:
>> > pajoye Sun, 26 Feb 2012 16:54:39 +
>> >
>> > Revision: http://svn.php.net/viewvc
On Mon, Feb 27, 2012 at 2:47 PM, Hannes Magnusson <
hannes.magnus...@gmail.com> wrote:
> On Sun, Feb 26, 2012 at 17:54, Pierre Joye wrote:
> > pajoye Sun, 26 Feb 2012 16:54:39 +
> >
> > Revision: http://svn.php.net/viewvc?view=revision&revision=323564
> >
> >
On Sun, Feb 26, 2012 at 17:54, Pierre Joye wrote:
> pajoye Sun, 26 Feb 2012 16:54:39 +
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=323564
>
> Log:
> Bruno acces to peclweb
>
> Changed paths:
> U SVNROOT/global_avail
>
> Modified: SVNROO
rasmus Mon, 27 Feb 2012 12:16:39 +
Revision: http://svn.php.net/viewvc?view=revision&revision=323577
Log:
Fix bug 61193
Bug: https://bugs.php.net/61193 (Open) PHP_EOL definition for Mac OS X is wrong
and unused
Changed paths:
U php/php-src/bran
bjoriMon, 27 Feb 2012 11:30:03 +
Revision: http://svn.php.net/viewvc?view=revision&revision=323576
Log:
Give Levi Morrison karma for phpweb
Changed paths:
U SVNROOT/global_avail
Modified: SVNROOT/global_avail
On Mon, Feb 27, 2012 at 11:17 AM, Derick Rethans wrote:
> You can't break extension APIs between 5.4.0 and 5.4.1 either, API
> changes can only into trunk.
And ABI neither.
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
--
PHP CVS Mailing List (http://www.php.net/)
On Mon, 27 Feb 2012, Laruence wrote:
> On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote:
> > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote:
> >>
> >> The attached patch looks wired. The patch on top of it (r323563) makes it
> >> better. However, in my opinion it fixes a common problem just
On 02/27/2012 12:37 PM, Laruence wrote:
On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote:
On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote:
Hi Laruence,
The attached patch looks wired. The patch on top of it (r323563) makes it
better. However, in my opinion it fixes a common problem just
On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote:
> On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote:
>> Hi Laruence,
>>
>> The attached patch looks wired. The patch on top of it (r323563) makes it
>> better. However, in my opinion it fixes a common problem just in a single
>> place. Each call
On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote:
> Hi Laruence,
>
> The attached patch looks wired. The patch on top of it (r323563) makes it
> better. However, in my opinion it fixes a common problem just in a single
> place. Each call to __toString() that makes "side effects" may cause the
Hi Laruence,
The attached patch looks wired. The patch on top of it (r323563) makes
it better. However, in my opinion it fixes a common problem just in a
single place. Each call to __toString() that makes "side effects" may
cause the similar problem. It would be great to make a "right" fix in
20 matches
Mail list logo
