Re: [PHP-CVS] com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c

2012-04-14 Thread Laruence
On Sun, Apr 15, 2012 at 12:36 PM, Stas Malyshev wrote: > Hi! > >>> I'm not sure this is a good idea - output buffers can include output >>> functions IIRC, but you have already shut down modules. I would be very, >> Stas, they are request shutdown, not module shutdown :) > > Request shutdown IIRC

Re: [PHP-CVS] com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c

2012-04-14 Thread Stas Malyshev
Hi! >> I'm not sure this is a good idea - output buffers can include output >> functions IIRC, but you have already shut down modules. I would be very, > Stas, they are request shutdown, not module shutdown :) Request shutdown IIRC destroys functions and module's per-request data structures, whic

Re: [PHP-CVS] com php-src: Merge branch 'PHP-5.4': main/main.c

2012-04-14 Thread Laruence
On Sun, Apr 15, 2012 at 11:43 AM, Laruence wrote: > On Sun, Apr 15, 2012 at 5:22 AM, Yasuo Ohgaki wrote: >> Hi, >> >> 2012/4/15 Xinchen Hui : >>> Commit:    579d234f5078fc87b0b21a333a5fdfc60e9df124 >>> Author:    Xinchen Hui         Sun, 15 Apr 2012 01:17:56 >>> +0800 >>> Parents:   c62a41860e1

Re: [PHP-CVS] com php-src: Merge branch 'PHP-5.4': main/main.c

2012-04-14 Thread Laruence
On Sun, Apr 15, 2012 at 5:22 AM, Yasuo Ohgaki wrote: > Hi, > > 2012/4/15 Xinchen Hui : >> Commit:    579d234f5078fc87b0b21a333a5fdfc60e9df124 >> Author:    Xinchen Hui         Sun, 15 Apr 2012 01:17:56 >> +0800 >> Parents:   c62a41860e151b3c95ccd05d1ad7d25797219563 >> 3b42f184cdcf512fdc1f944052

Re: [PHP-CVS] com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c

2012-04-14 Thread Laruence
On Sun, Apr 15, 2012 at 6:07 AM, Stas Malyshev wrote: > Hi! > >> Hi: >>    you may want to review this patch. >> >>    I have make sure all tests passed, but still not sure is there any >> side-effect. > > I'm not sure this is a good idea - output buffers can include output > functions IIRC, but y

Re: [PHP-CVS] com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c

2012-04-14 Thread Stas Malyshev
Hi! > Hi: >you may want to review this patch. > >I have make sure all tests passed, but still not sure is there any > side-effect. I'm not sure this is a good idea - output buffers can include output functions IIRC, but you have already shut down modules. I would be very, very careful wi

Re: [PHP-CVS] com php-src: Merge branch 'PHP-5.4': main/main.c

2012-04-14 Thread Yasuo Ohgaki
Hi, 2012/4/15 Xinchen Hui : > Commit:    579d234f5078fc87b0b21a333a5fdfc60e9df124 > Author:    Xinchen Hui         Sun, 15 Apr 2012 01:17:56 > +0800 > Parents:   c62a41860e151b3c95ccd05d1ad7d25797219563 > 3b42f184cdcf512fdc1f944052bfa296f17a035f > Branches:  master > > Link:       > http://git

Re: [PHP-CVS] com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c

2012-04-14 Thread Laruence
Hi: you may want to review this patch. I have make sure all tests passed, but still not sure is there any side-effect. thanks On Sun, Apr 15, 2012 at 1:16 AM, Xinchen Hui wrote: > Commit:    3b42f184cdcf512fdc1f944052bfa296f17a035f > Author:    Xinchen Hui         Sun, 15 Apr 2012 01:16:

[PHP-CVS] com php-src: Merge branch 'PHP-5.4': main/main.c

2012-04-14 Thread Xinchen Hui
Commit:579d234f5078fc87b0b21a333a5fdfc60e9df124 Author:Xinchen Hui Sun, 15 Apr 2012 01:17:56 +0800 Parents: c62a41860e151b3c95ccd05d1ad7d25797219563 3b42f184cdcf512fdc1f944052bfa296f17a035f Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=579d234

[PHP-CVS] com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c

2012-04-14 Thread Xinchen Hui
Commit:3b42f184cdcf512fdc1f944052bfa296f17a035f Author:Xinchen Hui Sun, 15 Apr 2012 01:16:34 +0800 Parents: 6ecac269728360180a2813e75dfbe8338a05a27a Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=3b42f184cdcf512fdc1f944052bfa296f17a035f Log: F