Re: [PHP-CVS] com php-src: Refactor to using a stack based zval instead of dynamic allocation: ext/standard/password.c

Hi, I gave a quick review to the overal implementation of this feature. A few comments: - php_password_make_salt() shouldn't allocate memory + do memcpy, but it should fill in 'ret' directly instead. Both mallocs can go away. - in PHP_FUNCTION(password_get_info) you assume that sscanf always s

Re: [PHP-CVS] com php-src: Really fix leaks, add test cases to prove it...: ext/standard/password.c ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_hash_er

Nuno, On Tue, Oct 16, 2012 at 2:14 PM, Nuno Lopes wrote: > Hi, > > + case IS_BOOL: >> + case IS_NULL: >> case IS_RESOURCE: >> case IS_ARRAY: >> default: >> > > it doesn't make sense to have those cases and the default. Please remove > all those useless cases. I see it as self-documentat

Re: [PHP-CVS] com php-src: Really fix leaks, add test cases to prove it...: ext/standard/password.c ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_hash_er

Hi, + case IS_BOOL: + case IS_NULL: case IS_RESOURCE: case IS_ARRAY: default: it doesn't make sense to have those cases and the default. Please remove all those useless cases. Nuno -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] com php-src: fix newly introduced segfault: ext/mysqlnd/mysqlnd_auth.c

Commit:b0e8fb6489f7aa65aeaae6198a3dd81574f1ebcd Author:Andrey Hristov Tue, 16 Oct 2012 15:06:02 +0200 Parents: ccf749e38d1c05ab50d30781b47e55786d571585 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=b0e8fb6489f7aa65aeaae6198a3dd81574f1ebcd Log:

[PHP-CVS] com php-src: Cover have_ssl=NO and have_ssl=DISABLED: ext/mysqli/tests/bug51647.phpt ext/mysqli/tests/bug55283.phpt

Commit:da541ff561e0ac6ac72d2efd8b785ecfeef868dc Author:ULF WENDEL Sat, 29 Sep 2012 18:54:54 +0200 Parents: 20e76f4487baf60dc52b348e86bae4628026c4c2 Branches: PHP-5.3 PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=da541ff561e0ac6ac72d2efd8b785ecfeef

[PHP-CVS] com php-src: Updating expected output in anticipation of mysqlnd_auth.c path: ext/mysqli/tests/mysqli_pam_sha256_public_key_option_invalid.phpt

Commit:917639d4631b456f8ffd959a3c523071c3e9c8b5 Author:ULF WENDEL Sat, 29 Sep 2012 17:42:00 +0200 Parents: 0e1df4dfe735eb038964aaf917d1e14cc7ad7de3 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=917639d4631b456f8ffd959a3c523071c3e9c8b5 Log: Upda

[PHP-CVS] tag php-src: create tag php-5.4.8

Tag php-5.4.8 in php-src.git was created Tag: 52c29b272abab0e7cb51e45fb3ffd9858060e463 Tagger: Stanislav Malyshev Tue Oct 16 13:06:41 2012 +0300 Log: 5.4.8 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (Darwin) iF4EABEIAAYFAlB9MbUACgkQL3lWvF2gS12u7wEAiZ2YsdixgJ2X2OrF9X

[PHP-CVS] com php-src: credits update: ext/standard/credits_sapi.h

Commit:7df3c767b8223c1b7b3e7c4f921519ba9d5ba2a3 Author:Stanislav Malyshev Tue, 16 Oct 2012 13:05:41 +0300 Parents: fc17700db0aaab11a0c05d5dc854763791a0c097 Branches: PHP-5.4.8 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=7df3c767b8223c1b7b3e7c4f921519ba9d5ba2a

[PHP-CVS] com php-src: 5.4.8: NEWS configure.in main/php_version.h

Commit:fc17700db0aaab11a0c05d5dc854763791a0c097 Author:Stanislav Malyshev Tue, 16 Oct 2012 13:04:42 +0300 Parents: 3ff75ba85803e96df5ac5c6d77220c5c520f5304 Branches: PHP-5.4.8 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=fc17700db0aaab11a0c05d5dc854763791a0c09

[PHP-CVS] com php-src: updated NEWS: NEWS

Commit:7eba512b5170fc57dc3d4a6b93f98a0e0acc7721 Author:Anatoliy Belsky Tue, 16 Oct 2012 11:14:43 +0200 Parents: 3c89f8507f5c476135e7b3ceead4837271dff421 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=7eba512b5170fc57dc3d4a6b93f98a0e0acc7721 Log

[PHP-CVS] com php-src: Fixed bug #63248 Load multiple magic files on win: NEWS ext/fileinfo/config.w32 ext/fileinfo/libmagic.patch ext/fileinfo/libmagic/apprentice.c

Commit:6d019deee206dd76396bcaff9497ae3619d279b0 Author:Anatoliy Belsky Tue, 16 Oct 2012 11:03:32 +0200 Parents: 13d4d8e2d037385bfa2c7775929b65ae1f73998d Branches: PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6d019deee206dd76396bcaff9497ae3619d27

[PHP-CVS] com php-src: Base structure for passsword_create and password_make_salt: ext/standard/basic_functions.c ext/standard/config.m4 ext/standard/config.w32 ext/standard/password.c ext/standard/ph

Commit:c77f2c29585f97bd9dad533b9d2bc8334de34f1b Author:Anthony Ferrara Sun, 24 Jun 2012 22:44:43 -0400 Parents: d68b614b09b984e915db50b72430db4e4731480c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c77f2c29585f97bd9dad533b9d2bc8334de34f1b Log

[PHP-CVS] com php-src: Actually complete password_create(): ext/standard/password.c ext/standard/php_password.h

Commit:7e41980fe4972e097e178c034f92920c9c63086c Author:Anthony Ferrara Sun, 24 Jun 2012 23:25:18 -0400 Parents: c77f2c29585f97bd9dad533b9d2bc8334de34f1b Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=7e41980fe4972e097e178c034f92920c9c63086c Log

[PHP-CVS] com php-src: Implement password_verify: ext/standard/password.c

Commit:657402832b7884f52bf07b2e6f704510395fd413 Author:Anthony Ferrara Sun, 24 Jun 2012 23:35:26 -0400 Parents: 7e41980fe4972e097e178c034f92920c9c63086c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=657402832b7884f52bf07b2e6f704510395fd413 Log

[PHP-CVS] com php-src: Fix memory leak on branch: ext/standard/password.c

Commit:f7097d99ffedc6bd0965542454b4ac86e4b5c914 Author:Anthony Ferrara Sun, 24 Jun 2012 23:36:09 -0400 Parents: 657402832b7884f52bf07b2e6f704510395fd413 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f7097d99ffedc6bd0965542454b4ac86e4b5c914 Log

[PHP-CVS] com php-src: Basic random generator added to make_salt: ext/standard/password.c

Commit:18d3bd9481c470d241c492eb39a93bd071a77c4e Author:Anthony Ferrara Mon, 25 Jun 2012 08:15:17 -0400 Parents: f7097d99ffedc6bd0965542454b4ac86e4b5c914 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=18d3bd9481c470d241c492eb39a93bd071a77c4e Log

[PHP-CVS] com php-src: More error checking, and some cleaning up for password.c: ext/standard/password.c

Commit:618f2629567ca3a3d1817ca9c4c62339fb5fb886 Author:Anthony Ferrara Mon, 25 Jun 2012 08:50:39 -0400 Parents: 18d3bd9481c470d241c492eb39a93bd071a77c4e Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=618f2629567ca3a3d1817ca9c4c62339fb5fb886 Log

[PHP-CVS] com php-src: Implement openssl support for make_salt: ext/standard/password.c

Commit:41d7374ea4598000fd626c0d8cd4736aec6357bf Author:Anthony Ferrara Mon, 25 Jun 2012 11:37:48 -0400 Parents: 618f2629567ca3a3d1817ca9c4c62339fb5fb886 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=41d7374ea4598000fd626c0d8cd4736aec6357bf Log

[PHP-CVS] com php-src: Refactor salt generation, rename password_create to password_hash: ext/standard/basic_functions.c ext/standard/password.c ext/standard/php_password.h

Commit:2d4b7cb653efc3f52ca907f48b1c828632df5e41 Author:Anthony Ferrara Mon, 25 Jun 2012 21:22:16 -0400 Parents: 41d7374ea4598000fd626c0d8cd4736aec6357bf Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=2d4b7cb653efc3f52ca907f48b1c828632df5e41 Log

[PHP-CVS] com php-src: Add tests for password hashing: ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_hash.phpt ext/standard/tests/password/password_hash_

Commit:e505316aeba0fbb52cd21ff84af784a9d3e2b49a Author:Anthony Ferrara Tue, 26 Jun 2012 22:05:25 -0400 Parents: 232da90388de2a3ba4ad430d281469498e88aca2 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e505316aeba0fbb52cd21ff84af784a9d3e2b49a Log

[PHP-CVS] com php-src: Implement php.ini setting password.bcrypt_cost: ext/standard/basic_functions.c ext/standard/password.c ext/standard/php_password.h main/main.c php.ini-development php.ini-produc

Commit:232da90388de2a3ba4ad430d281469498e88aca2 Author:Anthony Ferrara Tue, 26 Jun 2012 21:15:56 -0400 Parents: 2d4b7cb653efc3f52ca907f48b1c828632df5e41 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=232da90388de2a3ba4ad430d281469498e88aca2 Log

[PHP-CVS] com php-src: Add tests and error checking for large salt requested values to prevent overflow on allocation: ext/standard/password.c ext/standard/tests/password/password_make_salt_error.phpt

Commit:5f44be03af7733c2618d980e77426572fb0148df Author:Anthony Ferrara Tue, 26 Jun 2012 23:09:08 -0400 Parents: 2b9591f11f2573f8d9032477b7ad49c6cf92988c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5f44be03af7733c2618d980e77426572fb0148df Log

[PHP-CVS] com php-src: Update tests to check ini setting: ext/standard/tests/password/password_hash.phpt

Commit:2b9591f11f2573f8d9032477b7ad49c6cf92988c Author:Anthony Ferrara Tue, 26 Jun 2012 22:13:51 -0400 Parents: e505316aeba0fbb52cd21ff84af784a9d3e2b49a Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=2b9591f11f2573f8d9032477b7ad49c6cf92988c Log

[PHP-CVS] com php-src: Fix formatting issues in password.c: ext/standard/password.c

Commit:0dd2f16b148f4054d65645b9cf971fe08824d78d Author:Anthony Ferrara Wed, 27 Jun 2012 11:04:41 -0400 Parents: 5f44be03af7733c2618d980e77426572fb0148df Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=0dd2f16b148f4054d65645b9cf971fe08824d78d Log

[PHP-CVS] com php-src: Refactor crypt to use an external working function: ext/standard/crypt.c ext/standard/php_crypt.h

Commit:6bb3865a235d437d91df1940b0caad6995b69d4c Author:Anthony Ferrara Thu, 28 Jun 2012 14:44:04 -0400 Parents: 0dd2f16b148f4054d65645b9cf971fe08824d78d Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6bb3865a235d437d91df1940b0caad6995b69d4c Log

[PHP-CVS] com php-src: Refactor password.c a bit, add different error checking: ext/standard/password.c ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_has

Commit:da3d8bf514e61a486065b0bf335b4657f20e6b66 Author:Anthony Ferrara Thu, 28 Jun 2012 15:29:40 -0400 Parents: 6bb3865a235d437d91df1940b0caad6995b69d4c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=da3d8bf514e61a486065b0bf335b4657f20e6b66 Log

[PHP-CVS] com php-src: More refactoring of crypt into php_crypt, and fixing memory allocation: ext/standard/crypt.c ext/standard/password.c ext/standard/php_crypt.h

Commit:9c1445c6bcee99dbe1eeb9eb8eb6cd626ca72a9c Author:Anthony Ferrara Fri, 29 Jun 2012 11:32:25 -0400 Parents: 9e18e578f0e7f30c2d73ae38620b5fd228ac21eb Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=9c1445c6bcee99dbe1eeb9eb8eb6cd626ca72a9c Log

[PHP-CVS] com php-src: Update password.c to use safe_emalloc in sensitive places: ext/standard/password.c

Commit:f53112fdcf746ef73660059e72f8798d0108acac Author:Anthony Ferrara Fri, 29 Jun 2012 11:37:39 -0400 Parents: 9c1445c6bcee99dbe1eeb9eb8eb6cd626ca72a9c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f53112fdcf746ef73660059e72f8798d0108acac Log

[PHP-CVS] com php-src: Remove php.ini setting for default bcrypt cost: ext/standard/password.c ext/standard/php_password.h ext/standard/tests/password/password_hash.phpt php.ini-development php.ini-pr

Commit:6cc3c65fbf06da075934c89e470fa776d4d968fa Author:Anthony Ferrara Tue, 3 Jul 2012 07:33:55 -0400 Parents: f53112fdcf746ef73660059e72f8798d0108acac Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6cc3c65fbf06da075934c89e470fa776d4d968fa Log:

[PHP-CVS] com php-src: Some more refactoring, make algo no longer optional: ext/standard/basic_functions.c ext/standard/password.c ext/standard/php_password.h ext/standard/tests/password/password_hash

Commit:6943f2ab7f729d26281f9358dba27890d07dd24d Author:Anthony Ferrara Tue, 3 Jul 2012 08:24:31 -0400 Parents: 6cc3c65fbf06da075934c89e470fa776d4d968fa Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6943f2ab7f729d26281f9358dba27890d07dd24d Log:

[PHP-CVS] com php-src: Update signature info for changing algo to an ordinal: ext/standard/password.c

Commit:886527de56ecdd412a80a2901b8a0e3b622f037c Author:Anthony Ferrara Tue, 3 Jul 2012 08:26:50 -0400 Parents: 6943f2ab7f729d26281f9358dba27890d07dd24d Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=886527de56ecdd412a80a2901b8a0e3b622f037c Log:

[PHP-CVS] com php-src: Fix issue with int vs long parameter: ext/standard/password.c

Commit:db86d54446c461eab518225645889abc509db034 Author:Anthony Ferrara Thu, 5 Jul 2012 17:31:40 -0400 Parents: 5160dc11cd9d0e97eb59138f4639e5af0584f370 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=db86d54446c461eab518225645889abc509db034 Log:

[PHP-CVS] com php-src: Implement password_needs_rehash() function: ext/standard/basic_functions.c ext/standard/password.c ext/standard/php_password.h

Commit:5160dc11cd9d0e97eb59138f4639e5af0584f370 Author:Anthony Ferrara Thu, 5 Jul 2012 16:22:49 -0400 Parents: 886527de56ecdd412a80a2901b8a0e3b622f037c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5160dc11cd9d0e97eb59138f4639e5af0584f370 Log:

[PHP-CVS] com php-src: Implement password_get_info() function: ext/standard/basic_functions.c ext/standard/password.c ext/standard/php_password.h

Commit:ee7e7998410c8fd5bd2183b1af375622f0ca8e02 Author:Anthony Ferrara Thu, 5 Jul 2012 17:46:33 -0400 Parents: db86d54446c461eab518225645889abc509db034 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ee7e7998410c8fd5bd2183b1af375622f0ca8e02 Log:

[PHP-CVS] com php-src: Cleanup whitespace issues: ext/standard/password.c

Commit:9d3630b5dc8fa066dc4212ead2fffc8635f5bc0a Author:Anthony Ferrara Thu, 5 Jul 2012 17:58:19 -0400 Parents: ee7e7998410c8fd5bd2183b1af375622f0ca8e02 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=9d3630b5dc8fa066dc4212ead2fffc8635f5bc0a Log:

[PHP-CVS] com php-src: Merge remote branch 'upstream/master' into hash_password: ext/standard/basic_functions.c

Commit:99b7956ad58395853f7950ae01a43139413d348d Author:Anthony Ferrara Tue, 10 Jul 2012 10:33:51 -0400 Parents: 9d3630b5dc8fa066dc4212ead2fffc8635f5bc0a b210766084cbd00b0e479d2800e1920271a3faba Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=99b

[PHP-CVS] com php-src: Switch second parameter to password_make_salt to be a flag: ext/standard/password.c ext/standard/php_password.h ext/standard/tests/password/password_make_salt.phpt ext/standard/

Commit:707c9073b595a75447fbc25e01e7804293fad9b7 Author:Anthony Ferrara Wed, 11 Jul 2012 22:15:56 -0400 Parents: 99b7956ad58395853f7950ae01a43139413d348d Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=707c9073b595a75447fbc25e01e7804293fad9b7 Log

[PHP-CVS] com php-src: Remove password_make_salt() from the implementation: ext/standard/basic_functions.c ext/standard/password.c ext/standard/php_password.h ext/standard/tests/password/password_make

Commit:e05413ca594ff10fd93d40429cb598c2e109edf4 Author:Anthony Ferrara Tue, 28 Aug 2012 11:24:33 -0400 Parents: 707c9073b595a75447fbc25e01e7804293fad9b7 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e05413ca594ff10fd93d40429cb598c2e109edf4 Log

[PHP-CVS] com php-src: Merge remote branch 'upstream/master' into hash_password: ext/standard/basic_functions.c main/main.c

Commit:824f1f45818096eff0e022ba2a1cbc2071343c9a Author:Anthony Ferrara Tue, 4 Sep 2012 10:29:22 -0400 Parents: e05413ca594ff10fd93d40429cb598c2e109edf4 4b206126aca2ad9181abe65d70367680a4bc4c03 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=824f

[PHP-CVS] com php-src: Refactoring to use size_t instead of int most places: ext/standard/password.c ext/standard/php_password.h

Commit:db41f9fe60d863041fb53a273c2f64b6925f5ad0 Author:Anthony Ferrara Tue, 4 Sep 2012 11:34:00 -0400 Parents: 824f1f45818096eff0e022ba2a1cbc2071343c9a Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=db41f9fe60d863041fb53a273c2f64b6925f5ad0 Log:

[PHP-CVS] com php-src: Fix incorrect arg info required param count for password_hash: ext/standard/basic_functions.c

Commit:7ec80e1a139ca7f43c02728f3fe2424cef0138b6 Author:Anthony Ferrara Wed, 12 Sep 2012 12:15:33 -0400 Parents: 7161c3d2cfde54ce218f20d03684f2a58e1c7627 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=7ec80e1a139ca7f43c02728f3fe2424cef0138b6 Log

[PHP-CVS] com php-src: Add tests for password_get_info and password_needs_rehash: ext/standard/tests/password/password_get_info.phpt ext/standard/tests/password/password_get_info_error.phpt ext/standa

Commit:e8b7f5b35da46a2bc414c922e8e1a7093d963899 Author:Anthony Ferrara Wed, 12 Sep 2012 11:21:08 -0400 Parents: db41f9fe60d863041fb53a273c2f64b6925f5ad0 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e8b7f5b35da46a2bc414c922e8e1a7093d963899 Log

[PHP-CVS] com php-src: Switch test to using strict comparison for crypt fallback: ext/standard/tests/password/password_hash.phpt

Commit:e9a7bde829b3e43e2c61455752801e31ea88974f Author:Anthony Ferrara Wed, 12 Sep 2012 11:37:56 -0400 Parents: e8b7f5b35da46a2bc414c922e8e1a7093d963899 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e9a7bde829b3e43e2c61455752801e31ea88974f Log

[PHP-CVS] com php-src: Expose PASSWORD_BCRYPT_DEFAULT_COST constant and update test to use it: ext/standard/password.c ext/standard/tests/password/password_needs_rehash.phpt

Commit:76f3295cdfd6a3106297352e73b9691084582211 Author:Anthony Ferrara Wed, 12 Sep 2012 11:47:50 -0400 Parents: ebe0bd5dee07bebd8444d9e7c28864ba17efeef8 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=76f3295cdfd6a3106297352e73b9691084582211 Log

[PHP-CVS] com php-src: Remove bcrypt_cost ini entry from declaration: main/main.c

Commit:ebe0bd5dee07bebd8444d9e7c28864ba17efeef8 Author:Anthony Ferrara Wed, 12 Sep 2012 11:44:03 -0400 Parents: e9a7bde829b3e43e2c61455752801e31ea88974f Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ebe0bd5dee07bebd8444d9e7c28864ba17efeef8 Log

[PHP-CVS] com php-src: Add news entry for password API: NEWS

Commit:7161c3d2cfde54ce218f20d03684f2a58e1c7627 Author:Anthony Ferrara Wed, 12 Sep 2012 11:56:12 -0400 Parents: 3e383dc0d5d7eb957f6639ab38dd566e16bca92b Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=7161c3d2cfde54ce218f20d03684f2a58e1c7627 Log

[PHP-CVS] com php-src: Switch to using an ENUM for algorithms instead of a constant: ext/standard/password.c ext/standard/php_password.h

Commit:83cfff4593bd3bd7791f32795e9b5bda446cd8e2 Author:Anthony Ferrara Thu, 13 Sep 2012 10:32:54 -0400 Parents: 7ec80e1a139ca7f43c02728f3fe2424cef0138b6 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=83cfff4593bd3bd7791f32795e9b5bda446cd8e2 Log

[PHP-CVS] com php-src: A bunch of naming convention fixes. No functionality changes: ext/standard/password.c ext/standard/php_password.h

Commit:e034a46bdc36fb82957f5e503fa730776dfbba11 Author:Anthony Ferrara Mon, 17 Sep 2012 10:52:07 -0400 Parents: 83cfff4593bd3bd7791f32795e9b5bda446cd8e2 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e034a46bdc36fb82957f5e503fa730776dfbba11 Log

[PHP-CVS] com php-src: Fix ucwords error casing: ext/standard/password.c

Commit:44c2624f8c7d6bc00f46bc69c77791c2a334cc9a Author:Anthony Ferrara Mon, 17 Sep 2012 10:59:51 -0400 Parents: e034a46bdc36fb82957f5e503fa730776dfbba11 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=44c2624f8c7d6bc00f46bc69c77791c2a334cc9a Log

[PHP-CVS] com php-src: Refactor slightly to enable cleaner readability: ext/standard/password.c

Commit:8bd79d180716fc521a3f5cae4bbfa96eb6397925 Author:Anthony Ferrara Mon, 17 Sep 2012 11:43:47 -0400 Parents: 6fd5ba5c8d70ecbd80175a488160f57380d8afee Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=8bd79d180716fc521a3f5cae4bbfa96eb6397925 Log

[PHP-CVS] com php-src: Fix arg info for required params passed to needs_rehash: ext/standard/basic_functions.c

Commit:6fd5ba5c8d70ecbd80175a488160f57380d8afee Author:Anthony Ferrara Mon, 17 Sep 2012 11:10:59 -0400 Parents: 44c2624f8c7d6bc00f46bc69c77791c2a334cc9a Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6fd5ba5c8d70ecbd80175a488160f57380d8afee Log

[PHP-CVS] com php-src: Fix some double free issues, and more cleanup work: ext/standard/password.c

Commit:4a7d18c79ef956022090cf7e8159ca6d50ae2339 Author:Anthony Ferrara Fri, 5 Oct 2012 15:31:58 -0400 Parents: 8bd79d180716fc521a3f5cae4bbfa96eb6397925 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=4a7d18c79ef956022090cf7e8159ca6d50ae2339 Log:

[PHP-CVS] com php-src: Fix issue with possible memory leak: ext/standard/password.c

Commit:25b2d364e995fc070ae16ee34f60d25148413769 Author:Anthony Ferrara Fri, 5 Oct 2012 15:53:40 -0400 Parents: 4a7d18c79ef956022090cf7e8159ca6d50ae2339 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=25b2d364e995fc070ae16ee34f60d25148413769 Log:

[PHP-CVS] com php-src: fix allocation and copy issue: ext/standard/password.c

Commit:76e83f769ff5929b45cf0ac666335ce68ada166f Author:Anthony Ferrara Sat, 6 Oct 2012 12:33:48 -0400 Parents: 1751d5fabeff466f08da560caa6f9ade5a82 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=76e83f769ff5929b45cf0ac666335ce68ada166f Log:

[PHP-CVS] com php-src: Really fix leaks, add test cases to prove it...: ext/standard/password.c ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_hash_error.

Commit:1751d5fabeff466f08da560caa6f9ade5a82 Author:Anthony Ferrara Sat, 6 Oct 2012 10:38:41 -0400 Parents: 25b2d364e995fc070ae16ee34f60d25148413769 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=1751d5fabeff466f08da560caa6f9ade5a82 Log:

[PHP-CVS] com php-src: Clean up unreported memory leak by switching to zval_ptr_dtor: ext/standard/password.c

Commit:37b2207f66ac1cebdc3ff3f7f88ec319ee893292 Author:Anthony Ferrara Sun, 7 Oct 2012 05:12:02 -0400 Parents: 76e83f769ff5929b45cf0ac666335ce68ada166f Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=37b2207f66ac1cebdc3ff3f7f88ec319ee893292 Log:

[PHP-CVS] com php-src: Refactor to using a stack based zval instead of dynamic allocation: ext/standard/password.c

Commit:0bc9ca39ced4128c3b9fb1ba2ac797d342e7eef2 Author:Anthony Ferrara Sun, 7 Oct 2012 05:42:08 -0400 Parents: 37b2207f66ac1cebdc3ff3f7f88ec319ee893292 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=0bc9ca39ced4128c3b9fb1ba2ac797d342e7eef2 Log:

[PHP-CVS] com php-src: Merging in Password Hashing API into master: NEWS

Commit:9aacdf6e892fe46526e1e60a3b3fea1b1c350699 Author:Anthony Ferrara Tue, 16 Oct 2012 04:11:37 -0400 Parents: ccf749e38d1c05ab50d30781b47e55786d571585 0bc9ca39ced4128c3b9fb1ba2ac797d342e7eef2 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=9aa