Re: [PHP-CVS] com php-src: Fix bug #64729: compilation failure on x32: Zend/zend_alloc.c Zend/zend_multiply.h

2013-04-30 Thread Gustavo Lopes
sed on the type of the registers. [1] http://en.wikipedia.org/wiki/X32_ABI -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] Re: 回复: [PHP-CVS] com php-src: Fix zend_dval_to_lval outside 64bit integers range: Zend/tests/bug39018.phpt Zend/tests/dval_to_lval_32.phpt Zend/tests/dval_to_lval_64.phpt Zend/zend_operator

2013-02-24 Thread Gustavo Lopes
line 6 004- You have to run make clean or at least delete the object files in Zend. Because only a header file change, the makefile doesn't have anything recompiled. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] Re: Merge branch 'bug40459' into PHP-5.4

2012-08-09 Thread Gustavo Lopes
Em Thu, 09 Aug 2012 21:36:38 +0200, Gustavo Lopes escreveu: m NEWS m UPGRADING + ext/standard/tests/streams/bug40459.phpt m main/streams/userspace.c Merge branch 'bug40459' into PHP-5.4 * bug40459: News for bug#40459 fix bug #40459 - make all stream funcs that create objec

[PHP-CVS] Re: Merge branch 'bug40459' into PHP-5.4

2012-08-09 Thread Gustavo Lopes
hp/php-src/commit/c98a51a169956f3cf5f1f2eade053a38549c7315 I don't think this should go into 5.4. Is this not a BC break for all the code that uses a constructor with arguments (either by mistake or because for reason the class is parallelly instantiated without involving the stream

Re: [PHP-CVS] com php-src: Add ini setting intl.explicit_cleanup: ext/intl/php_intl.c

2012-07-23 Thread Gustavo Lopes
Em Mon, 23 Jul 2012 17:34:44 +0200, Hannes Magnusson escreveu: On Mon, Jul 23, 2012 at 4:32 PM, Gustavo Lopes wrote: On Mon, 23 Jul 2012 16:15:42 +0100, Hannes Magnusson wrote: Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=0dfcc3e798cd54714f792bf7507c37b96146ee1b Log: Add ini

Re: [PHP-CVS] com php-src: Add ini setting intl.explicit_cleanup: ext/intl/php_intl.c

2012-07-23 Thread Gustavo Lopes
to u_cleanup() on module shutdown. hhhh. What is the usecase for that? Detecting leaks with valgrind. Otherwise, one gets lots of false positives. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] com php-src: Fix test fails: ext/standard/tests/general_functions/bug27678.phpt: ext/standard/math.c ext/standard/tests/general_functions/bug27678.phpt

2012-07-17 Thread Gustavo Lopes
something else could rely on the change. In principle). -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] com php-src: Updated UPGRADING with changes to ext/intl.: UPGRADING

2012-05-13 Thread Gustavo Lopes
think there any point in supporting such old versions, especially since this is for a version of PHP that won't be out for another year. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] com php-src: Fixed bug in new stream_get_line() when using NUL as a delimiter.: ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt main/streams/streams.c

2012-04-09 Thread Gustavo Lopes
On Mon, 09 Apr 2012 07:11:52 +0100, Stas Malyshev wrote: This fixes a problem caused by a change that's not in any released PHP version. Which change caused the problem? Commit 45a6f8d9. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] com php-src: Fixed bug in new stream_get_line() when using NUL as a delimiter.: ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt main/streams/streams.c

2012-04-08 Thread Gustavo Lopes
: A ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt M main/streams/streams.c Can you add a NEWS entry? This fixes a problem caused by a change that's not in any released PHP version. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] svn: /php/php-src/trunk/main/streams/ php_stream_context.h streams.c

2012-02-21 Thread Gustavo Lopes
away. In any case, since this is a breakage, it should be in UPGRADING and NEWS. Thank you for the reminder; I will add it. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 05 Feb 2012 15:00:11 +0100, Gustavo Lopes wrote: On Sun, 5 Feb 2012 14:37:27 +0100, Pierre Joye wrote: 2012/2/5 Gustavo Lopes : All the length and position variables are of type size_t, so I'd say we'd be out of memory long before that could be a problem (unless th

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 5 Feb 2012 14:37:27 +0100, Pierre Joye wrote: 2012/2/5 Gustavo Lopes : All the length and position variables are of type size_t, so I'd say we'd be out of memory long before that could be a problem (unless there's some architecture of which I'm not aware where SI

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 05 Feb 2012 14:00:11 +0100, Gustavo Lopes wrote: On Sun, 5 Feb 2012 10:55:39 -, Nuno Lopes wrote: I didn't carefully review this patch, but doesn't this code suffer from potential math overflow? i.e. with strlen($input_str) > INT_MAX/2 (or UINT_MAX/2) All the length

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
ay we'd be out of memory long before that could be a problem (unless there's some architecture of which I'm not aware where SIZE_T is low enough for this to be a problem). -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/http/bug38802.phpt branches/PHP_5_3/ext/standard/tests/http/bug43510.phpt branches/PHP_5_3/ext/standard/tests/http/bug48929.phpt br

2011-11-13 Thread Gustavo Lopes
:0 ( 0.0%) ( 0.0%) Tests passed:5 (100.0%) (100.0%) - Time taken :0 seconds ===== -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt trunk/ext/phar/tests/phar_oo_001.phpt

2011-11-05 Thread Gustavo Lopes
On Sat, 05 Nov 2011 15:19:00 -, Hannes Magnusson wrote: I believe Gustavo changed the behaviour again recently. Don't have the time to check it out now though. Yes, I made 5.4/trunk behave like 5.3. See r318566. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/tests/bug55646.phpt trunk/ext/openssl/tests/bug55646.phpt

2011-09-14 Thread Gustavo Lopes
iven in /home/bjori/Work/src/php/php/php-src/branches/PHP_5_4/ext/openssl/tests/bug55646.php on line 14 003- C: IT 互 004- D: 49 54 20 e4 ba 92 006+ C: 007+ D: Thanks, I've made the test more portable and also fixed 004.phpt. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/libxml/libxml.c trunk/ext/libxml/libxml.c

2011-09-02 Thread Gustavo Lopes
der for those active. Additionally, setting this global option means threads with no PHP context will be affected too, so the preloader implementation has to determine whether it has a valid context. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/standard/tests/strings/htmlentities15.phpt trunk/ext/standard/tests/strings/htmlentities15.phpt

2011-08-31 Thread Gustavo Lopes
e effect as specifying '', i.e. autodetection. But you're right, it should be documented. (CC to internals because you also sent an e-mail about this test there) -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/libxml/libxml.c branches/PHP_5_4/ext/libxml/php_libxml.h trunk/ext/libxml/libxml.c trunk/ext/libxml/php_libxml.h

2011-08-30 Thread Gustavo Lopes
xmlCleanupParser(); zend_hash_destroy(&php_libxml_exports); + + xmlSetExternalEntityLoader(_php_libxml_default_entity_loader); _php_libxml_initialized = 0; } } -- Gustavo Lopes -- PHP CVS Mailing List (http://

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS ext/spl/spl_directory.c ext/spl/spl_iterators.c ext/spl/tests/bug54384.phpt ext/spl/tests/iterator_031.phpt

2011-04-25 Thread Gustavo Lopes
y instance method, so in spl_directory.c I used a centralized the check in the get_method handler; this technique was already used in SPL the difference is it would emit an error instead of causing an exception to be thrown. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/serialize/precision.phpt branches/PHP_5_3/main/main.c trunk/ext/standard/tests/serialize/precision.phpt trunk

2011-02-08 Thread Gustavo Lopes
On Wed, 09 Feb 2011 00:05:39 -, Christopher Jones wrote: Can you update php.ini-* too - and ideally also update the doc? Try using edit.php.net. Done. Thanks for bringing this to my attention. -- Gustavo Lopes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

2010-12-21 Thread Gustavo Lopes
On Tue, 21 Dec 2010 18:52:07 -, Christopher Jones wrote: On 12/21/2010 10:47 AM, Gustavo Lopes wrote: On Tue, 21 Dec 2010 18:23:11 -, Christopher Jones wrote: Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt

2010-12-21 Thread Gustavo Lopes
pare() gives the "usual order" and SplMinHeap should give the elements in the usual increasing order (the top should have the smallest). Moreover, without the change extending SplMinHeap or SplMaxHeap would give the same result. -- Gustavo Lopes -- PHP CVS Mailing List (http://ww

[PHP-CVS] Re: [PHP-DEV] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_functions.h main/php_streams.h main/streams/memory.c main/streams/streams.c

2010-11-16 Thread Gustavo Lopes
On Mon, 15 Nov 2010 07:25:44 -, Kalle Sommer Nielsen wrote: 2010/11/15 Gustavo André dos Santos Lopes : cataphract Mon, 15 Nov 2010 03:05:32 + Revision: http://svn.php.net/viewvc?view=revision&revision=305346 Log: - Added leak_variable() function. Wh

Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_funct ions.h main/php_streams.h main/streams/memory.c m ain/streams/streams.c

2010-11-15 Thread Gustavo Lopes
On Mon, 15 Nov 2010 08:25:44 +0100, Kalle Sommer Nielsen wrote: > Hi > > 2010/11/15 Gustavo André dos Santos Lopes : >> cataphract                               Mon, 15 Nov 2010 03:05:32 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=305346 >> >> Log: >> - Added leak_varia

Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING ext/reflection/php_reflection.c ext/reflection/tests/ReflectionParameter_canBePassedByValue.phpt

2010-10-26 Thread Gustavo Lopes
D_SEND_PREFER_REF 2 With ZEND_SEND_PREFER_REF, the parameter is sent by reference, but if it's not possible, instead of giving an error, it allows the value. That's what canBePassedByValue tests; whether sending a value would give an error or not. -- Gustavo Lopes -- PHP CVS Ma