Here I was also wondering whether the commit hash could be left out to reduce
verbosity even more. It is still included in the link.
Thanks
Stefan
--
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2
gron Sun, 04 Mar 2012 19:34:19 +
Revision: http://svn.php.net/viewvc?view=revision&revision=323898
Log:
Fixed Bug #61052 (Missing error check in trait 'insteadof' clause)
Bug: https://bugs.php.net/61052 (Assigned) missing error check in trait
'insteadof'
gron Sun, 04 Mar 2012 18:33:33 +
Revision: http://svn.php.net/viewvc?view=revision&revision=323892
Log:
Fixed Bug #60911 (Confusing error message when extending traits)
Bug: https://bugs.php.net/60911 (Assigned) Confusing error message when
extending trai
gron Sun, 04 Mar 2012 18:26:11 +
Revision: http://svn.php.net/viewvc?view=revision&revision=323891
Log:
Fixed Bug #60717 (Order of traits in use statement can cause a fatal error)
# Compatibility is now correctly checked in both directions.
# Introduced hel
U php/php-src/trunk/Zend/zend_compile.c
>U php/php-src/trunk/Zend/zend_object_handlers.c
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
--
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinla
gron Sat, 17 Dec 2011 14:26:39 +
Revision: http://svn.php.net/viewvc?view=revision&revision=321089
Log:
Fixed inconsistent and broken handling of private properties in traits.
# The handling of private properties in classes is now consistent with private
p
gron Wed, 23 Nov 2011 21:24:34 +
Revision: http://svn.php.net/viewvc?view=revision&revision=319727
Log:
Fixed Bug #60369Crash with static property in trait
Bug: https://bugs.php.net/60369 (Verified) Crash with static property in trait
Change
condition.
Anyway, that is what I mean with `tabling` the related parts. I don't see how
that violates the style guide, but IMHO, it makes quite a difference when it
comes to readability of such involved if/else if/else if/else if/else if/else
if/else if/else if/else if/else if constructs.
Be
Hi:
On 18 Nov 2011, at 15:16, Felipe Pena wrote:
> Hi,
>
> 2011/11/18 Stefan Marr :
>> Hi Felipe:
>>
>> On 18 Nov 2011, at 14:56, Felipe Pena wrote:
>>
>>> felipe Fri, 18 Nov 2011 13:56:41 +
>>>
&g
ere the code differs.
Breaking that up into multiple lines, does IMHO not improve readability or
clarity. If you just missed the braces, well, they could have been added
inline, no?
And I do not really buy that 'CS' (that is coding style?) applies to such a
special piece of code.
Woul
gron Fri, 18 Nov 2011 13:49:07 +
Revision: http://svn.php.net/viewvc?view=revision&revision=319483
Log:
Fixes Bug #54441 (Handling of changing modifiers on a trait alias)
# this now results also in a compilation error, since it would open the door
for inco
gron Thu, 17 Nov 2011 21:04:15 +
Revision: http://svn.php.net/viewvc?view=revision&revision=319420
Log:
Fixed Bug #60165 (Aliasing unexisting trait should throw/trigger the
exception/error)
- aliases that are not actually matching anything are treated as
gron Sat, 05 Nov 2011 02:05:28 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318794
Log:
Fixed inconsistent whitespace.
# Belongs to svn rev. 318793.
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src
gron Sat, 05 Nov 2011 01:46:40 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318793
Log:
Fixed Bug #60217 (Requiring the same method from different traits)
- also added test to check for inconsistent abstract method definitions, they
need to
catching this one and the one in svnrev 318723.
Do you have test cases which trigger these bugs by any chance?
Thanks
Stefan
--
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2 629 2974
Fax: +32 2
gron Tue, 01 Nov 2011 15:25:24 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318650
Log:
Fixed Bug #60153 (Interface method prototypes not enforced when implementd via
traits.)
# Moved the freeing of overriden functions to a point after the
gron Tue, 01 Nov 2011 13:42:53 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318646
Log:
Added missing consistency check for abstract methods required by one trait and
implemented by another.
Changed paths:
A
php/php-src/branches/PHP
gron Tue, 01 Nov 2011 00:39:10 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318625
Log:
Fixed Bug #60145 (Usage of trait's use statement inside interfaces not properly
checked.)
Bug: https://bugs.php.net/60145 (Assigned) interface + use tr
gron Mon, 31 Oct 2011 22:59:00 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318621
Log:
Fixed Bug #60173 (Wrong error message on reflective trait instantiation)
Bug: https://bugs.php.net/60173 (Assigned) Wrong message on trait instantiation
gron Sun, 09 Oct 2011 11:13:27 +
Revision: http://svn.php.net/viewvc?view=revision&revision=317935
Log:
Fixed Bug #4 (Legacy constructors not handled properly) [TRAITS] [DOC]
# The handling of legacy constructors defined by traits was corrected.
# They
gron Sat, 08 Oct 2011 23:47:16 +
Revision: http://svn.php.net/viewvc?view=revision&revision=317930
Log:
Use ZEND_ constants instead of plain strings for names of magic methods.
# No functional changes.
Changed paths:
U php/php-src/branches/PHP_5_4/Ze
gron Mon, 29 Aug 2011 15:53:46 +
Revision: http://svn.php.net/viewvc?view=revision&revision=315712
Log:
Fixed bug #55524 Traits should not be able to extend a class
# also used the Z_STRVAL where it seemed appropriate
Bug: https://bugs.php.net/55524 (Assig
On 16 Aug 2011, at 13:23, Hannes Magnusson wrote:
> On Tue, Aug 16, 2011 at 13:05, Stefan Marr wrote:
>> Hi Hannes:
>>
>> On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
>>
>>> + if (!strcmp(Z_STRVAL_P(name), "strict")) {
>&g
ange that error to be a bit more explicit about what is not expected?
Best regards
Stefan
--
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2 629 2974
Fax: +32 2 629 3525
--
PHP CVS Mailing List (htt
gron Mon, 15 Aug 2011 22:16:58 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314981
Log:
Bug #55424 Fatal error when calling a method from a trait that is defined
in parent class and required by using an abstract method in the trait.
#
gron Mon, 15 Aug 2011 11:16:18 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314943
Log:
Fixed Bug #55355: Inheritance chain was not regarded when checking whether the
abstract method of a trait is satisfied.
Bug: https://bugs.php.net/55355
gron Mon, 15 Aug 2011 09:54:06 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314933
Log:
Fixed Bug #55372 Incorrect handling of literals led to memory corruption.
# Dmitry you might want to review this patch, since I split up zend_add_literal
gron Mon, 15 Aug 2011 08:29:48 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314921
Log:
Addendum for patch to bug #55214: Class name was freed before method literal
referring to it.
# Thanks to Felipe for catching this.
# The fix duplicates
gron Sun, 31 Jul 2011 17:39:30 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313994
Log:
Added __TRAIT__ magic constant [TRAITS] [DOC]
# __TRAIT__ behaves like __CLASS__ more or less but is constraint to traits.
# Since traits are not types,
Hi:
On Sun, Jul 24, 2011 at 12:07 AM, Stanislav Malyshev wrote:
> stas Sat, 23 Jul 2011 22:07:22 +
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=313645
>
> Log:
> Change E_ALL to include E_STRICT
Could please someone take the time to fix t
gron Sun, 31 Jul 2011 16:35:09 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313993
Log:
Added: SKIP when tokenizer extension is not available
Changed paths:
U
php/php-src/branches/PHP_5_4/ext/tokenizer/tests/token_get_all_basic.phpt
gron Sun, 31 Jul 2011 16:15:40 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313992
Log:
Fixed test which was assuming that E_STRICT is not on by default.
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/tests/traits/property001.phpt
gron Sun, 24 Jul 2011 10:20:08 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313649
Log:
Added forgotten tests cases for class_uses() from commit rev. 313640
Changed paths:
A php/php-src/branches/PHP_5_4/ext/spl/tests/class_uses_basic.
gron Sat, 23 Jul 2011 19:08:43 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313640
Log:
Added missing class_uses(..) function to SPL to mirror class_implements(..).
# Was pointed out as missing in bug #55266.
Bug: https://bugs.php.net/5526
gron Sat, 23 Jul 2011 18:12:31 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313638
Log:
Fixed incorrect initialization when copied op_array.vars was NULL (TRAITS)
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
gron Sat, 23 Jul 2011 13:48:07 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313632
Log:
Fixed bug in the handling of conflicting property initializers for traits.
# Bug was uncovered by discussion in http://news.php.net/php.internals/54129
#
gron Sat, 23 Jul 2011 13:42:58 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313630
Log:
Added test case which was only added to trunk, bug seems to be fixed already.
Changed paths:
A php/php-src/branches/PHP_5_4/Zend/tests/traits/bug5
gron Fri, 13 May 2011 20:28:34 +
Revision: http://svn.php.net/viewvc?view=revision&revision=310999
Log:
Fixed a inconsitent condition for aliasing traits.
- missed a failing Traits test, but is now fixed, and the bug covered by a
dedicated test
# Should a
gron Sun, 09 Jan 2011 19:57:41 +
Revision: http://svn.php.net/viewvc?view=revision&revision=307307
Log:
Added trait_exists() [TRAITS] [DOC]
- also changed class_exists() to return false for traits
- added related tests, and get_declared_traits() tests in e
gron Mon, 20 Dec 2010 08:49:59 +
Revision: http://svn.php.net/viewvc?view=revision&revision=306489
Log:
Removed dead code.
# should not have been commited in the first place.
Changed paths:
U php/php-src/trunk/Zend/zend_compile.c
Modified: php/php-s
gron Mon, 20 Dec 2010 00:52:40 +
Revision: http://svn.php.net/viewvc?view=revision&revision=306476
Log:
Added strict handling of properties in traits.
# This is the first attempt to implement the properties as discussed on the
mailinglist.
# RFC is not upd
gron Sun, 19 Dec 2010 22:13:41 +
Revision: http://svn.php.net/viewvc?view=revision&revision=306467
Log:
Fixed naming of parameters, was inconsistent with implementation.
Changed paths:
U php/php-src/trunk/Zend/zend_compile.h
Modified: php/php-src/tr
gron Sun, 12 Dec 2010 17:12:29 +
Revision: http://svn.php.net/viewvc?view=revision&revision=306272
Log:
Changed E_ERROR to E_COMPILE_ERROR for Trait compilation errors.
#Thanks for catching this Kalle.
Changed paths:
U php/php-src/trunk/Zend/zend_com
gron Sun, 12 Dec 2010 16:48:02 +
Revision: http://svn.php.net/viewvc?view=revision&revision=306267
Log:
Changed collision warning for Traits to fatal error.
#This change is made to have all possible cases of collisions consistently
handled as fatal errors.
gron Wed, 01 Dec 2010 15:20:11 +
Revision: http://svn.php.net/viewvc?view=revision&revision=305890
Log:
Removed old commented function prototypes.
# Was referring to old trait-related code that is long gone
Changed paths:
U php/php-src/trunk/Zend/zen
gron Thu, 18 Nov 2010 17:59:04 +
Revision: http://svn.php.net/viewvc?view=revision&revision=305512
Log:
Fixed problem reported by Patrick ALLAERT. Trait method was not applied
properly when fully qualified.
Changed paths:
A php/php-src/trunk/Zend/te
gron Wed, 17 Nov 2010 23:05:20 +
Revision: http://svn.php.net/viewvc?view=revision&revision=305473
Log:
Added tests to for static support of traits.
# This was not tested and documented yet.
# Updated documentation in the RFC http://wiki.php.net/rfc/horizon
gron Sun, 01 Aug 2010 20:53:32 +
Revision: http://svn.php.net/viewvc?view=revision&revision=301768
Log:
Added Traits to the NEWS file.
#There doesn't seem to be a consitent ordering,
#so I put it in front of the list, since it is a major language addition.
gron Tue, 08 Jun 2010 15:56:36 +
Revision: http://svn.php.net/viewvc?view=revision&revision=300283
Log:
Fixed issue with statics in traits.
#Please review this change, I moved the routine which copies statics from the
closure code to zend_variables.c
#Plea
gron Mon, 03 May 2010 22:08:09 +
Revision: http://svn.php.net/viewvc?view=revision&revision=298935
Log:
Changed naming of traits-related helper functions (suggested by Derick), added
missing static qualifiers.
Changed paths:
U php/php-src/trunk/Zend
/xdebug.org/donate.php
> twitter: @derickr and @xdebug
--
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2 629 2974
Fax: +32 2 629 3525
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
gron Sun, 02 May 2010 16:32:25 +
Revision: http://svn.php.net/viewvc?view=revision&revision=298877
Log:
Refactored part of the Traits implementation.
# - renamed php_runkit_function_copy_ctor to _duplicate_function
# REM: runkit does not compile with trun
not C89 compatible and
> should be /* */ instead.
Thanks to Felipe that seems to be already fixed :)
Thanks
Stefan
--
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2 629 2974
Fax: +32 2 629
gron Thu, 22 Apr 2010 21:56:55 +
Revision: http://svn.php.net/viewvc?view=revision&revision=298347
Log:
Changed the exclusion keyword from 'instead' to 'insteadof'. [TRAITS]
#That was suggested several times already, but am still not sure whether that
real
gron Thu, 15 Apr 2010 21:39:20 +
Revision: http://svn.php.net/viewvc?view=revision&revision=298062
Log:
Added traits test cases. No engine changes for now. [TRAITS]
#Getting accustomed to the infrastructure.
#Any comments are welcome, especially with regar
55 matches
Mail list logo
