Re: [PHP-CVS] com php-src: Avoid trailing line break: ext/opcache/zend_accelerator_module.c

2013-03-19 Thread Dmitry Stogov
On Mon, Mar 18, 2013 at 9:51 PM, Andrey Hristov wrote: > On 03/18/2013 02:40 PM, Dmitry Stogov wrote: > >> Hi Andrey, >> >> I don't think it makes a lot of sense to make it in only this particular >> place. >> We use "int" in thousands other places (near everywhere across PHP >> sources). >> > >

Re: [PHP-CVS] com php-src: Avoid trailing line break: ext/opcache/zend_accelerator_module.c

2013-03-18 Thread Andrey Hristov
On 03/18/2013 02:40 PM, Dmitry Stogov wrote: Hi Andrey, I don't think it makes a lot of sense to make it in only this particular place. We use "int" in thousands other places (near everywhere across PHP sources). "A journey of a thousand miles begins with a single step" Lau-Tzu :) Thanks. Dm

Re: [PHP-CVS] com php-src: Avoid trailing line break: ext/opcache/zend_accelerator_module.c

2013-03-18 Thread Pierre Joye
hi Dmitry, On Mon, Mar 18, 2013 at 2:40 PM, Dmitry Stogov wrote: > Hi Andrey, > > I don't think it makes a lot of sense to make it in only this particular > place. > We use "int" in thousands other places (near everywhere across PHP sources). Well it makes sense and as this code is new, why not

Re: [PHP-CVS] com php-src: Avoid trailing line break: ext/opcache/zend_accelerator_module.c

2013-03-18 Thread Dmitry Stogov
Hi Andrey, I don't think it makes a lot of sense to make it in only this particular place. We use "int" in thousands other places (near everywhere across PHP sources). Thanks. Dmitry. On Mon, Mar 18, 2013 at 5:09 PM, Andrey Hristov wrote: > > could you use size_t instead of len? (strlen() retu

Re: [PHP-CVS] com php-src: Avoid trailing line break: ext/opcache/zend_accelerator_module.c

2013-03-18 Thread Andrey Hristov
On 03/18/2013 10:36 AM, Dmitry Stogov wrote: Commit:5b0879e7c969e0bd87b0ad6fad03e278a0a46642 Author:Dmitry Stogov Mon, 18 Mar 2013 13:36:31 +0400 Parents: a9684532ebda83e2459da4f6f450a37f4ee6ff7b Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commi

[PHP-CVS] com php-src: Avoid trailing line break: ext/opcache/zend_accelerator_module.c

2013-03-18 Thread Dmitry Stogov
Commit:5b0879e7c969e0bd87b0ad6fad03e278a0a46642 Author:Dmitry Stogov Mon, 18 Mar 2013 13:36:31 +0400 Parents: a9684532ebda83e2459da4f6f450a37f4ee6ff7b Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5b0879e7c969e0bd87b0ad6fad03e278a0a4664