Re: [PHP-CVS] com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt ext/date/tests/bug62852_var3.phpt

2013-03-20 Thread Anatol Belski
Stas, The issue is that a warning wouldn't destroy that object. That object will occasionally segfault PHP. E_ERROR is the simplest solution which doesn't change the behavior of the normal operations. There is another one bug #53437. The patch there has E_ERROR as well, but for the same reason.

Re: [PHP-CVS] com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt ext/date/tests/bug62852_var3.phpt

2013-03-20 Thread Stas Malyshev
Hi! The issue is that a warning wouldn't destroy that object. That object will occasionally segfault PHP. E_ERROR is the simplest solution which doesn't change the behavior of the normal operations. Can't we just reset the object data to some known zero state? Having E_ERROR in a function

Re: [PHP-CVS] com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt ext/date/tests/bug62852_var3.phpt

2013-03-20 Thread Anatol Belski
On Wed, March 20, 2013 09:05, Stas Malyshev wrote: Hi! The issue is that a warning wouldn't destroy that object. That object will occasionally segfault PHP. E_ERROR is the simplest solution which doesn't change the behavior of the normal operations. Can't we just reset the object data to

[PHP-CVS] com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt ext/date/tests/bug62852_var3.phpt

2013-03-19 Thread Anatol Belski
Commit:8d199c7c4f93ebe5b9293096143d7007a6ad13a4 Author:Anatol Belski a...@php.net Tue, 19 Mar 2013 21:19:55 +0100 Parents: 4a6291508d69fab951562b996ed7223c052a0168 Branches: PHP-5.3 PHP-5.4 PHP-5.5 master Link:

Re: [PHP-CVS] com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt ext/date/tests/bug62852_var3.phpt

2013-03-19 Thread Stas Malyshev
Hi! + if (!php_date_initialize_from_hash(return_value, dateobj, myht TSRMLS_CC)) { + php_error(E_ERROR, Invalid serialization data for DateTime object); + } Why this is E_ERROR? Can't we recover from this problem? Bad serialization data is E_NOTICE for unserialize(),