Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Stas Malyshev
Hi! > I checked with Stas and he said ok for 5.4. Looks like there's a disagreement about this one and whether it should be in hash or openssl, so I'll revert this for now from 5.4 and after we discuss it on internals and decide where we want it, we'll decide where it goes. Sorry for misunderstan

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Pierre Joye
On Tue, Jun 12, 2012 at 4:50 PM, Scott MacVicar wrote: > I checked with Stas and he said ok for 5.4. Make it public next time. RFC says no new feature but very very small ones. RMs apply this rule. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Scott MacVicar
I checked with Stas and he said ok for 5.4. On 12 Jun 2012, at 06:08, David Soria Parra wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Stas did you ACK that change? It seems rather intrusive and I am not > sure if we want that in a minor version just 24 h before releasing. > can w

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stas did you ACK that change? It seems rather intrusive and I am not sure if we want that in a minor version just 24 h before releasing. can we solve that before tagging 5.4.4? thx > On Tue, Jun 12, 2012 at 1:04 AM, Scott MacVicar > wrote: >> Commit

Re: [PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-12 Thread Pierre Joye
hi, This is a new feature, what does it do in 5.4? Also it was clearly not tested (did not build with < 1.0.0 f.e.). I am totally not in favour of having that in 5.4 yet, even if it looks non intrusive. The overall stability and reliability is a key, not only specific functions. Cheers, On Tue,

[PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-11 Thread Scott MacVicar
Commit:bcd671d999bcb9aac3691c59e632d91575ea87a0 Author:Scott MacVicar Mon, 11 Jun 2012 16:04:01 -0700 Parents: aadf59dfa4be09147671de33786dc157716705df bccd1e672fabc3c788e93075221d47d9f077b167 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=bcd6

[PHP-CVS] com php-src: Merge branch '5.4': ext/openssl/openssl.c

2012-06-11 Thread Scott MacVicar
Commit:32040b574e7b456ca7b03918adaabfec4bbd91e2 Author:Scott MacVicar Mon, 11 Jun 2012 00:29:02 -0700 Parents: 2065bab102d2117340d5b604f0ac55941c78ced8 f4847efc5d58b3375fa0f3269158d5e6ab625c21 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=3204