Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-03 Thread Kalle Sommer Nielsen
2009/6/3 Jani Taskinen : > Kalle Sommer Nielsen kirjoitti: >> >> 2009/6/3 Hannes Magnusson : >>> >>> On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen wrote: kalle           Wed Jun  3 01:19:33 2009 UTC  Modified files:              (Branch: PHP_5_3)   /php-src/ext/bcmath

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-03 Thread Pierre Joye
On Wed, Jun 3, 2009 at 2:06 PM, Jani Taskinen wrote: >> Its broken for me, if its an issue for others then we need to isolate >> it, if i do a fresh nmake and then make a buildconf && configure && >> nmake (after i have made a change), it breaks the build because >> config.h isn't in ext/bcmath,

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-03 Thread Jani Taskinen
Kalle Sommer Nielsen kirjoitti: 2009/6/3 Hannes Magnusson : On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen wrote: kalle Wed Jun 3 01:19:33 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: MFH: config.h is in this di

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-03 Thread Kalle Sommer Nielsen
2009/6/3 Hannes Magnusson : > On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen wrote: >> kalle           Wed Jun  3 01:19:33 2009 UTC >> >>  Modified files:              (Branch: PHP_5_3) >>    /php-src/ext/bcmath/libbcmath/src   bcmath.h >>  Log: >>  MFH: config.h is in this directory, not in e

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-03 Thread Hannes Magnusson
On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen wrote: > kalle           Wed Jun  3 01:19:33 2009 UTC > >  Modified files:              (Branch: PHP_5_3) >    /php-src/ext/bcmath/libbcmath/src   bcmath.h >  Log: >  MFH: config.h is in this directory, not in ext/bcmath root, fixes > re-compilat

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-02 Thread Kalle Sommer Nielsen
kalle Wed Jun 3 01:19:33 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: MFH: config.h is in this directory, not in ext/bcmath root, fixes re-compilation for me http://cvs.php.net/viewvc.cgi/php-src/ext/bcmath/libb

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Marcus Boerger
Hello Jani, hu? First there was the clean and the fix would have been to clean the correct file. Though the fix you did was fine as well. All I did was reminding about the clean section. Second, and that was the only other thing I commented on, was this one. And, well, ignore my ignorance, but b

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Jani Taskinen
You don't really need to comment about everything, do you? Please get your facts correct first. --Jani Marcus Boerger [EMAIL PROTECTED] kirjoitti: Hello Jani, the real fix actually is to drop all #include config.h, because php needs to have php_config.h and not config.h as first file. mar

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Jani Taskinen
No, I revert bad fixes that break something that worked before and are inherently totally bogus to begin with. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:37 PM, Jani Taskinen <[EMAIL PROTECTED]> wrote: > Not enough info -> bogus. > > FYI: Just tested to be sure.

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Marcus Boerger
Hello Jani, the real fix actually is to drop all #include config.h, because php needs to have php_config.h and not config.h as first file. marcus Friday, August 15, 2008, 6:37:24 PM, you wrote: > Not enough info -> bogus. > FYI: Just tested to be sure. Doing phpize build now fails. Works whe

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Pierre Joye
On Fri, Aug 15, 2008 at 6:37 PM, Jani Taskinen <[EMAIL PROTECTED]> wrote: > Not enough info -> bogus. > > FYI: Just tested to be sure. Doing phpize build now fails. Works when > reverted. (reverted btw..) > > I say again: Fix the REAL bugs, not symptoms of the real bugs.. Wait, you revert a fix be

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Jani Taskinen
Not enough info -> bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen <[EMAI

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Jani Taskinen
janiFri Aug 15 16:36:39 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: - Revert wrong fix http://cvs.php.net/viewvc.cgi/php-src/ext/bcmath/libbcmath/src/bcmath.h?r1=1.9.6.2.2.1&r2=1.9.6.2.2.2&diff_format=u Index:

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Pierre Joye
On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen <[EMAIL PROTECTED]> wrote: > Pierre Joye [EMAIL PROTECTED] kirjoitti: >> >> On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen <[EMAIL PROTECTED]> >> wrote: >> > Can you count to 2 ?? It's easy: 1, 2. >> > Now, count how many levels it's to where the confi

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Jani Taskinen
Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen <[EMAIL PROTECTED]> wrote: > Can you count to 2 ?? It's easy: 1, 2. > Now, count how many levels it's to where the config.h would be if you do a > phpize build: Sorry, I can't count to 2 :) Should it not be

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Pierre Joye
On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen <[EMAIL PROTECTED]> wrote: > Can you count to 2 ?? It's easy: 1, 2. > Now, count how many levels it's to where the config.h would be if you do a > phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? > ext/bcmath/libbcmath/src

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Jani Taskinen
Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. --Jani Pierre-Alain Joye [EMAIL PROTECTED] kirjoitti: pajoye Fri Aug 15 15:3

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2008-08-15 Thread Pierre-Alain Joye
pajoye Fri Aug 15 15:39:18 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: - MFH: no config.h in ext/ http://cvs.php.net/viewvc.cgi/php-src/ext/bcmath/libbcmath/src/bcmath.h?r1=1.9.6.2&r2=1.9.6.2.2.1&diff_format=u Ind