[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c

2009-06-16 Thread Andrey Hristov
andrey Tue Jun 16 07:53:35 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlndmysqlnd_palloc.c Log: MFH: Use Zend's allocator instead of libc's and also don't try to work on zvals that are NULLs.

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote: On 08.06.2009, at

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Andrey Hristov
Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, Check with your eyes, the compiler is wrong. obj is touched only if

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Andrey Hristov
Hi Lukas, On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote: On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristovandrey.hris...@sun.com wrote:  Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
On Thu, Jun 11, 2009 at 7:42 PM, Andrey Hristovp...@hristov.com wrote: no :) Why not? it is clearly pointless when ZVAL_CACHE is not set. But you can send the case to your colleagues at the compiler team so they can analyze why the compiler failed to recognize it :) already sent :) I

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Andrey Hristov
Hi Pierre, Pierre Joye wrote: hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristovandrey.hris...@sun.com wrote: Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-08 Thread Andrey Hristov
andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlndmysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to the branch. Also switch off the zval

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-08 Thread Lukas Kahwe Smith
On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_ps_codec.c mysqlnd_result.c

2009-05-28 Thread Andrey Hristov
andrey Thu May 28 16:35:42 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlndmysqlnd_palloc.c mysqlnd_ps.c mysqlnd_ps_codec.c mysqlnd_result.c Log: MFH:Fix a problem with cursors, which did not happen with

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c

2008-06-24 Thread Andrey Hristov
andrey Tue Jun 24 06:56:36 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlndmysqlnd_palloc.c Log: Even more debug info http://cvs.php.net/viewvc.cgi/php-src/ext/mysqlnd/mysqlnd_palloc.c?r1=1.2.2.8r2=1.2.2.9diff_format=u Index:

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c

2008-06-23 Thread Andrey Hristov
andrey Mon Jun 23 22:21:18 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlndmysqlnd_palloc.c Log: Added more debug info for tracking problems