Hey, hey, what are you doing?
I assume you're reading the
http://gcov.php.net/viewer.php?version=PHP_5_3&func=params page. That script
is very dumb and unfortunately shows many false positives. I did a cursory
review of your commits and most of the changes you did aren't necessary (in
fact they can degrade the performance).
This year I was hoping to get a student from the GSoC project to improve
this analyzer, but I didn't. Let's hope next year we can get one :P (if
someone is interested please contact me!)
In the mean time, please don't assume that script is 100% right. Please
always look to the code first to check if the initialization is really
needed.
Thanks,
Nuno
----- Original Message -----
From: "Arnaud Le Blanc" <[EMAIL PROTECTED]>
To: <php-cvs@lists.php.net>
Sent: Tuesday, October 21, 2008 11:08 PM
Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c assert.c
basic_functions.c browscap.c crypt.c file.c filestat.c head.c html.c http.c
info.c mail.c math.c proc_open.c rand.c streamsfuncs.c string.c type.c
versioning.c
lbarnaud Tue Oct 21 22:08:39 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard array.c assert.c basic_functions.c browscap.c
crypt.c file.c filestat.c head.c html.c
http.c info.c mail.c math.c proc_open.c
rand.c streamsfuncs.c string.c type.c
versioning.c
Log:
MFH: initialize optional vars
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
