Andi,
Sorry about that, I haven't been paying much attention to the
internals@ list, I'll make sure I check the list before committing
next time. I have #if BRAD_0'd the code, and will remove those
#if's after 5.1.0 release.
-Brad
Andi Gutmans wrote:
> Brad,
>
> In any case, we are in a compl
bradmsswMon Jul 18 20:34:39 2005 EDT
Modified files:
/php-src/ext/mcve mcve.c php_mcve.h
Log:
\#if BRAD_0'd latest changes as requested until 5.1.0 release
http://cvs.php.net/diff.php/php-src/ext/mcve/mcve.c?r1=1.33&r2=1.34&ty=u
Index: php-src/ext/mcve
Brad,
In any case, we are in a complete feature freeze right now. I sent an email
about this to [EMAIL PROTECTED] Only bug fixes allowed. Please #if BRAD_0 that
code in HEAD. I don't see a problem allowing the addition of such simple
wrapper functions after 5.1.0 goes out the door; but I don'
Maybe it's time to move ext/mcve to PECL, where you can safely add new
functions just before new PHP release?
On Mon, 18 Jul 2005 20:10:09 -
"Brad House" <[EMAIL PROTECTED]> wrote:
> bradmssw Mon Jul 18 16:10:09 2005 EDT
>
> Modified files:
> /php-src/ext/m
bradmsswMon Jul 18 16:10:09 2005 EDT
Modified files:
/php-src/ext/mcve mcve.c php_mcve.h
Log:
sync missing functions from libmonetra-5
http://cvs.php.net/diff.php/php-src/ext/mcve/mcve.c?r1=1.32&r2=1.33&ty=u
Index: php-src/ext/mcve/mcve.c
diff -u php-s
Perhaps. There was discussion once upon a time along those lines,
but nothing else came of it. I'd have to know what it entails,
and if it would prohibit the extension from being distributed
with the main PHP codebase. Forgive my ignorance, but I have
not even looked into what PECL really is.
-
Well, comparitively speaking, to the whole of the PHP audience,
there probably aren't that many people using the ext/mcve extension
for PHP, but there are a few hundred, anyhow.
I'll look into PECL though to see if it is a suitable fit...
-Brad
Antony Dovgal wrote:
> On Mon, 18 Jul 2005 16:34:
On Mon, 18 Jul 2005 16:34:44 -0400
Brad House <[EMAIL PROTECTED]> wrote:
> Perhaps. There was discussion once upon a time along those lines,
> but nothing else came of it. I'd have to know what it entails,
> and if it would prohibit the extension from being distributed
> with the main PHP codeba
Hi Jani Taskinen, you wrote:
>
>Excuse me, but what's the point with this change:
>
> - RETVAL_STRING(retval, 1);
> + RETVAL_STRING(estrdup(retval), 0);
>
>The second parameter '1' will duplicate the value?
If I do this, then usually because it gives a warning
Excuse me, but what's the point with this change:
- RETVAL_STRING(retval, 1);
+ RETVAL_STRING(estrdup(retval), 0);
The second parameter '1' will duplicate the value?
--Jani
On Mon, 6 Jun 2005, Brad House wrote:
bradmsswMon Jun 6 12:43:2
bradmsswMon Jun 6 12:43:23 2005 EDT
Modified files:
/php-src/ext/mcve mcve.c php_mcve.h
Log:
libmonetra-5.0 sync.
added m_validateidentifier, which is enabled by default to keep invalid
pointer addresses from causing PHP to crash
kept compatability
bradmsswSun May 30 18:41:14 2004 EDT
Modified files:
/php-src/ext/mcve mcve.c php_mcve.h
Log:
Update the mcve module for libmonetra 4.0
A compatability layer has been introduced which should mean all
scripts written for v 3.2 of the module should con
bradmsswMon Jul 7 22:59:50 2003 EDT
Modified files:
/php-src/ext/mcve mcve.c php_mcve.h
Log:
sync functionality with libmcve 3.2
Index: php-src/ext/mcve/mcve.c
diff -u php-src/ext/mcve/mcve.c:1.19 php-src/ext/mcve/mcve.c:1.20
--- php-src/ext/mcve/mcve.
13 matches
Mail list logo
