Re: [PHP-CVS] cvs: php4 /ext/pcre/tests bug21732.phpt

2003-01-23 Thread Moriyoshi Koizumi
On Thu, Jan 23, 2003 at 01:52:23PM -0500, Ilia A. wrote: > The test for availability of PCRE should be removed IMO simply because without > PCRE test suit will exit before starting any of the tests. The dependency on > PCRE is unlikely to be removed, so this should be a safe thing to do. I misto

Re: [PHP-CVS] cvs: php4 /ext/pcre/tests bug21732.phpt

2003-01-23 Thread Ilia A.
On January 23, 2003 01:54 pm, you wrote: > > > > > extension_loaded("pcre") or die("skip pcre extension is not > > > available"); ?> > > > > This check is pointless, since without pcre the testsuit won't run. > > Right, I just followed the way in which other tests are written. > Should we remove t

Re: [PHP-CVS] cvs: php4 /ext/pcre/tests bug21732.phpt

2003-01-23 Thread Moriyoshi Koizumi
On Thu, Jan 23, 2003 at 01:36:23PM -0500, Ilia A. wrote: > On January 23, 2003 01:22 pm, Moriyoshi Koizumi wrote: > > moriyoshi Thu Jan 23 13:22:56 2003 EDT > > > > Added test case for bug #21732 > [snip] > > --SKIPIF-- > > > extension_loaded("pcre") or die("skip pcre extension is not

Re: [PHP-CVS] cvs: php4 /ext/pcre/tests bug21732.phpt

2003-01-23 Thread Ilia A.
On January 23, 2003 01:22 pm, Moriyoshi Koizumi wrote: > moriyoshi Thu Jan 23 13:22:56 2003 EDT > > Added test case for bug #21732 [snip] > --SKIPIF-- > extension_loaded("pcre") or die("skip pcre extension is not available"); > ?> This check is pointless, since without pcre the test

[PHP-CVS] cvs: php4 /ext/pcre/tests bug21732.phpt

2003-01-23 Thread Moriyoshi Koizumi
moriyoshi Thu Jan 23 13:22:56 2003 EDT Added files: /php4/ext/pcre/testsbug21732.phpt Log: Added test case for bug #21732 Index: php4/ext/pcre/tests/bug21732.phpt +++ php4/ext/pcre/tests/bug21732.phpt --TEST-- Bug #21732 (preg_replace() segf