[PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h streams.c

2002-10-21 Thread Wez Furlong
wez Mon Oct 21 18:54:37 2002 EDT Modified files: /php4/ext/standard file.c /php4/main php_streams.h streams.c Log: Refine stream_select() to work with streams that have data in their read buffers. When selecting for read, the streams are examined; if

[PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h streams.c

2002-10-19 Thread Wez Furlong
wez Sat Oct 19 09:11:48 2002 EDT Modified files: /php4/main streams.c php_streams.h /php4/ext/standard file.c Log: made fgets() binary safe. php_stream_gets is now a macro which calls php_stream_get_line. The latter has an option argument to return t

Re: [PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h streams.c

2002-10-18 Thread Ilia A.
On October 18, 2002 04:40 pm, Rasmus Lerdorf wrote: > > Fixed bug #19971 (optimized the file() function). > > The file() function is now also binary safe. > > That's a bit misleading. By definition file() cannot be binary-safe in > that \n is treated specially. Not quite, in the old code (4.2

Re: [PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h streams.c

2002-10-18 Thread Ilia A.
On October 18, 2002 05:04 pm, Rasmus Lerdorf wrote: > > On October 18, 2002 04:40 pm, Rasmus Lerdorf wrote: > > > > Fixed bug #19971 (optimized the file() function). > > > > The file() function is now also binary safe. > > > > > > That's a bit misleading. By definition file() cannot be binary-

Re: [PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h streams.c

2002-10-18 Thread Ilia A.
On October 18, 2002 05:50 pm, Rasmus Lerdorf wrote: > > > My point is that the original data is munged once it goes through the > > > file() function. In that sense it is not binary safe as there is no > > > way to restore the original data. > > > > Unless the user actually goes and modifies the d

[PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h streams.c

2002-10-18 Thread Ilia Alshanetsky
iliaa Fri Oct 18 16:39:49 2002 EDT Modified files: /php4/main streams.c php_streams.h /php4/ext/standard file.c Log: Fixed bug #19971 (optimized the file() function). The file() function is now also binary safe. Index: php4/main/streams.c diff -u p