FW: [PHP-CVS] cvs: php4 /ext/standard proc_open.c /main php_variables.c

2003-03-24 Thread James Cox
> -Original Message- > From: Shane Caraveo [mailto:[EMAIL PROTECTED] > Sent: 24 March 2003 18:33 > To: Jani Taskinen > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c /main > php_variables.c > > > This changes behaviou

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c /main php_variables.c

2003-03-24 Thread Jani Taskinen
I guess it's better be broken in PHP 5. :) So forget the MFH.. --Jani On Mon, 24 Mar 2003, Shane Caraveo wrote: >This changes behaviour and could break BC if people have written >work-arounds into their scripts for this (ie removing slashes), which is >why I did not MFH.

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c /main php_variables.c

2003-03-24 Thread Shane Caraveo
This changes behaviour and could break BC if people have written work-arounds into their scripts for this (ie removing slashes), which is why I did not MFH. On the other hand, it is the correct behaviour, and in the vast majority of cases it will only be win32 that is effected. The primary rea

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c /main php_variables.c

2003-03-24 Thread Jani Taskinen
MFH? --Jani On Sun, 23 Mar 2003, Shane Caraveo wrote: >shane Sun Mar 23 14:30:31 2003 EDT > > Modified files: >/php4/main php_variables.c >/php4/ext/standard proc_open.c > Log: > The environment should *never* be magic quoted. > > >Inde

[PHP-CVS] cvs: php4 /ext/standard proc_open.c /main php_variables.c

2003-03-23 Thread Shane Caraveo
shane Sun Mar 23 14:30:31 2003 EDT Modified files: /php4/main php_variables.c /php4/ext/standard proc_open.c Log: The environment should *never* be magic quoted. Index: php4/main/php_variables.c diff -u php4/main/php_variables.c:1.55 php4/main/php_

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-17 Thread Wez Furlong
strlen(command) should not be needed either since zend_parse_parameters returns the length anyway. --Wez. On Mon, 17 Feb 2003, Shane Caraveo wrote: > shane Mon Feb 17 01:45:37 2003 EDT > > Modified files: > /php4/ext/standardproc_open.c > Log: > you know it's time to ge

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Derick Rethans
On Sun, 16 Feb 2003, Shane Caraveo wrote: > It was a messup beyond coding standards. Doh! Good night :-) Derick -- Stop mad cowboy disease! - Derick Rethans

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Shane Caraveo
It was a messup beyond coding standards. Derick Rethans wrote: On Mon, 17 Feb 2003, Shane Caraveo wrote: shane Sun Feb 16 22:26:16 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: If you pass NULL, you do not get a NULL value, make sure it is. - + + i

[PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Shane Caraveo
shane Mon Feb 17 01:45:37 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: you know it's time to get away from the keyboard when you do this. fix my last fix Index: php4/ext/standard/proc_open.c diff -u php4/ext/standard/proc_open.c:1.9 ph

Re: [PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Derick Rethans
On Mon, 17 Feb 2003, Shane Caraveo wrote: > shane Sun Feb 16 22:26:16 2003 EDT > > Modified files: > /php4/ext/standardproc_open.c > Log: > If you pass NULL, you do not get a NULL value, make sure it is. > - > + > + if (cwd_len==0) cwd = NULL

[PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Derick Rethans
derick Mon Feb 17 01:35:13 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: - Style polizei Index: php4/ext/standard/proc_open.c diff -u php4/ext/standard/proc_open.c:1.8 php4/ext/standard/proc_open.c:1.9 --- php4/ext/standard/proc_open.c:1.8

[PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Shane Caraveo
shane Mon Feb 17 00:47:56 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: fix it the right way Index: php4/ext/standard/proc_open.c diff -u php4/ext/standard/proc_open.c:1.7 php4/ext/standard/proc_open.c:1.8 --- php4/ext/standard/proc_open.c:1

[PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-16 Thread Shane Caraveo
shane Sun Feb 16 22:26:16 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: If you pass NULL, you do not get a NULL value, make sure it is. Index: php4/ext/standard/proc_open.c diff -u php4/ext/standard/proc_open.c:1.6 php4/ext/standard/proc_ope

[PHP-CVS] cvs: php4 /ext/standard proc_open.c proc_open.h

2003-02-16 Thread Wez Furlong
wez Sun Feb 16 10:38:54 2003 EDT Modified files: /php4/ext/standard proc_open.c proc_open.h Log: Integrate Shanes patch that allows specifying the cwd and environment for the child process created by proc_open(). Index: php4/ext/standard/proc_open.c di

[PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-02-15 Thread Wez Furlong
wez Sat Feb 15 12:33:11 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: Add optional signal parameter to proc_terminate. Index: php4/ext/standard/proc_open.c diff -u php4/ext/standard/proc_open.c:1.4 php4/ext/standard/proc_open.c:1.5 --- php

[PHP-CVS] cvs: php4 /ext/standard proc_open.c

2003-01-24 Thread Ilia Alshanetsky
iliaa Fri Jan 24 11:45:34 2003 EDT Modified files: /php4/ext/standard proc_open.c Log: Fixed compile warning. Index: php4/ext/standard/proc_open.c diff -u php4/ext/standard/proc_open.c:1.2 php4/ext/standard/proc_open.c:1.3 --- php4/ext/standard/proc_open.c