[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-27 Thread Jani Taskinen
sniper Thu Mar 27 08:16:18 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: CS fix Index: php4/sapi/apache2handler/sapi_apache2.c diff -u php4/sapi/apache2handler/sapi_apache2.c:1.11 php4/sapi/apache2handler/sapi_apache2.c:1.12 --- php4

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-27 Thread Ilia A.
Please MFH this & previous fix to the PHP_4_3 branch. Ilia On March 27, 2003 12:31 am, Ian Holsman wrote: > ianh Thu Mar 27 00:31:49 2003 EDT > > Modified files: > /php4/sapi/apache2handler sapi_apache2.c > Log: > change to a pool-based bucket instead of a transient one. > > >

[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-26 Thread Ian Holsman
ianhThu Mar 27 00:31:49 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: change to a pool-based bucket instead of a transient one. Index: php4/sapi/apache2handler/sapi_apache2.c diff -u php4/sapi/apache2handler/sapi_apache2.c:1.10

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-26 Thread Ian Holsman
this is what I'll be replacing it with. (which was in rev 1.1) char* copy_str; copy_str = apr_pmemdup( ctx->r->pool, str, str_length+1); bucket = apr_bucket_pool_create(copy_str, str_length, ctx->r->pool, ctx->c->bucket_alloc); I'll just to a quick check and then

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-26 Thread Ian Holsman
no.. probably not the best thing to do, especially if the parent function deallocates the memory beneath us. I'll have to change it to a pool bucket to be safe. Moriyoshi Koizumi wrote: Just curious, but can we append transient buckets here? Moriyoshi "Ian Holsman" <[EMAIL PROTECTED]> wrote: ia

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-26 Thread Moriyoshi Koizumi
Just curious, but can we append transient buckets here? Moriyoshi "Ian Holsman" <[EMAIL PROTECTED]> wrote: > ianh Wed Mar 26 23:35:44 2003 EDT > > Modified files: > /php4/sapi/apache2handler sapi_apache2.c > Log: > remove flush from standard unbuffered write. >

[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-26 Thread Ian Holsman
ianhWed Mar 26 23:35:44 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: remove flush from standard unbuffered write. people requiring a flush can turn implicit flush on. Thanks ilia for benchmarking this! Index: php4/sapi/apac

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-25 Thread Ilia A.
On March 25, 2003 08:39 am, Moriyoshi Koizumi wrote: > Hmm..? my patch has not been committed yet, that was only in the list > archives. Although I don't see no problem with your fix, I think you'd > be better off asking the assignee how your patch is before the commit. Hmm... I must've missed you

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-25 Thread Moriyoshi Koizumi
"Ilia A." <[EMAIL PROTECTED]> wrote: > On March 25, 2003 03:40 am, Moriyoshi Koizumi wrote: > > Why did you commit another fix though my patch was already there and maybe > > Ian was looking into this issue? :) > > Because the existing patch (latest CVS) did not work, when posting 30k or more >

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-25 Thread Ilia A.
On March 25, 2003 03:40 am, Moriyoshi Koizumi wrote: > Why did you commit another fix though my patch was already there and maybe > Ian was looking into this issue? :) Because the existing patch (latest CVS) did not work, when posting 30k or more data it would usually stop after 7.8k or so. The r

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-25 Thread Moriyoshi Koizumi
Why did you commit another fix though my patch was already there and maybe Ian was looking into this issue? :) "Ilia Alshanetsky" <[EMAIL PROTECTED]> wrote: > + if (tlen == count_bytes || !len) { > + break; > + } Is this ok? I suppose tlen would't alw

[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-24 Thread Ilia Alshanetsky
iliaa Mon Mar 24 20:34:32 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: Fixed bug #22805 (Reading of user input could stop prematurely). Index: php4/sapi/apache2handler/sapi_apache2.c diff -u php4/sapi/apache2handler/sapi_apache2.

Re: [PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-18 Thread Derick Rethans
On Mon, 17 Mar 2003, Ian Holsman wrote: > ianh Mon Mar 17 16:28:41 2003 EDT > > Modified files: > /php4/sapi/apache2handler sapi_apache2.c > Log: > PR#22672 - User not logged under Apache2 > patch provided by Andrew Bradford. > > -/* $Id: sapi_apache2.c,v

[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-17 Thread Jani Taskinen
sniper Mon Mar 17 20:24:19 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: whitespace.. Index: php4/sapi/apache2handler/sapi_apache2.c diff -u php4/sapi/apache2handler/sapi_apache2.c:1.6 php4/sapi/apache2handler/sapi_apache2.c:1.7 ---

[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-03-17 Thread Ian Holsman
ianhMon Mar 17 16:28:41 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: PR#22672 - User not logged under Apache2 patch provided by Andrew Bradford. Index: php4/sapi/apache2handler/sapi_apache2.c diff -u php4/sapi/apache2han

[PHP-CVS] cvs: php4 /sapi/apache2handler sapi_apache2.c

2003-02-21 Thread Justin Erenkrantz
jerenkrantz Fri Feb 21 23:42:34 2003 EDT Modified files: /php4/sapi/apache2handler sapi_apache2.c Log: Add xbithack support to apache2handler SAPI. (configuration doesn't work, but that's not something new apparently.) Index: php4/sapi/apache2handl