uw                                       Mon, 30 Aug 2010 09:20:48 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=302882

Log:
If you add functions to the PDO core, take care not to break other PDO drivers 
tests, document the function and provide a function test for the PDO core to 
check your default/fallback implementation.

Changed paths:
    U   
php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_interface.phpt
    U   php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_interface.phpt

Modified: 
php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_interface.phpt
===================================================================
--- php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_interface.phpt   
2010-08-30 07:21:28 UTC (rev 302881)
+++ php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_interface.phpt   
2010-08-30 09:20:48 UTC (rev 302882)
@@ -14,20 +14,21 @@
        $db = MySQLPDOTest::factory();

        $expected = array(
-               '__construct'                                   => true,
-               'prepare'                                               => true,
-               'beginTransaction'              => true,
+               '__construct'                                                   
=> true,
+               'prepare'                                                       
=> true,
+               'beginTransaction'                                              
=> true,
                'commit'                                                        
=> true,
-               'rollBack'                                              => true,
-               'setAttribute'                          => true,
+               'rollBack'                                                      
=> true,
+               'setAttribute'                                                  
=> true,
                'exec'                                                          
=> true,
                'query'                                                         
=> true,
-               'lastInsertId'                          => true,
-               'errorCode'                                             => true,
-               'errorInfo'                                             => true,
-               'getAttribute'                          => true,
+               'lastInsertId'                                                  
=> true,
+               'errorCode'                                                     
=> true,
+               'errorInfo'                                                     
=> true,
+               'getAttribute'                                                  
=> true,
                'quote'                                                         
=> true,
-               '__wakeup'                                              => true,
+               'inTransaction'                                                 
=> true,
+               '__wakeup'                                                      
=> true,
                '__sleep'                                                       
=> true,
                'getAvailableDrivers'   => true,
        );
@@ -55,4 +56,4 @@

        print "done!";
 --EXPECT--
-done!
\ No newline at end of file
+done!

Modified: php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_interface.phpt
===================================================================
--- php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_interface.phpt      
2010-08-30 07:21:28 UTC (rev 302881)
+++ php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_interface.phpt      
2010-08-30 09:20:48 UTC (rev 302882)
@@ -14,20 +14,21 @@
        $db = MySQLPDOTest::factory();

        $expected = array(
-               '__construct'                                   => true,
-               'prepare'                                               => true,
-               'beginTransaction'              => true,
+               '__construct'                                                   
=> true,
+               'prepare'                                                       
=> true,
+               'beginTransaction'                                              
=> true,
                'commit'                                                        
=> true,
-               'rollBack'                                              => true,
-               'setAttribute'                          => true,
+               'rollBack'                                                      
=> true,
+               'setAttribute'                                                  
=> true,
                'exec'                                                          
=> true,
                'query'                                                         
=> true,
-               'lastInsertId'                          => true,
-               'errorCode'                                             => true,
-               'errorInfo'                                             => true,
-               'getAttribute'                          => true,
+               'lastInsertId'                                                  
=> true,
+               'errorCode'                                                     
=> true,
+               'errorInfo'                                                     
=> true,
+               'getAttribute'                                                  
=> true,
                'quote'                                                         
=> true,
-               '__wakeup'                                              => true,
+               'inTransaction'                                                 
=> true,
+               '__wakeup'                                                      
=> true,
                '__sleep'                                                       
=> true,
                'getAvailableDrivers'   => true,
        );
@@ -55,4 +56,4 @@

        print "done!";
 --EXPECT--
-done!
\ No newline at end of file
+done!

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to