Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2009-04-14 Thread Dmitry Stogov
Hi Stas, This fix is incorrect. Now all 5.3 tests are failed for me because of memory leaks. The problem that php_sapi_filter() might be called from php_hash_environment() before RINIT() and your patch just overwrites properly initialized data. For some reason php_sapi_filter() isn't called

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-12-07 Thread Ilia Alshanetsky
Tony, This patch is incorrect, please revert it, the filter does not always get data through php_register_variable_ex(), so it does need to add slashes in some instances. On 7-Dec-06, at 5:59 AM, Antony Dovgal wrote: tony2001Thu Dec 7 10:59:35 2006 UTC Modified files:

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-09-14 Thread Antony Dovgal
On 12.09.2006 16:57, Derick Rethans wrote: On Thu, 31 Aug 2006, Antony Dovgal wrote: tony2001Thu Aug 31 22:11:35 2006 UTC Modified files: /php-src/ext/filter filter.c Log: change filters to operate on the copy of data, so multiple filters an be

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-09-12 Thread Derick Rethans
On Thu, 31 Aug 2006, Antony Dovgal wrote: tony2001 Thu Aug 31 22:11:35 2006 UTC Modified files: /php-src/ext/filter filter.c Log: change filters to operate on the copy of data, so multiple filters an be applied one after another It was this

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-09-12 Thread Antony Dovgal
On 12.09.2006 16:57, Derick Rethans wrote: On Thu, 31 Aug 2006, Antony Dovgal wrote: tony2001Thu Aug 31 22:11:35 2006 UTC Modified files: /php-src/ext/filter filter.c Log: change filters to operate on the copy of data, so multiple filters an be

RE: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Dmitry Stogov
The patch breaks HEAD. I cannot compile PHP. Dmitry. -Original Message- From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] Sent: Thursday, July 27, 2006 10:15 PM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src /ext/filter filter.c iliaa Thu Jul 27 18:15:10

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Pierre
On 7/28/06, Dmitry Stogov [EMAIL PROTECTED] wrote: The patch breaks HEAD. I cannot compile PHP. It should be ifdef'ed. HEAD does not have magic quotes support. I will commit the change asap. --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Derick Rethans
On Thu, 27 Jul 2006, Ilia Alshanetsky wrote: Well, that's great, but it should not prevent magic quotes from being applied. Until magic quotes is removed it should work, as the code was implemented before it did not, breaking all kinds of code. RAW is raw, not magic quotes. This means that if

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Pierre
On 7/28/06, Derick Rethans [EMAIL PROTECTED] wrote: On Thu, 27 Jul 2006, Ilia Alshanetsky wrote: Well, that's great, but it should not prevent magic quotes from being applied. Until magic quotes is removed it should work, as the code was implemented before it did not, breaking all kinds of

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Ilia Alshanetsky
The raw data is left untouched. On 28-Jul-06, at 4:39 AM, Derick Rethans wrote: On Thu, 27 Jul 2006, Ilia Alshanetsky wrote: Well, that's great, but it should not prevent magic quotes from being applied. Until magic quotes is removed it should work, as the code was implemented before it

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-27 Thread Derick Rethans
On Thu, 27 Jul 2006, Ilia Alshanetsky wrote: iliaa Thu Jul 27 18:15:10 2006 UTC Modified files: /php-src/ext/filter filter.c Log: MFB: Fixed a bug in the filter extension that prevented magic_quotes_gpc from being applied when RAW filter is used.

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-27 Thread Pierre
On Thu, 27 Jul 2006 22:38:34 +0200 (CEST) [EMAIL PROTECTED] (Derick Rethans) wrote: On Thu, 27 Jul 2006, Ilia Alshanetsky wrote: iliaa Thu Jul 27 18:15:10 2006 UTC Modified files: /php-src/ext/filterfilter.c Log: MFB: Fixed a bug in the filter extension that

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-27 Thread Ilia Alshanetsky
Well, that's great, but it should not prevent magic quotes from being applied. Until magic quotes is removed it should work, as the code was implemented before it did not, breaking all kinds of code. On 27-Jul-06, at 4:38 PM, Derick Rethans wrote: On Thu, 27 Jul 2006, Ilia Alshanetsky