Re: [PHP-CVS] cvs: php-src /ext/pdo pdo.c pdo_dbh.c

2005-09-20 Thread Wez Furlong
Just add a helper macro to php_pdo_phpvers_compat.h for this. --Wez. On 9/20/05, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Jani, > > erm sorry, i meant move pdo into the standard ext dir not into > ext/standard of course. > > marcus > > Tuesday, September 20, 2005, 11:17:43 AM, you w

Re: [PHP-CVS] cvs: php-src /ext/pdo pdo.c pdo_dbh.c

2005-09-20 Thread Marcus Boerger
Hello Jani, erm sorry, i meant move pdo into the standard ext dir not into ext/standard of course. marcus Tuesday, September 20, 2005, 11:17:43 AM, you wrote: > Just change it in 5.1 and not make it sound like a big problem > what it isn't.. > And adding this into ext/standard

Re: [PHP-CVS] cvs: php-src /ext/pdo pdo.c pdo_dbh.c

2005-09-20 Thread Jani Taskinen
Just change it in 5.1 and not make it sound like a big problem what it isn't.. And adding this into ext/standard is very bad idea and step backwards. I wan't to be able to DISABLE this too. --Jani On Tue, 20 Sep 2005, Marcus Boerger wrote: Hello guys, in PHP 5.0 and 5

Re: [PHP-CVS] cvs: php-src /ext/pdo pdo.c pdo_dbh.c

2005-09-20 Thread Marcus Boerger
Hello guys, in PHP 5.0 and 5.1 zend_exception_get_default is a void function while in HEAD it is a TSRMLS_D function. We need to do something here. Probably providing a helper function. Or we change signature in 5.1. Or we move pdo core into ext/standard. what IMHO we should do anyway. regards