[PHP-DEV] Re: output buffering

2002-10-06 Thread Zeev Suraski
It's been a while since I touched that piece of code, so I don't remember how exactly it's supposed to work. However, right now, the URL rewriting code uses output buffering, so it's not too odd that the output is being buffered. Back when I made this change, I used a 4096-byte chunk size (an

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Zeev Suraski
I differ with you regarding whether we can or cannot tell people to pause development for a few weeks. Regardless, if we want to allow people to develop, I suggested using development branches (or branch), instead of using a release branch, for most of the duration of this release cycle. Giv

Re: [PHP-DEV] output buffering

2002-10-06 Thread Zeev Suraski
I requested that Yasuo reverts his patches, repeatedly, but as he hasn't, I was forced to do it manually myself. If I screwed up while reverting the patches myself, I apologize. I'll take a look. Zeev At 08:30 07/10/2002, Derick Rethans wrote: >On Sun, 6 Oct 2002, Rasmus Lerdorf wrote: > > >

Re: [PHP-DEV] Re: [PEAR-DEV] "pear package" broken

2002-10-06 Thread Sebastian Bergmann
Arnaud Limbourg wrote: > pear package package.xml > XML error: no element found at line 275 Same here. But the XML is valid, AFAICS. Maybe the XML parser reads incorrect due to streams? -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Did

[PHP-DEV] Re: [PEAR-DEV] "pear package" broken

2002-10-06 Thread Arnaud Limbourg
> "pear package" in the XML_Transformer directory creates a broken tgz > archive. The archive seems to have right filesize, but when I try to > "tar xvfz" it, I only get a "package.xml" file from it. > > Could this be related to current streams issues? It should not. I get the following

[PHP-DEV] "pear package" broken

2002-10-06 Thread Sebastian Bergmann
"pear package" in the XML_Transformer directory creates a broken tgz archive. The archive seems to have right filesize, but when I try to "tar xvfz" it, I only get a "package.xml" file from it. Could this be related to current streams issues? -- Sebastian Bergmann http://sebastian-b

Re: [PHP-DEV] output buffering

2002-10-06 Thread Derick Rethans
On Sun, 6 Oct 2002, Rasmus Lerdorf wrote: > I thought those changes were reverted? Not all as it seems... Christian Stocker also reported some problems IIRC. Derick > > On Mon, 7 Oct 2002, Sascha Schumann wrote: > > > Hi, > > > > the recent changes in the output buf layer are causin

Re: [PHP-DEV] Multiple copies of files in the source... why?

2002-10-06 Thread Rasmus Lerdorf
No idea. The guy to ask would be "Harald Radi" <[EMAIL PROTECTED]> -Rasmus On Sat, 5 Oct 2002, Dan Kalowsky wrote: > It was just pointed out to me that ext/rpc might be a good way to > implement some java fixes for PHP. > > So upon taking a look, I discovered that ext/rpc/java exists, and it i

Re: [PHP-DEV] output buffering

2002-10-06 Thread Rasmus Lerdorf
I thought those changes were reverted? On Mon, 7 Oct 2002, Sascha Schumann wrote: > Hi, > > the recent changes in the output buf layer are causing PHP to > buffer data too aggressively. > > The test case outputs two lines of HTML a few times and > expects these lines to be im

[PHP-DEV] output buffering

2002-10-06 Thread Sascha Schumann
Hi, the recent changes in the output buf layer are causing PHP to buffer data too aggressively. The test case outputs two lines of HTML a few times and expects these lines to be immediately forwarded to the url scanner. Regardless of the output_buffering/implicit_flush

Re: [PHP-DEV] using run-tests.php on windows

2002-10-06 Thread Melvyn Sopacua
Hey David, [EMAIL PROTECTED] ~/cvs/php4/ext/standard $ grep -2 is_executable ./php_filestat.h PHP_FUNCTION(is_readable); #ifndef PHP_WIN32 PHP_FUNCTION(is_executable); #endif PHP_FUNCTION(is_file); Seems it is disabled for WIN32, which makes sence, since every file on a windows machine, is by d

Re: [PHP-DEV] fread() is not returning content of big files (> 5kb not so big)

2002-10-06 Thread Melvyn Sopacua
At 03:33 7-10-2002, you wrote: [...] >If the contributor that has changed this can check that. To: [EMAIL PROTECTED] Subject: [PHP-CVS] cvs: php4 /main streams.c wez Sun Oct 6 19:27:53 2002 EDT Modified files: /php4/main streams.c Log: Try to ensure that we return the number of bytes requested

[PHP-DEV] using run-tests.php on windows

2002-10-06 Thread David Viner
hi, i'm trying to get the php tests to run on my windows 2k machine, and having a lot of trouble. i seem to fail at this line: if (@!is_executable($php)) { error("invalid PHP executable specified by TEST_PHP_EXECUTABLE = " . $php); } I removed the '@' to see what was happening,

Re: [PHP-DEV] fread() is not returning content of big files (> 5kb not so big)

2002-10-06 Thread Ilia A.
On October 6, 2002 09:33 pm, [EMAIL PROTECTED] wrote: > Can someone check the bug: http://bugs.php.net/?id=19783&edit=1 Wez commited a patch that address' this problem about an hour ago. After applying the patch I can open files without experiencing any problems you've described. I was able to

[PHP-DEV] Re: fread() is not returning content of big files (> 5kb not so big)

2002-10-06 Thread nicos
Futhermore, it looks it stops at 8192 bytes. -- Nicos - CHAILLAN Nicolas [EMAIL PROTECTED] www.WorldAKT.com - Hébergement de sites Internet <[EMAIL PROTECTED]> a écrit dans le message de news: [EMAIL PROTECTED] > Can someone check the bug: http://bugs.php.net/?id=19783&edit=1 > > It looks reall

[PHP-DEV] Re: fread() is not returning content of big files (> 5kb not so big)

2002-10-06 Thread nicos
I just verified len is correct so... -- Nicos - CHAILLAN Nicolas [EMAIL PROTECTED] www.WorldAKT.com - Hébergement de sites Internet <[EMAIL PROTECTED]> a écrit dans le message de news: [EMAIL PROTECTED] > Can someone check the bug: http://bugs.php.net/?id=19783&edit=1 > > It looks really import

[PHP-DEV] fread() is not returning content of big files (> 5kb not so big)

2002-10-06 Thread nicos
Can someone check the bug: http://bugs.php.net/?id=19783&edit=1 It looks really important: I dont know if it is because of the new handling of streams but I just verified that its working with PHP4.2.3 and not with 4_3 latest or if len = Z_LVAL_PP(arg2); is returning a wrong length, but there is

[PHP-DEV] session tests segfaulting...

2002-10-06 Thread David Reid
I'm getting a segfault on the following tests in ext/session... 3,7,8,9,12,13,14,18,19 & 21 Test 15 also fails. The system is BeOS. BeOS tends to be more conservative about memory than some systems and will segfault for errors where other systems carry on (which is a PITA!) I'll provide any he

[PHP-DEV] Re: Information about fread()

2002-10-06 Thread nicos
ext/standard/file.c:PHPAPI PHP_FUNCTION(fread) Sorry. -- Nicos - CHAILLAN Nicolas [EMAIL PROTECTED] www.WorldAKT.com - Hébergement de sites Internet <[EMAIL PROTECTED]> a écrit dans le message de news: [EMAIL PROTECTED] > Can someone tell me where are the locate the sources of fgets() and frea

[PHP-DEV] Information about fread()

2002-10-06 Thread nicos
Can someone tell me where are the locate the sources of fgets() and fread() please? Thanks. -- Nicos - CHAILLAN Nicolas [EMAIL PROTECTED] www.WorldAKT.com - Hébergement de sites Internet -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.p

Re: [PHP-DEV] Re: cvs: php4 /ext/pgsql pgsql.c php_pgsql.h

2002-10-06 Thread Yasuo Ohgaki
Both opinion makes sense to me, but any objections to remove alias from MySQL? -- Yasuo Ohgaki Andi Gutmans wrote: > It doesn't really make sense to me to add an alias to MySQL if it's not > needed. > The less aliases we have in PHP the better IMO. > > Andi > > At 11:04 AM 10/3/2002 +0900, Ya

RE: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread James Cox
> > Btw, it will be very usefull if someone can add $id and a little > > TODO inside the gd source :-))) > > I am very tempted to clean up the GD source. I hate the way it is > formatted. Nothing has happened since March 2001 from the Boutell folks > despite numerous bug patches sent their way.

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Pierre-Alain Joye
On Mon, 7 Oct 2002 01:36:16 +0200 Pierre-Alain Joye <[EMAIL PROTECTED]> wrote: > I do believe I ve write access to /php4 (only php4/pear), I > never need it, except now for the gd. oops :) I do not believe I ve got the write access to the php4 cvs tree :-) -- PHP Development Mailing List

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Pierre-Alain Joye
On Sun, 6 Oct 2002 16:34:15 -0700 (PDT) Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > > I am very tempted to clean up the GD source. I hate the way it is > formatted. Same here, it s a pain to work with it, as well as the big amout of different functions in the same file ;-) > Nothing has happ

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Rasmus Lerdorf
On Mon, 7 Oct 2002, Pierre-Alain Joye wrote: > Hello, > > On Sun, 6 Oct 2002 09:18:42 -0700 (PDT) > Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > > > the image rotation functions for GD that are waiting in the > > wings. > > I just updated the sources (http://www.pearfr.org/phpgd), it seems to > wo

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Pierre-Alain Joye
Hello, On Sun, 6 Oct 2002 09:18:42 -0700 (PDT) Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > the image rotation functions for GD that are waiting in the > wings. I just updated the sources (http://www.pearfr.org/phpgd), it seems to work well now(2'bugs' fixed). If it is urgent, I can add now the

[PHP-DEV] Re: Problems with unserialize

2002-10-06 Thread Wez Furlong
Well, I don't have a pear command and it doesn't look like HEAD builds or installs one either. But I've managed to track down the problem using pear.in manually; a fix is going in now. --Wez. On 06/10/02, "Derick Rethans" <[EMAIL PROTECTED]> wrote: > Hello, > > I think some recent change to th

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-06 Thread Ilia A.
On October 6, 2002 04:15 pm, Andi Gutmans wrote: > ctx->r->handler[strlen("application/x-httpd-php")] > > Is this actually the way it's supposed to work? (based on the length)? > Unless there's something I'm missing I'd prefer to see an strcmp() here. It > might be a bit slower but it's definitely

Re: [PHP-DEV] EXPECT replacevars in test harness

2002-10-06 Thread Rasmus Lerdorf
You have the karma. I don't see any reason not to add this. Go for it. -Rasmus On Sun, 6 Oct 2002, Melvyn Sopacua wrote: > Hi, > > there was a memory leak in the xslt extension, which down the line, can be > re-introduced. > > The problem is, that it cannot be tested for, since it requires an

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-06 Thread Andi Gutmans
ctx->r->handler[strlen("application/x-httpd-php")] Is this actually the way it's supposed to work? (based on the length)? Unless there's something I'm missing I'd prefer to see an strcmp() here. It might be a bit slower but it's definitely more robust for future changes. Andi At 12:06 PM 10/4

[PHP-DEV] Re: Problems with unserialize

2002-10-06 Thread nicos
Same for me, +1. -- Nicos - CHAILLAN Nicolas [EMAIL PROTECTED] www.WorldAKT.com - Hébergement de sites Internet "Derick Rethans" <[EMAIL PROTECTED]> a écrit dans le message de news: [EMAIL PROTECTED] > Hello, > > I think some recent change to the streams code screwed something up :) I > now get

[PHP-DEV] Problems with unserialize

2002-10-06 Thread Derick Rethans
Hello, I think some recent change to the streams code screwed something up :) I now get this when running "pear list": Notice: unserialize() failed at offset 8195 of 8192 bytes in Registry.php on line 328 Notice: unserialize() failed at offset 8188 of 8192 bytes in Registry.php on line 328

[PHP-DEV] EXPECT replacevars in test harness

2002-10-06 Thread Melvyn Sopacua
Hi, there was a memory leak in the xslt extension, which down the line, can be re-introduced. The problem is, that it cannot be tested for, since it requires an error to be generated and output. The error contains the filename, which is random. There are 2 things you can do: 1) str_replace the

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Melvyn Sopacua
At 18:18 6-10-2002, Rasmus Lerdorf wrote: >When the implicit_flush >mess is resolved and Melvyn gives the thumbs up for the Sablotron stuff >then I think we are ready for RC1. We're not entering any new features anymore. If we don't hear "this doesn't compile / work", and David has supplied a te

[PHP-DEV] Re: RFC: ext/xslt

2002-10-06 Thread Melvyn Sopacua
Sterling, At 22:20 2-10-2002, Sterling Hughes wrote: >http://www.bumblebury.com/phptodo/xmsl.html > >my thoughts on the matter... If you really want to handle XML, XSLT and >the like in PHP, the solution is to build a standardized, documented, >DOM, SAX, XPath, XInclude, XPointer interface, and

Re: [PHP-DEV] HEAD broken

2002-10-06 Thread Moriyoshi Koizumi
Oh sorry I was slightly unconscious of what I did... Thanks to Rasmus for the quick fix! Moriyoshi Koizumi Sebastian Bergmann <[EMAIL PROTECTED]> wrote: > c:\home\php\php4\ext\mbstring\php_mbregex.c(228): warning C4003: > Not enough parameters for macro 'RETVAL_STRING' > > c:\home\php

Re: [PHP-DEV] ini_set("register_globals", 1);

2002-10-06 Thread Derick Rethans
On Sat, 5 Oct 2002, Andi Gutmans wrote: > At 09:01 AM 10/3/2002 +0200, Sascha Schumann wrote: > > The session test scripts need to set register_globals -- does > > anyone see a problem with making that option setable in the > > script? > > > I don't think this is a good idea because so

Re: [PHP-DEV] ini_set("register_globals", 1);

2002-10-06 Thread Andi Gutmans
I don't think this is a good idea because some code which runs before the script runs depends on this. It doesn't make sense to make such a hack just for the tests, just to get some session code to run differently. Andi At 09:01 AM 10/3/2002 +0200, Sascha Schumann wrote: > The session test

Re: [PHP-DEV] Re: cvs: php4 /ext/pgsql pgsql.c php_pgsql.h

2002-10-06 Thread Andi Gutmans
It doesn't really make sense to me to add an alias to MySQL if it's not needed. The less aliases we have in PHP the better IMO. Andi At 11:04 AM 10/3/2002 +0900, Yasuo Ohgaki wrote: >Ok. I'll add alias to mysql and rename pgsql function. > >-- >Yasuo Ohgaki > >Derick Rethans wrote: >>On Wed, 2 O

Re: [PHP-DEV] Feature request -- feedback welcomed.

2002-10-06 Thread Andi Gutmans
You already have "public" which you can use instead of "var". I think method would look very nice but I don't think it's worth creating another reserved word. Andi At 01:34 PM 9/28/2002 -0600, Lamont R. Peterson wrote: >All: > >I can't hardly wait for PHP 4.3 (Zend 2.0) to hit the streets. I c

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-10-06 Thread Andi Gutmans
Please use sizeof("sid") and not 4 in such code. Also, why use hash_find() if just calling hash_del() would work? Andi At 12:05 AM 9/27/2002 +0200, Markus Fischer wrote: > Guys, > > _Please_ include bug fixes in NEWS entries (or separately > commit them) so we've complete log. > >

[PHP-DEV] HEAD broken

2002-10-06 Thread Sebastian Bergmann
c:\home\php\php4\ext\mbstring\php_mbregex.c(228): warning C4003: Not enough parameters for macro 'RETVAL_STRING' c:\home\php\php4\ext\mbstring\php_mbregex.c(228): warning C4003: Not enough parameters for macro 'ZVAL_STRING' c:\home\php\php4\ext\mbstring\php_mbregex.c(228): error C2059:

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Rasmus Lerdorf
I don't think we can just not provide some place for people to work on new code. We have way too many extensions in various states of development to just arbitrarily tell everyone to stop what they are doing. The ext/xslt work going on right now is a good example along with the image rotation func

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Melvyn Sopacua
Hi, whether to drop it/name it differently doesn't really fix anything. You need to sync at some point. I personally prefer to work on the branch, since that will get the attention of QA and RC processes and after release, merge everything into HEAD. But that would require, that HEAD remains vir

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Dan Kalowsky
Since for some reason I didn't get Zeev's original message, I'll just hack in responses here... :) On Sunday, October 6, 2002, at 05:01 AM, Derick Rethans wrote: > On Sun, 6 Oct 2002, Zeev Suraski wrote: > >> I think that given the circumstances, we should scratch the 4.3 >> branch and >> stic

[PHP-DEV] Re: cvs: php4 /ext/standard basic_functions.c var.c /main output.c

2002-10-06 Thread Yasuo Ohgaki
You should aware of sending buffered contents chunk by chunk is also problematic. i.e. ob_flush() and user specified chunk size. I guess you are going to fix(drop) ob_flush() along with other ob features ;) It does not make much sense not to have implicit/explict PHP buffer flushing, but I don't

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Edin Kadribasic
On Sunday 06 October 2002 10:54, Zeev Suraski wrote: > I think that given the circumstances, we should scratch the 4.3 branch and > stick to the main branch for this particular release, at least until we're > very close to the release itself. The vast majority of CVS traffic going > on these days

[PHP-DEV] Re: userstreams.phpt

2002-10-06 Thread Jan Lehnardt
Hi, On Sun, Oct 06, 2002 at 12:49:28PM +0100, Wez Furlong wrote: > The test actually passes, but the current output buffer problems mean > that the output that is normally discarded for a successful test is still > being output, and that causes the test harness to mark it as failed. thanks for the

[PHP-DEV] Re: userstreams.phpt

2002-10-06 Thread Wez Furlong
Hi Jan, The test actually passes, but the current output buffer problems mean that the output that is normally discarded for a successful test is still being output, and that causes the test harness to mark it as failed. --Wez. On 10/06/02, "Jan Lehnardt" <[EMAIL PROTECTED]> wrote: > Hi (wez),

Re: [PHP-DEV] Segfault in implode()

2002-10-06 Thread Sander Roobol
On Sun, Oct 06, 2002 at 12:10:17PM +0200, Martin Jansen wrote: > FYI: Yesterdays snapshot segfaults with the following line of code: > > $foo = implode("", array()); > ?> Fixed in CVS, thanks for the report. Sander -- PHP Development Mailing List

Re: [PHP-DEV] Segfault in implode()

2002-10-06 Thread Jan Lehnardt
Hi, On Sun, Oct 06, 2002 at 12:10:17PM +0200, Martin Jansen wrote: > FYI: Yesterdays snapshot segfaults with the following line of code: > > $foo = implode("", array()); > ?> I cannot reproduce this with current HEAD on FreeBSD, can you give more information about your bu

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Derick Rethans
On Sun, 6 Oct 2002, Zeev Suraski wrote: > I think we'd be better off waiting a bit with the php5 move. In general I > just don't think we can push a successful release while we continue > developing. If we concentrate on getting 4.3 out the door within a month, > we can then concentrate on

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Zeev Suraski
I think we'd be better off waiting a bit with the php5 move. In general I just don't think we can push a successful release while we continue developing. If we concentrate on getting 4.3 out the door within a month, we can then concentrate on php5. Zeev At 13:33 06/10/2002, Derick Rethans

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Derick Rethans
On Sun, 6 Oct 2002, Sander Roobol wrote: > On Sun, Oct 06, 2002 at 11:01:02AM +0200, Derick Rethans wrote: > > On Sun, 6 Oct 2002, Zeev Suraski wrote: > > > > > I think that given the circumstances, we should scratch the 4.3 branch and > > > stick to the main branch for this particular release,

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Sander Roobol
+1 on removing the branch - to avoid problems with staying in sync with head -1 on the php5 module - it'll move the sync problems to another place Sander On Sun, Oct 06, 2002 at 11:01:02AM +0200, Derick Rethans wrote: > On Sun, 6 Oct 2002, Zeev Suraski wrote: > > > I think that given the circum

[PHP-DEV] Segfault in implode()

2002-10-06 Thread Martin Jansen
FYI: Yesterdays snapshot segfaults with the following line of code: -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] CGI and PathInfo Oddity

2002-10-06 Thread Sebastian Bergmann
Environment: Current HEAD of PHP and Apache2 on Win32, CGI SAPI. Accessing http://wopr/index.php/lala yields an Fatal error: Unknown(): Unable to open C:\Server\htdocs\index.php\lala in Unknown on line 0 error message. It works fine with the Apache2Filter SAPI. -- S

Re: [PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Derick Rethans
On Sun, 6 Oct 2002, Zeev Suraski wrote: > I think that given the circumstances, we should scratch the 4.3 branch and > stick to the main branch for this particular release, at least until we're > very close to the release itself. The vast majority of CVS traffic going > on these days is bug f

[PHP-DEV] Scratching the 4.3 branch

2002-10-06 Thread Zeev Suraski
I think that given the circumstances, we should scratch the 4.3 branch and stick to the main branch for this particular release, at least until we're very close to the release itself. The vast majority of CVS traffic going on these days is bug fixes anyway, so creating the branch only makes it

[PHP-DEV] Warning in gd.c

2002-10-06 Thread Sebastian Bergmann
gd.c(1761): warning C4700: local variable 'toy' used without having been initialized -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/ -- PHP Development Mailing List