Re: [PHP-DEV] error handling

2002-11-18 Thread John Bradford
> I don't like this patch because it doesn't add anything to PHP itself. > You can easily do this with the error_prepend_string and > error_append_string configuration settings. > You were also told that this functionality can be achieved with > error_prepend_string and error_append_string ini

Re: [PHP-DEV] error handling

2002-11-18 Thread John Bradford
> I think in a modern web application the error handling function should do > the following: > in case of error (any: parse error, internal application error,) > > 1. a message should be shown to the user sayng that an error has occured > like "an internal error has occured. the webmaster has

[PHP-DEV] [CORRECTED] [PATCH] fancy_html_errors

2002-11-14 Thread John Bradford
Hi, Thanks for pointing me to README.SUBMITTING_PATCH - it's only included in the CVS tree, not in the releases. It might be a good idea to put it in distribution releases too - I did look around for such a guide before submitting. Anyway, here is a new patch against the CVS tree. Basically, I'

[PHP-DEV] [RESEND] [PATCH] fancy_html_errors

2002-11-14 Thread John Bradford
Ah, looks like I have to send the patch in-line, not as an attachment? John. diff --unified php-4.2.3.orig/main/main.c php-4.2.3/main/main.c --- php-4.2.3.orig/main/main.c 2002-07-25 10:35:18.0 +0100 +++ php-4.2.3/main/main.c 2002-11-14 19:02:44.0 + @@ -218,6 +218,7 @@

[PHP-DEV] [PATCH] fancy_html_errors

2002-11-14 Thread John Bradford
Hi, Firstly, please accept my appologies if this is the wrong list to send a patch to. PHP error messages in web pages are often made difficult to read by the surrounding HTML, and it occurred to me that style-sheet aware browsers could render errors in a more attention-getting way. Non style-sh