Re: [PHP-DEV] [PATCH] String function optimizations

2002-10-07 Thread Ilia A.
On October 4, 2002 11:27 am, Jani Taskinen wrote: > On Fri, 4 Oct 2002, Andrei Zmievski wrote: > >> Please let me know if there are any objections, better suggestions, bug > >> reports (pertaining to this patch) that would need to be resolved before > >> this bug goes into the CVS. > > > >I am not

Re: [PHP-DEV] [PATCH] String function optimizations

2002-10-04 Thread Jani Taskinen
On Fri, 4 Oct 2002, Andrei Zmievski wrote: >> Please let me know if there are any objections, better suggestions, bug >> reports (pertaining to this patch) that would need to be resolved before this >> bug goes into the CVS. > >I am not against merging this in before branching for 4.3.0, but we

Re: [PHP-DEV] [PATCH] String function optimizations

2002-10-04 Thread Jon Parise
On Thu, Oct 03, 2002 at 10:21:26PM -0400, Ilia A. wrote: > After doing a number of tests on PHP's various string functions, I've came up > with a patch that significantly improves the performance on those functions. > The patch optimizes: If anything, I think it makes the code much more readabl

Re: [PHP-DEV] [PATCH] String function optimizations

2002-10-04 Thread Derick Rethans
On Fri, 4 Oct 2002, Andrei Zmievski wrote: > On Thu, 03 Oct 2002, Ilia A. wrote: > > After doing a number of tests on PHP's various string functions, I've came up > > with a patch that significantly improves the performance on those functions. [...] > I am not against merging this in before br

Re: [PHP-DEV] [PATCH] String function optimizations

2002-10-04 Thread Andrei Zmievski
On Thu, 03 Oct 2002, Ilia A. wrote: > After doing a number of tests on PHP's various string functions, I've came up > with a patch that significantly improves the performance on those functions. > The patch optimizes: > php_addslashes() - internal PHP function used to add slashes to a strin

Re: [PHP-DEV] [PATCH] String function optimizations

2002-10-03 Thread Ilia A.
Small correction to the original patch, fixes a segv in sybase-style addslashes code as well as removes unused variable. Ilia On October 3, 2002 10:21 pm, Ilia A. wrote: > After doing a number of tests on PHP's various string functions, I've came > up with a patch that significantly improves th

[PHP-DEV] [PATCH] String function optimizations

2002-10-03 Thread Ilia A.
After doing a number of tests on PHP's various string functions, I've came up with a patch that significantly improves the performance on those functions. The patch optimizes: php_addslashes() - internal PHP function used to add slashes to a string