Re: [PHP-DEV] NSAPI patch / CVS access

2001-03-02 Thread Andi Gutmans
At 10:29 AM 3/2/2001 -0600, Andrew Johnson wrote: >Andi Gutmans wrote: > > > > I just reviewed the patch quickly. Are you sure that using MALLOC() for the > > SG(request_info) variables is OK? > >I think so. php4_execute() contains > nsapi_request_ctor(NSLS_C SLS_CC); > retval = n

Re: [PHP-DEV] NSAPI patch / CVS access

2001-03-02 Thread Andrew Johnson
Andi Gutmans wrote: > > I just reviewed the patch quickly. Are you sure that using MALLOC() for the > SG(request_info) variables is OK? I think so. php4_execute() contains nsapi_request_ctor(NSLS_C SLS_CC); retval = nsapi_module_main(NSLS_C SLS_CC); nsapi_request_dtor(NS

Re: [PHP-DEV] NSAPI patch / CVS access

2001-03-02 Thread Andi Gutmans
I just reviewed the patch quickly. Are you sure that using MALLOC() for the SG(request_info) variables is OK? Are these all variables which are supposed to be freed by the SAPI module? (I think they are but I don't have time to double check this). If the SAPI module is in charge then it's OK bu

Re: [PHP-DEV] NSAPI patch / CVS access

2001-03-02 Thread Andi Gutmans
I commited your patch. Andi At 01:26 PM 3/2/2001 +0100, Whitehead Anthony wrote: >Hiyas, > >I just tried to commit the attached patch to the NSAPI module but it seems my >CVS write >access has expired ;) > >Here attached is the patch for NSAPI from Andrew Johnson, I've tested it on >several UNIX

[PHP-DEV] NSAPI patch / CVS access

2001-03-02 Thread Whitehead Anthony
Hiyas, I just tried to commit the attached patch to the NSAPI module but it seems my CVS write access has expired ;) Here attached is the patch for NSAPI from Andrew Johnson, I've tested it on several UNIX platforms and adjusted it slightly to allow patching of the latest CVS version. If someon