Re: [PHP-DEV] PATCH - improvements for imap_headerinfo() (fwd)

2002-05-12 Thread Jon Parise
ECTED]> > To: Jani Taskinen <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] PATCH - improvements for imap_headerinfo() > > These changes don't (although I realize you shouldn't just take my word > for it) break the functionality of imap_hea

Re: [PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-24 Thread Adam Kauffman
These changes don't (although I realize you shouldn't just take my word for it) break the functionality of imap_headerinfo(). It just is a streamlined way of doing it. The function as it stands does a mail_fetchheader_full(), takes the result of that, and turns it into an envelope object. After

Re: [PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-24 Thread Jani Taskinen
What was this patch supposed to do again? At first glance it looks like it's modifying the imap_headerinfo() function quite dramatically and propably breaks it too.. Have you compared the output of this function without this patch and with it and does it return the

Re: [PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-24 Thread Adam Kauffman
On Tue, 2002-04-23 at 18:23, Jani Taskinen wrote: > > Please make a unified diff against the CVS HEAD (cvs diff -u). > > --Jani Index: php_imap.c === RCS file: /repository/php4/ext/imap/php_imap.c,v retrieving revision

Re: [PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-23 Thread Jani Taskinen
Please make a unified diff against the CVS HEAD (cvs diff -u). --Jani On Tue, 23 Apr 2002 [EMAIL PROTECTED] wrote: >I posted the wrong file to the last email... must find coffee or sleep :-) > >1573c1573 >< char dummy[2000], fulladdress[MAILTMPLEN]; >--- >> char *m

Re: [PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-23 Thread adam.kauffman
I posted the wrong file to the last email... must find coffee or sleep :-) 1573c1573 < char dummy[2000], fulladdress[MAILTMPLEN]; --- > char *mystring, dummy[2000], fulladdress[MAILTMPLEN]; 1608c1608,1617 < en = mail_fetchenvelope(imap_le_struct->imap_stream, Z_LVAL_PP(msgno));

Re: [PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-23 Thread adam.kauffman
Hmmm... does the list filter attachments? Anyways, sorry for sending twice. Hi all, After getting done with a pretty large PHP4 project, I have a patch I would like to submit for php_imap.c in the IMAP extension. Here is what this patch does: imap_headerinfo() really only needs envelope info

[PHP-DEV] PATCH - improvements for imap_headerinfo()

2002-04-23 Thread adam.kauffman
Hi all, After getting done with a pretty large PHP4 project, I have a patch I would like to submit for php_imap.c in the IMAP extension. Here is what this patch does: imap_headerinfo() really only needs envelope info whereas the current version fetches all headers and requires a BODY.PEEK. T