[PHP-DEV] Patch for file.c

2002-05-22 Thread Dean Richard Benson
Apologies for my previous attempt at submitting the patch for file.c. Here is the new patch file. Basically it adds a fourth optional parameter to fgetcsv which means you can specify the enclosure character (currently assumes a double quote). This is only my first attempt at contributing code t

Re: [PHP-DEV] Patch for file.c

2002-05-21 Thread Yasuo Ohgaki
Dean Richard Benson wrote: > Ok, here is my first try! :) (please let me know if its ok). It seems you are using 5 spaces for indent while we use tabs. I suggest you to read README.SUBMITTING_PATCH. -- Yasuo Ohgaki -- PHP Development Mailing List To unsubscribe, vi

Re: [PHP-DEV] Patch for file.c

2002-05-21 Thread Dean Richard Benson
On Tue, May 21, 2002 at 05:32:10PM +0200, Stig S. Bakken wrote: > > I wasn't sure if I could just attach my file.c.patch file to this email > > or not? > > That's fine, but make sure the MIME type for the attachment is > text/plain or the mailing list software will remove it. Ok, here is my firs

Re: [PHP-DEV] Patch for file.c

2002-05-21 Thread Stig S. Bakken
On Tue, 2002-05-21 at 17:28, Dean Richard Benson wrote: > Hi all > > I have been working on a system recently that has been using the fgetcsv > function. > > It works a treat except that the code "assumes" that the enclosure > character will always be a double quote. This caused me a little bit

[PHP-DEV] Patch for file.c

2002-05-21 Thread Dean Richard Benson
Hi all I have been working on a system recently that has been using the fgetcsv function. It works a treat except that the code "assumes" that the enclosure character will always be a double quote. This caused me a little bit of a problem as many of the csv files that I work with use the single