[PHP-DEV] Re: [PATCH] session module

2002-02-04 Thread Yasuo Ohgaki
Yasuo Ohgaki wrote: > Hi all, > > If you have comments, please feedback before I apply > this patch. > > Attached patch fixes many problems in session module. > It also breaks some of script which barely worked before. > > This patch fixes: > - Crashes are caused by invlaid save_path, invalid

[PHP-DEV] Re: [PATCH] session module (fwd)

2002-02-03 Thread Yasuo Ohgaki
Yasuo Ohgaki wrote: > Thanks for your reply :) > > Sascha Schumann wrote: >>> - Broken mm save handler. >>> >> >> Your patch to mod_mm.c always returns SUCCESS, even if the >> operation fails. That's pointless, the caller function >> checks for that return value. I also disagree wi

[PHP-DEV] Re: [PATCH] session module (fwd)

2002-02-03 Thread Yasuo Ohgaki
Thanks for your reply :) Sascha Schumann wrote: > Hi, > > looks like you have put a lot of work into this one :-) > > Thanks for keeping up the work on the session module. > > >> - Crashes are caused by invlaid save_path, invalid >>session id name, return value from user defi

[PHP-DEV] Re: [PATCH] session module (fwd)

2002-02-03 Thread Sascha Schumann
Hi, looks like you have put a lot of work into this one :-) Thanks for keeping up the work on the session module. > - Crashes are caused by invlaid save_path, invalid > session id name, return value from user defined session function. > There may be other crashes observed