Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-10 Thread Sebastian Bergmann
Markus Fischer wrote: It is not publicly exposed with ZEND_API(). I can't test right now, but maybe just need to modify the zend_compile.h file and prepend the prototype definition with ZEND_API ? Yes, prefixing the prototype with ZEND_API did the trick. Andi, Zeev, is this

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-10 Thread Andi Gutmans
At 09:21 AM 2/10/2002 +0100, Sebastian Bergmann wrote: Markus Fischer wrote: It is not publicly exposed with ZEND_API(). I can't test right now, but maybe just need to modify the zend_compile.h file and prepend the prototype definition with ZEND_API ? Yes, prefixing the

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-09 Thread Markus Fischer
On Sat, Feb 09, 2002 at 08:00:28AM +0100, Sebastian Bergmann wrote : Sebastian Bergmann wrote: tokenizer.c C:\home\php\php4\ext\tokenizer\tokenizer.c(328): error C2198: 'lex_scan': Not enough parameters C:\home\php\php4\ext\tokenizer\tokenizer.c(344): error C2065: 'tsrm_ls':

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-09 Thread Sebastian Bergmann
Markus Fischer wrote: You don't need (and shouldn't) call TSRMLS_FETCH() here. Declaring tokenizer() having a TSRMLS_DC and passing TSRMLS_CC when calling it should be sufficient. Stupid me, of course. The patch below fixes all compiler errors and warnings. However, I now get

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-09 Thread Markus Fischer
On Sat, Feb 09, 2002 at 10:33:35AM +0100, Sebastian Bergmann wrote : Markus Fischer wrote: You don't need (and shouldn't) call TSRMLS_FETCH() here. Declaring tokenizer() having a TSRMLS_DC and passing TSRMLS_CC when calling it should be sufficient. Stupid me, of course.

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-09 Thread Sebastian Bergmann
Markus Fischer wrote: It is not publicly exposed with ZEND_API(). I can't test right now, but maybe just need to modify the zend_compile.h file and prepend the prototype definition with ZEND_API ? My desktop PC went *poof* today, in lack of a better word. I don't have a build

[PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-08 Thread Sebastian Bergmann
Sebastian Bergmann wrote: Log: Add MSVC workspace for tokenizer extension. Add php_tokenizer.dll entries to php.ini-*. tokenizer.c C:\home\php\php4\ext\tokenizer\tokenizer.c(328): error C2198: 'lex_scan': Not enough parameters C:\home\php\php4\ext\tokenizer\tokenizer.c(344): error

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer

2002-02-08 Thread Sebastian Bergmann
Sebastian Bergmann wrote: tokenizer.c C:\home\php\php4\ext\tokenizer\tokenizer.c(328): error C2198: 'lex_scan': Not enough parameters C:\home\php\php4\ext\tokenizer\tokenizer.c(344): error C2065: 'tsrm_ls': Undeclared identifier C:\home\php\php4\ext\tokenizer\tokenizer.c(483): error C2198: