[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Jim Winstead
Andi Gutmans [EMAIL PROTECTED] wrote: I don't think having a function which outputs an uploaded file is useful. So please only implement one which returns the file. wouldn't it be most useful to have a function that just *opens* the uploaded file, so people can use fpassthru() or fread() or

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Rasmus Lerdorf
That's already the case though. On 23 Mar 2002, Jim Winstead wrote: Andi Gutmans [EMAIL PROTECTED] wrote: I don't think having a function which outputs an uploaded file is useful. So please only implement one which returns the file. wouldn't it be most useful to have a function that just

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Jim Winstead
okay, so then what is the point of adding a new function to read an uploaded file? it sounds like the original justification was completely off-base. the original patch said: I created function `read_uploaded_file()`, i think it is useful at to work with uploaded file in safe_mode and

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Andi Gutmans
At 11:11 23/03/2002 -0800, Rasmus Lerdorf wrote: okay, so then what is the point of adding a new function to read an uploaded file? it sounds like the original justification was completely off-base. Yup, as far as I can see it is a completely useless function other than the fact that it

Re[2]: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Andrew Sitnikov
Hello Rasmus, RL Yup, as far as I can see it is a completely useless function other than RL the fact that it reads an entire file into a string. This is actually RL something we should add, but it should be a generic load_file() or RL str_file() or some other such function. RL -Rasmus Probably

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Jim Winstead
Andrew Sitnikov [EMAIL PROTECTED] wrote: RL Yup, as far as I can see it is a completely useless function other than RL the fact that it reads an entire file into a string. This is actually RL something we should add, but it should be a generic load_file() or RL str_file() or some other such

Re[3]: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-03-23 Thread Andrew Sitnikov
Hello Rasmus, RL That's where you are wrong. Look at the php_checkuid() function in RL safe_mode.c you will find this code: RL if (SG(rfc1867_uploaded_files)) { RL if (zend_hash_exists(SG(rfc1867_uploaded_files), (char *) filename, strlen(filename)+1)) { RL

Re: [PHP-DEV] RE: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2001-05-22 Thread Andrei Zmievski
On Mon, 21 May 2001, Sean R. Bright wrote: Since this move happened, I have been getting segfaults with the following script: ?php print_r(get_defined_constants()); ? I don't get any segfaults, it just works. Try doing 'make clean' and recompiling. -Andrei * Apples have always been

[PHP-DEV] RE: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2001-05-21 Thread Sean R. Bright
Since this move happened, I have been getting segfaults with the following script: ?php print_r(get_defined_constants()); ? -Original Message- From: Andrei Zmievski [mailto:[EMAIL PROTECTED]] Sent: Monday, May 21, 2001 11:44 AM To: [EMAIL PROTECTED] Subject: [PHP-CVS] cvs: