Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-06 Thread Maxim Maletsky
I *very slightly* tested it and it worked for me. Not sure of the old code though. -- Maxim Maletsky [EMAIL PROTECTED] "Ilia A." <[EMAIL PROTECTED]> wrote... : > On November 5, 2002 09:44 pm, Moriyoshi Koizumi wrote: > > Ilia, thank you for double-checking. > > > > Since I have no access to Z

Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV]bug #19943)

2002-11-05 Thread Andi Gutmans
We'll take a look at this. Thanks, Andi At 07:48 AM 11/6/2002 +0900, Moriyoshi Koizumi wrote: The attached patch may be a fix for that bug. Hope it works. Moriyoshi Moriyoshi Koizumi <[EMAIL PROTECTED]> wrote: > I looked into it, and I've found you really got a point. > >

Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-05 Thread Ilia A.
On November 5, 2002 09:44 pm, Moriyoshi Koizumi wrote: > Ilia, thank you for double-checking. > > Since I have no access to Zend module, I'm waiting for that to be > committed by someone for now... Does it need more review? It would probably be a good idea if more developers review this patch befo

Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-05 Thread Moriyoshi Koizumi
Ilia, thank you for double-checking. Since I have no access to Zend module, I'm waiting for that to be committed by someone for now... Does it need more review? Moriyoshi "Ilia A." <[EMAIL PROTECTED]> wrote: > The new appears to work correctly and previously mentioned problem no longer > occ

Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-05 Thread Ilia A.
The new appears to work correctly and previously mentioned problem no longer occures. I've also ran the test suit after applying the patch and none of the tests have been adversly affected, so it does not appear to break any old functionality. Ilia On November 5, 2002 09:17 pm, Moriyoshi Koizu

Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-05 Thread Moriyoshi Koizumi
> The patch does work and memory leak goes away after it is applied. There is > another problem that I've just noticed. If you increase the loop from 10 to > 100 then you'll see that the $ragged[$count]['idx'] value is always the 1st > character of the $ragged[$count] value. > If a var_dump of

Re: [PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-05 Thread Ilia A.
The patch does work and memory leak goes away after it is applied. There is another problem that I've just noticed. If you increase the loop from 10 to 100 then you'll see that the $ragged[$count]['idx'] value is always the 1st character of the $ragged[$count] value. If a var_dump of an array i

[PHP-DEV] [PATCH] A suggested fix for bug #19943 (Re: [PHP-DEV] bug #19943)

2002-11-05 Thread Moriyoshi Koizumi
The attached patch may be a fix for that bug. Hope it works. Moriyoshi Moriyoshi Koizumi <[EMAIL PROTECTED]> wrote: > I looked into it, and I've found you really got a point. > > --- > $ragged = array(); > $ragged[0] = "a"; > $ragged[0][0] = array("1"); > var_dump($rag

Re: [PHP-DEV] bug #19943

2002-11-05 Thread Moriyoshi Koizumi
I looked into it, and I've found you really got a point. --- --- The first script causes no leaks, while the second does: --- --- Thanks for your insight. Moriyoshi "Ilia A." <[EMAIL PROTECTED]>

Re: [PHP-DEV] bug #19943

2002-11-05 Thread Ilia A.
I agree with you that this bug may not be critical, I am not certain why it was marked as such, however I do believe this is a bug that should be fixed. If my understand of the situation is correct, the memory leak is the result of original $ragged[$count] = "$count"; expression. At this point ZE

[PHP-DEV] bug #19943

2002-11-05 Thread Moriyoshi Koizumi
This appears not a bug, but an expected behaviour for me. Let's change it from "Critial" to "Won't Fix" or so on. --- --- The above snippet is actually a variant of the followi