RE: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Zeev Suraski
, but I did get a clean copy from CVS. > >Thanks, >Sean > > > -Original Message- > > From: Zeev Suraski [mailto:[EMAIL PROTECTED]] > > Sent: Saturday, January 13, 2001 6:28 PM > > To: [EMAIL PROTECTED] > > Cc: [EMAIL PROTECTED] > > Subject: Re: FW

RE: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Sean R. Bright
t; To: 'Zeev Suraski' > Cc: [EMAIL PROTECTED] > Subject: RE: FW: [PHP-DEV] file.c fsock.c ... Again ... > > > Thanks, you may want to check it thread safe again as well. > Getting alot of > errors that look like this: > > /usr/cvs/php4/ext/standard/exec.c:53: undefined

Re: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Jim Jagielski
It's the wrapper for ZTS not fully wrapping what it should... Derick Rethans wrote: > > Hello, > > can you try the latest CVS? Zeev did some work on it today. > > Derick -- === Jim Jagielski [|] [EMAIL PROTECTED]

RE: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Sean R. Bright
EMAIL PROTECTED] > Subject: Re: FW: [PHP-DEV] file.c fsock.c ... Again ... > > > Ok, I did the development under Windows and didn't check the > thread-unsafe > mode. I'll fix it. > > At 00:54 14/1/2001, Sean R. Bright wrote: > > >Already did, these are

Re: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Zeev Suraski
> > From: Derick Rethans [mailto:[EMAIL PROTECTED]] > > Sent: Saturday, January 13, 2001 6:04 PM > > To: Sean R. Bright > > Cc: [EMAIL PROTECTED] > > Subject: Re: [PHP-DEV] file.c fsock.c ... Again ... > > > > > > Hello, > > > > can you try

RE: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Sean R. Bright
D'oh! Ok... But my build is broken... Wh! ;) Thanks, Sean > -Original Message- > From: Derick Rethans [mailto:[EMAIL PROTECTED]] > Sent: Saturday, January 13, 2001 6:18 PM > To: Sean R. Bright > Cc: 'Derick Rethans'; [EMAIL PROTECTED] >

RE: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Derick Rethans
On Sat, 13 Jan 2001, Sean R. Bright wrote: > Derick: > > No, they fixed some of the problems, but if you read the code snippet that I > included below, you will see that file_globals_ctor and file_globals_dtor > are defined inside the preprocessor macros for ZTS, so if ZTS is not defined > they a

RE: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Sean R. Bright
> > > > -Original Message- > > > From: Derick Rethans [mailto:[EMAIL PROTECTED]] > > > Sent: Saturday, January 13, 2001 6:04 PM > > > To: Sean R. Bright > > > Cc: [EMAIL PROTECTED] > > > Subject: Re: [PHP-DEV] file.c fsock.c ...

Re: FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Derick Rethans
; > Sent: Saturday, January 13, 2001 6:04 PM > > To: Sean R. Bright > > Cc: [EMAIL PROTECTED] > > Subject: Re: [PHP-DEV] file.c fsock.c ... Again ... > > > > > > Hello, > > > > can you try the latest CVS? Zeev did some work on it today. > > >

FW: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Sean R. Bright
Already did, these are happening after getting your changes. (I watch the cvs list as well ;)) > -Original Message- > From: Derick Rethans [mailto:[EMAIL PROTECTED]] > Sent: Saturday, January 13, 2001 6:04 PM > To: Sean R. Bright > Cc: [EMAIL PROTECTED] > Subject: Re

Re: [PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Derick Rethans
Hello, can you try the latest CVS? Zeev did some work on it today. Derick On Sat, 13 Jan 2001, Sean R. Bright wrote: > > Anyone see the logical problem with this besides me? > > #ifdef ZTS > static void file_globals_ctor(FLS_D) <--- THIS is defined if thread safe > { > zend_hash_init(&

[PHP-DEV] file.c fsock.c ... Again ...

2001-01-13 Thread Sean R. Bright
Anyone see the logical problem with this besides me? #ifdef ZTS static void file_globals_ctor(FLS_D) <--- THIS is defined if thread safe { zend_hash_init(&FG(ht_fsock_keys), 0, NULL, NULL, 1); zend_hash_init(&FG(ht_fsock_socks), 0, NULL, (void (*)(void *))php_msock_destroy, 1);