Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-03 Thread Marcus Börger
Wez, the getimagesize() failure was in the streams read function and not as expected in the seeker function. I also checked some others which seem ok but do not have much time for now. marcus p.s.: Thanks for the image to rasmus. Let me guess it's your son? May i add the image to my test

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-03 Thread Rasmus Lerdorf
p.s.: Thanks for the image to rasmus. Let me guess it's your son? May i add the image to my test images? I would add a comment in the exif header of cause... Yup, that's Carl. And go ahead. -Rasmus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit:

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-02 Thread Andrei Zmievski
On Tue, 01 Oct 2002, Rasmus Lerdorf wrote: So result is never filled in as it doesn't think we hit any markers. Yet a file foo.jpg returns: foo.jpg: JPEG image data, JFIF standard 1.02, resolution (DPI), 72 x 72 I have tried it with a number of different jpegs. My libjpeg is:

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-02 Thread Rasmus Lerdorf
Hrm... Actually, after a bit more checking it is only some jpegs that don't work. Specifically the ones coming from my digital camera are no longer working. Images that used to work with getimagesize() are now not, so I think something changed. Try running getimagesize() on this image:

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-02 Thread Andrei Zmievski
On Wed, 02 Oct 2002, Rasmus Lerdorf wrote: Hrm... Actually, after a bit more checking it is only some jpegs that don't work. Specifically the ones coming from my digital camera are no longer working. Images that used to work with getimagesize() are now not, so I think something changed.

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-02 Thread Marcus Börger
At 15:42 02.10.2002, Andrei Zmievski wrote: On Wed, 02 Oct 2002, Rasmus Lerdorf wrote: Hrm... Actually, after a bit more checking it is only some jpegs that don't work. Specifically the ones coming from my digital camera are no longer working. Images that used to work with getimagesize()

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-02 Thread Rasmus Lerdorf
Just to make sure I am not crazy, I checked 4.2.3. getimagesize() on that azj.jpg image returns: array(6) { [0]= int(1536) [1]= int(1024) [2]= int(2) [3]= string(26) width=1536 height=1024 [bits]= int(8) [channels]= int(3) } which is correct. So we definitely do have

Re: [PHP-DEV] getimagetype() broken for jpegs?

2002-10-02 Thread Wez Furlong
Yep, it's probably the streams code (specifically the seeking that marcus mentioned). Also, I think there is now a slight bug with fopen wrappers under win32. I'm all of a sudden really pushed for time, so I might not be able to fix this before saturday - if that is the case, I'll make an effort

[PHP-DEV] getimagetype() broken for jpegs?

2002-10-01 Thread Rasmus Lerdorf
It seems like php_handle_jpeg() called by getimagetype() is always returning null. Here is a trace: 937 itype = php_getimagetype(stream, NULL TSRMLS_CC); 938 switch( itype) { itype is 2 at this point (2 = jpeg) 943 if (info) { 946