Re: [REVIEW] PSR-11 Container Interface

2016-10-26 Thread Hari K T
Hi @mwop, Thank you for your comments. I am writing inline for I don't miss anything. > The only concern to me is > > https://github.com/container-interop/container-interop/issues/69 > regarding > > return value of get . > > > > Basically this is the text : > > > > Two successive calls to get wi

Re: [REVIEW] PSR-11 Container Interface

2016-10-26 Thread Matthew Weier O'Phinney
On Wed, Oct 26, 2016 at 8:59 AM, Hari K T wrote: > The only concern to me is > https://github.com/container-interop/container-interop/issues/69 regarding > return value of get . > > Basically this is the text : > > Two successive calls to get with the same identifier SHOULD return the same > value

Re: [REVIEW] PSR-11 Container Interface

2016-10-26 Thread Matthew Weier O'Phinney
On Wed, Oct 26, 2016 at 8:58 AM, Stephan Hochdörfer wrote: > Just wondering which PHP version are we targeting with the PSR? Or to be > more precise: Shouldn't we add parameter type hints and return type > declarations where possible? As Andreas already pointed out, it makes sense to support the

Re: [REVIEW] PSR-11 Container Interface

2016-10-26 Thread Andreas Heigl
Hi all. Am 26.10.16 um 15:58 schrieb Stephan Hochdörfer: > Just wondering which PHP version are we targeting with the PSR? Or to be > more precise: Shouldn't we add parameter type hints and return type > declarations where possible? As PHP5.6 is supposed to be supported until Dec. 2018 (http://ph

Re: [REVIEW] PSR-11 Container Interface

2016-10-26 Thread Hari K T
Hi, The only concern to me is https://github.com/container-interop/container-interop/issues/69 regarding return value of get . Basically this is the text : Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user

Re: [REVIEW] PSR-11 Container Interface

2016-10-26 Thread Stephan Hochdörfer
Just wondering which PHP version are we targeting with the PSR? Or to be more precise: Shouldn't we add parameter type hints and return type declarations where possible? Stephan Hochdörfer -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperabi

[REVIEW] PSR-11 Container Interface

2016-10-26 Thread Matthew Weier O'Phinney
Hello, everyone! PSR-11, Container Interface (née container-interop) has been in incubation for a couple years now, and the editor and sponsors feel it is ready for review. As coordinator, I hereby open the mandatory review period prior to a formal acceptance vote; voting will begin no earlier tha