Re: Proposal for extended coding style guide

2017-10-24 Thread 'Alexander Makarov' via PHP Framework Interoperability Group
Results are in the meta doc. As far as I remember, type casting was not in the survey. On Tuesday, October 24, 2017 at 6:35:10 AM UTC+3, Adrien Crivelli wrote: > > I also use the second case. > > Should we open a poll for that ? Or was it covered in the survey that were > done a long time ago ?

Re: Proposal for extended coding style guide

2017-10-23 Thread Adrien Crivelli
I also use the second case. Should we open a poll for that ? Or was it covered in the survey that were done a long time ago ? and by the way were that survey result ever published ? -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Gr

Re: Proposal for extended coding style guide

2017-10-23 Thread Rivera, John
call_user_func() needs to die a fiery death. But I digress. There’s also (new Thing())->doThing();, with no spaces. But I admit I do not have a particularly strong opinion on this — if someone says the standard is to have a space in-between then I won’t argue too much :). On Oct 23, 2017, at 1

Re: Proposal for extended coding style guide

2017-10-23 Thread Woody Gilk
Type casting and syntax "hacks" (eg: to call a closure assigned as a property) are very different and not comparable, IMO. My personal preference would be: $foo = (int) $foo; and return ($this->callback)(); // or return call_user_func($this->callback); -- Woody Gilk http://about.me/shadowhand

Re: Proposal for extended coding style guide

2017-10-23 Thread Rivera, John
I’ve always used the first case. Consider another similar situation: calling a callable that’s also a property of self. You’d have to call it with parentheses — that is, ($callback)(); with no spaces. I feel like the first case is more consistent when taking into account the rest of the language

Re: Proposal for extended coding style guide

2017-10-23 Thread Woody Gilk
I've always used the second case. The first feels really cramped IMO. On Mon, Oct 23, 2017, 04:47 'Alexander Makarov' via PHP Framework Interoperability Group wrote: > Same here. Using 1st case. > > > On Monday, October 23, 2017 at 12:28:17 PM UTC+3, Alessandro Lai wrote: >> >> This is an intere

Re: Proposal for extended coding style guide

2017-10-23 Thread 'Alexander Makarov' via PHP Framework Interoperability Group
Same here. Using 1st case. On Monday, October 23, 2017 at 12:28:17 PM UTC+3, Alessandro Lai wrote: > > This is an interesting topic. I've always found inconsistencies on this > topic, since some formatters use the first case, others the latter. > > I'm inclined for the first case, since it's norm

Re: Proposal for extended coding style guide

2017-10-23 Thread Alessandro Lai
This is an interesting topic. I've always found inconsistencies on this topic, since some formatters use the first case, others the latter. I'm inclined for the first case, since it's normally applied just to the symbol at the immediate right of it... Il giorno lunedì 23 ottobre 2017 08:56:35 U

Proposal for extended coding style guide

2017-10-22 Thread Anton Okolelov
Hello Could you please add typecasting space issue in https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md ? $intValue = (int)$stringValue; or $intValue = (int) $stringValue; Thank you -- You received this message because you are subscribed to the