Commit:    58b512b43641901c22e518ed10fdb6d67d60f9cd
Author:    Tyson Andre <tysonandre...@hotmail.com>         Sat, 9 Jan 2021 
19:03:04 -0500
Committer: Christoph M. Becker <cmbecke...@gmx.de>      Tue, 19 Jan 2021 
19:31:03 +0100
Parents:   8f17e3b4c89ee67556f4fd0d693404b4d09727f7
Branches:  master

Link:       
http://git.php.net/?p=web/windows.git;a=commitdiff;h=58b512b43641901c22e518ed10fdb6d67d60f9cd

Log:
Proposal: Use bold headers only for 64-bit downloads

See https://externals.io/message/112808

I'd also considered something like `opacity: 0.6` for the entire section
but it seemed either hard to notice it was faded or illegible.

E.g. https://golang.org/dl/ uses bold for the most common x86-64
architecture.

Make the recommended download choice clearer for users unfamiliar
with the terms x86/x64.

- 64-bit PHP and libraries are generally more thoroughly tested
- 32-bit builds currently have the year 2038 problem

Co-authored-by: Christoph M. Becker <cmbecke...@gmx.de>

Closes GH-25.

Changed paths:
  M  docroot/listing.php
  M  docroot/styles/content.css
  M  templates/left_column.php


Diff:
diff --git a/docroot/listing.php b/docroot/listing.php
index 1ef8022..d35df48 100644
--- a/docroot/listing.php
+++ b/docroot/listing.php
@@ -148,7 +148,7 @@ if (isset($versions[$major]['test_pack'])) {
 
 <?php if (isset($versions[$major][$minor])) {
 ?>
-               <div class="innerbox">
+               <div class="innerbox<?= stripos($minor, 'x86') !== false ? ' 
x86' : ''; ?>">
                <span class="corners-top"><span></span></span>
 
                <h4 id="php-<?php echo $major . '-' . $minor; ?>" 
name="php-<?php echo $major . '-' . $minor;?>"><?php echo $labels[$minor]; ?> 
(<?php echo $versions[$major][$minor]['mtime']; ?>)</h4>
diff --git a/docroot/styles/content.css b/docroot/styles/content.css
index bbdee50..1353f77 100644
--- a/docroot/styles/content.css
+++ b/docroot/styles/content.css
@@ -475,6 +475,10 @@
        font-weight:bold;
 }
 
+.content .info .x86 h4 {
+       font-weight:normal;
+}
+
 .content .info h3 a {
        color:#000;
 }
diff --git a/templates/left_column.php b/templates/left_column.php
index b833f7a..16cb90a 100644
--- a/templates/left_column.php
+++ b/templates/left_column.php
@@ -93,6 +93,7 @@ if ((isset($mode) && ($mode == 'snapshots' || $mode == 'qa'))
                                                                        <a 
name="x64"> </a>
                                                                        
<h4><u>amd64 (x86_64) Builds</u></h4>
                                                                        
<p><strong>PHP 7 provides full 64-bit support.</strong> The x64 builds of PHP 7 
support native 64-bit integers, LFS, 64-bit memory_limit and much more.</p>
+                                                                       <p>x64 
builds are recommended (almost all Windows installations support x64).</p>
 
                                                                        <a 
name="long_path"></a>
                                                                        
<h4><u>Long and multibyte path</u></h4>


--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to