Re: [PHP-DOC] Patch Review

2009-07-02 Thread Hannes Magnusson
On Thu, Jul 2, 2009 at 15:31, Moacir de Oliveira wrote: > Hi guys, > > can you review this patch? > > do you think I should use aggregators or just use elseif sections in the > function SQLiteIndex? Is there any performance difference? I think having their own functions is more readable.. -Hanne

[PHP-DOC] Patch Review

2009-07-02 Thread Moacir de Oliveira
Hi guys, can you review this patch? do you think I should use aggregators or just use elseif sections in the function SQLiteIndex? thx --Moacir Index: Format.php === RCS file: /repository/phd/phpdotnet/phd/Format.php,v retrieving r

Re: [PHP-DOC] Patch review

2008-11-02 Thread Ross Masters
Thanks Hannes :) -- Ross Masters [EMAIL PROTECTED] http://www.uvshock.co.uk/blog

Re: [PHP-DOC] Patch review

2008-11-02 Thread Hannes Magnusson
On Sun, Nov 2, 2008 at 17:34, Ross Masters <[EMAIL PROTECTED]> wrote: > Hi all, > > I've been doing some work on the datetime extension, and while I'm ready to > commit I'm a little unsure about somethings (mainly PEAR CS). If someone > could verify the following questions that would be great. > >

[PHP-DOC] Patch review

2008-11-02 Thread Ross Masters
Hi all, I've been doing some work on the datetime extension, and while I'm ready to commit I'm a little unsure about somethings (mainly PEAR CS). If someone could verify the following questions that would be great. Firstly throughout the DateTime methods we can use procedural or object-orien